[soft navs] Clean up SoftNavigationTestHelper.get*PerformanceEntries* [chromium/src : main]
0 views
Skip to first unread message
Scott Haseley (Gerrit)
5:48 PM (5 hours ago) 5:48 PM
to Johannes Henkel, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Attention needed from Johannes Henkel and Michal Mocny
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Johannes Henkel
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michal Mocny (Gerrit)
5:56 PM (5 hours ago) 5:56 PM
to Scott Haseley, Johannes Henkel, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Attention needed from Johannes Henkel and Scott Haseley
Michal Mocny voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Johannes Henkel
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
5:59 PM (5 hours ago) 5:59 PM
to Scott Haseley, Michal Mocny, Johannes Henkel, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Attention needed from Johannes Henkel and Scott Haseley
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/56044.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Johannes Henkel
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Haseley (Gerrit)
6:02 PM (5 hours ago) 6:02 PM
to Blink W3C Test Autoroller, Michal Mocny, Johannes Henkel, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Attention needed from Johannes Henkel
Scott Haseley voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Johannes Henkel
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Henkel (Gerrit)
6:05 PM (5 hours ago) 6:05 PM
to Scott Haseley, Blink W3C Test Autoroller, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Attention needed from Scott Haseley
Johannes Henkel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Johannes Henkel
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:06 PM (5 hours ago) 6:06 PM
to Scott Haseley, Johannes Henkel, Blink W3C Test Autoroller, Michal Mocny, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[soft navs] Clean up SoftNavigationTestHelper.get*PerformanceEntries*
Drive-by cleanup of soft navs test helpers. The main thing is that the
include_soft_navigation_observations option was previously removed from
getPerformanceEntries, but was still being passed in some places, so
some tests were actually comparing minNumEntries to a bool.
Additionally, this changes minNumEntries to default to 1 to remove
some boilerplate, since we almost always use that. I think this is a
minor readability improvement.
Bug: None
Change-Id: I727d3c2e9c4b9d9d2b3c564eb69e7b798e693f59
Reviewed-by: Michal Mocny <mmo...@chromium.org>
Commit-Queue: Scott Haseley <shas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1545286}
Files:
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/detection/tentative/navigation-api-precommit-handler.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/detection/tentative/node-with-image-pseudo-element-and-text.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/detection/tentative/node-with-image-pseudo-element.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/detection/tentative/overwriting-text-once-per-interaction.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/detection/tentative/overwriting-text.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/detection/tentative/video-srcObject-change.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/interaction-with-paint-before-back.tentative.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/lcp/tentative/background-image-set-image.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/lcp/tentative/broken-image-icon.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/lcp/tentative/contracted-image.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/lcp/tentative/cross-origin-image.sub.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/lcp/tentative/element-only-when-fully-active.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/lcp/tentative/expanded-image.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/lcp/tentative/first-paint-equals-lcp-text.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/lcp/tentative/iframe-content-not-observed.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/lcp/tentative/raf-loop.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/resources/soft-navigation-test-helper.js
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/smoke/tentative/almost-soft-navigation.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/smoke/tentative/dom.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/smoke/tentative/image-src-change.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/smoke/tentative/late-url-change.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/smoke/tentative/lcp-unbuffered.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/smoke/tentative/lcp.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/smoke/tentative/task-attribution-link-load.html
- M third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/smoke/tentative/video-src-change.html
- M third_party/blink/web_tests/wpt_internal/soft-navigation-heuristics/browser-initiate-back-intercepted.html
- M third_party/blink/web_tests/wpt_internal/soft-navigation-heuristics/fcp-element-detached-after-rendering.html
Change size: L
Delta: 27 files changed, 94 insertions(+), 198 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Johannes Henkel, +1 by Michal Mocny
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
7:04 PM (4 hours ago) 7:04 PM
to Scott Haseley, Chromium LUCI CQ, Johannes Henkel, Michal Mocny, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/56044
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages