[spelling+grammar restrictions] Trial Balloon CL [chromium/src : main]
Ari Chivukula (Gerrit)
Ari Chivukula added 1 comment![]( "Open in Gerrit")
Element* AdjustedFocusedElementInTreeScope() const;Ari ChivukulaBlink Style Guide: Prefer enums or StrongAliases to bare bools for function parameters. Using a bare `bool` can make call sites like `IsFocusedElementInDocument(true)` ambiguous. Please consider using an enum class like `enum class UserGestureRequirement { kNotRequired, kRequired };` for clarity.
_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reasonThis comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent).AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve.[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Done
Related details
- Kent Tamura
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Kent Tamura added 1 comment![]( "Open in Gerrit")
What do you want me to do about this CL?
Related details
- Ari Chivukula
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaocheng Hu (Gerrit)
Xiaocheng Hu added 1 comment![]( "Open in Gerrit")
if (!input->IsFocusedElementInDocument(Maybe `RespondToChangedXXX` are better entry points?
Related details
- Ari Chivukula
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ari Chivukula (Gerrit)
Ari Chivukula added 2 comments![]( "Open in Gerrit")
What do you want me to do about this CL?
Sorry, I forgot to comment. I was looking to be referred to the correct person to review as I make progress. This code is so old I'm not sure who the best owner is.
if (!input->IsFocusedElementInDocument(Maybe `RespondToChangedXXX` are better entry points?
- Kent Tamura
- Xiaocheng Hu
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ari Chivukula (Gerrit)
Ari Chivukula added 1 comment![]( "Open in Gerrit")
if (!input->IsFocusedElementInDocument(Ari ChivukulaMaybe `RespondToChangedXXX` are better entry points?
good point, I'll do that adjustment
This new version is closer to what I need, but I think I need to re-evaluate my element::focus based approach, it seems like that doesn't actually account for user clicks in the way I anticipated
Related details
- Xiaocheng Hu
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ari Chivukula (Gerrit)
Ari Chivukula voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ari Chivukula
| Commit-Queue | +1 |
1 comment
if (!input->IsFocusedElementInDocument(Ari ChivukulaMaybe `RespondToChangedXXX` are better entry points?
Ari Chivukulagood point, I'll do that adjustment
This new version is closer to what I need, but I think I need to re-evaluate my element::focus based approach, it seems like that doesn't actually account for user clicks in the way I anticipated
okay this new version works as desired!
Related details
- Xiaocheng Hu
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Kent Tamura added 1 comment![]( "Open in Gerrit")
Ari ChivukulaWhat do you want me to do about this CL?
Sorry, I forgot to comment. I was looking to be referred to the correct person to review as I make progress. This code is so old I'm not sure who the best owner is.
I think xiaochengh@ is familiar with the spellchecker code, and Microsoft is responsible for core/editing/ now. Please refer to core/editing/OWNERS.
Related details
- Ari Chivukula
- Xiaocheng Hu
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Xiaocheng Hu (Gerrit)
Xiaocheng Hu added 1 comment![]( "Open in Gerrit")
Thanks for the update. This version makes much more sense to me.
Please also pay attention to the "cold" checking mode, which performs full checking when the editor is sufficiently idle. The way it works may conflict with the current design of this project.
For details please take a look at this design doc: https://goo.gl/zONC3v
(It's very old but miraculously not out of date)
Related details
- Ari Chivukula
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ari Chivukula (Gerrit)
Ari Chivukula added 1 comment![]( "Open in Gerrit")
Thanks for the update. This version makes much more sense to me.
Please also pay attention to the "cold" checking mode, which performs full checking when the editor is sufficiently idle. The way it works may conflict with the current design of this project.
For details please take a look at this design doc: https://goo.gl/zONC3v
(It's very old but miraculously not out of date)
That's a good point, my plan was to intercept in ColdModeSpellCheckRequester::CurrentFocusedEditable, does that sound good?
Related details
- Xiaocheng Hu
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ari Chivukula (Gerrit)
Ari Chivukula added 1 comment![]( "Open in Gerrit")
Ari ChivukulaThanks for the update. This version makes much more sense to me.
Please also pay attention to the "cold" checking mode, which performs full checking when the editor is sufficiently idle. The way it works may conflict with the current design of this project.
For details please take a look at this design doc: https://goo.gl/zONC3v
(It's very old but miraculously not out of date)
That's a good point, my plan was to intercept in ColdModeSpellCheckRequester::CurrentFocusedEditable, does that sound good?
Hmm, the more I dig into it the more I think we just need to temporarily disable the code mode checker when we see hot-mode invoked and then bypassed via any of these three feature params, and then re-enable it if/when a supported invocation occurs
Related details
- Xiaocheng Hu
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |