Reland "[Language Detector] Disable flaky WPT on Mac" [chromium/src : main]
0 views
Skip to first unread message
Christine Hollingsworth (Gerrit)
Jun 17, 2025, 5:11:47 PM6/17/25
to AyeAye, Nathan Memmott, Chromium LUCI CQ, Clark DuVall, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Nathan Memmott
Christine Hollingsworth added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Nathan Memmott . resolved
Christine HollingsworthDoes the normal TestExpectations need to be updated too?
Yes, this needs to be updated - just created the reland CL to start (and clicked 'don't notify reviewers' when creating, so this change is still WIP). Will manually mark CL WIP until fixed.
Related details
Attention is currently required from:
- Nathan Memmott
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christine Hollingsworth (Gerrit)
Jun 17, 2025, 6:25:29 PM6/17/25
to AyeAye, Nathan Memmott, Chromium LUCI CQ, Clark DuVall, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Nathan Memmott
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Nathan Memmott
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Christine Hollingsworth (Gerrit)
Jun 17, 2025, 6:25:59 PM6/17/25
to AyeAye, Nathan Memmott, Chromium LUCI CQ, Clark DuVall, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Nathan Memmott
Christine Hollingsworth voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Nathan Memmott
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 17, 2025, 6:31:32 PM6/17/25
to Christine Hollingsworth, AyeAye, Nathan Memmott, Clark DuVall, chromium...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/web_tests/AIExpectations
Insertions: 3, Deletions: 2.
@@ -6,5 +6,6 @@
# TestExpectations file is ignored and this file is referred.
# Temporarily disable flaky Language Detector tests to unblock model validation testing.
-crbug.com/414403946 [ Mac ] external/wpt/ai/language_detection/detector-iframe.https.html [ Skip ]
-crbug.com/414403946 [ Mac ] external/wpt/ai/language_detection/detector-locale.https.window.html [ Skip ]
+# Disables tests on all platforms, since disabling these tests on Mac only is not supported.
+crbug.com/414403946 external/wpt/ai/language_detection/detector-iframe.https.html [ Skip ]
+crbug.com/414403946 external/wpt/ai/language_detection/detector-locale.https.window.html [ Skip ]
```
Change information
Commit message:
Reland "[Language Detector] Disable flaky WPT on Mac"
This is a reland of commit b8cbcd9c0ab080b45fbd393805e830c61802aa27
Fixes formatting issues on original change.
Original change's description:
> [Language Detector] Disable flaky WPT on Mac
>
> Temporarily disables WPT that are flaky on Mac.
>
> Model validation requests rely on these tests being green,
> and disabling these tests helps unblock that work, since the
> cause of the flake is suspected to be unrelated to Language
> Detector-specific implementation.
>
> Bug: 414403946
> Change-Id: I8f5b9a51250e21e7a5095df517992c9e54295d3a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6630563
> Reviewed-by: Nathan Memmott <mem...@chromium.org>
> Commit-Queue: Christine Hollingsworth <chris...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1471445}
Bug: 414403946
Change-Id: Ic6e8cacd85645212b819c92f3288cd785943e967
Commit-Queue: Christine Hollingsworth <chris...@chromium.org>
Reviewed-by: Nathan Memmott <mem...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1475269}
Files:
- M third_party/blink/web_tests/AIExpectations
Change size: XS
Delta: 1 file changed, 5 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nathan Memmott
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages