Changhao Han (Gerrit)

unread,

Jul 2, 2024, 6:00:32 PM (12 hours ago) Jul 2

to AyeAye, Rune Lillesveen, Alex Rudenko, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, blink-revi...@chromium.org

Attention needed from Alex Rudenko and Rune Lillesveen

Changhao Han voted and added 1 comment

Votes added by Changhao Han

Code-Review

-1

1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Changhao Han . resolved

Will test this first.

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

blocking_requirement

open

diffy

Changhao Han (Gerrit)

unread,

Jul 2, 2024, 6:17:12 PM (12 hours ago) Jul 2

to AyeAye, Rune Lillesveen, Alex Rudenko, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, twelling...@chromium.org, blundell+...@chromium.org, gangwu...@chromium.org, donnd...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, blink-revi...@chromium.org

Attention needed from Alex Rudenko and Rune Lillesveen

Changhao Han voted and added 1 comment

Votes added by Changhao Han

Auto-Submit	+1
Code-Review	+0
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Changhao Han . resolved

I will try to reland without the flaky test part first, and will use a separate CL to test if forcing a style recalc might resolve the flakiness.

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alex Rudenko (Gerrit)

unread,

3:11 AM (3 hours ago) 3:11 AM

to Changhao Han, AyeAye, Rune Lillesveen, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, twelling...@chromium.org, blundell+...@chromium.org, gangwu...@chromium.org, donnd...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, blink-revi...@chromium.org

Attention needed from Changhao Han and Rune Lillesveen

Alex Rudenko added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Alex Rudenko . resolved

it seems to contain some unrelated changes

Open in Gerrit

Related details

Attention is currently required from:

Changhao Han
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Changhao Han (Gerrit)

unread,

4:35 AM (2 hours ago) 4:35 AM

to AyeAye, Rune Lillesveen, Alex Rudenko, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, twelling...@chromium.org, blundell+...@chromium.org, gangwu...@chromium.org, donnd...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, blink-revi...@chromium.org

Attention needed from Alex Rudenko and Rune Lillesveen

Changhao Han added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Alex Rudenko . resolved

it seems to contain some unrelated changes

Changhao Han

Oh my.. how did that happen? I just clicked "Reland" and removed several lines of JS in that test. Anyways let me properly rebase this and remove extra unnecessary code.

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

4:42 AM (2 hours ago) 4:42 AM

to Changhao Han, AyeAye, Rune Lillesveen, Alex Rudenko, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, twelling...@chromium.org, blundell+...@chromium.org, gangwu...@chromium.org, donnd...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, blink-revi...@chromium.org

Attention needed from Alex Rudenko

Rune Lillesveen added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Alex Rudenko . resolved

it seems to contain some unrelated changes

Rune Lillesveen

Weird, the java file changes do not show up in the PS1 or PS1->PS2 diffs.

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Changhao Han (Gerrit)

unread,

4:47 AM (2 hours ago) 4:47 AM

to AyeAye, Rune Lillesveen, Alex Rudenko, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, twelling...@chromium.org, blundell+...@chromium.org, gangwu...@chromium.org, donnd...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, blink-revi...@chromium.org

Attention needed from Alex Rudenko and Rune Lillesveen

Changhao Han voted and added 1 comment

Votes added by Changhao Han

Auto-Submit	+1
Commit-Queue	+1

1 comment

Patchset-level comments

File-level comment, Patchset 2:

Alex Rudenko . resolved

it seems to contain some unrelated changes

Rune Lillesveen

Weird, the java file changes do not show up in the PS1 or PS1->PS2 diffs.

Changhao Han

Anyways, rebasing seems to resolve this. PTAL again, thanks!

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rune Lillesveen (Gerrit)

unread,

4:50 AM (2 hours ago) 4:50 AM

to Changhao Han, Rune Lillesveen, AyeAye, Alex Rudenko, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, twelling...@chromium.org, blundell+...@chromium.org, gangwu...@chromium.org, donnd...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, blink-revi...@chromium.org

Attention needed from Alex Rudenko and Changhao Han

Rune Lillesveen voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Alex Rudenko
Changhao Han

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Alex Rudenko (Gerrit)

unread,

5:52 AM (1 hour ago) 5:52 AM

to Changhao Han, Rune Lillesveen, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, twelling...@chromium.org, blundell+...@chromium.org, gangwu...@chromium.org, donnd...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, blink-revi...@chromium.org

Attention needed from Changhao Han and Rune Lillesveen

Alex Rudenko voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Changhao Han
Rune Lillesveen

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

5:56 AM (27 minutes ago) 5:56 AM

to Changhao Han, Alex Rudenko, Rune Lillesveen, AyeAye, Alexis Menard, chromium...@chromium.org, devtools...@chromium.org, twelling...@chromium.org, blundell+...@chromium.org, gangwu...@chromium.org, donnd...@chromium.org, devtools-re...@chromium.org, blink-...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, zol...@webkit.org, blink-revi...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Reland "[inspector] Add active position try rule index and pass it to inspector"

This is a reland of commit 5e84130e78ca65c940ad57d2fbc3a02dfd06f701

Original change's description:
> [inspector] Add active position try rule index and pass it to inspector
>
> This CL adds the following things:
> - the successful (active) position try rule index to
>   SuccessfulPositionOption;
> - an API in OutOfFlowData to return the active position try rule index
>   added above;
> - necessary bits in the inspector to mark which position try rule is
>   active.
>
> Bug: 40246493
> Change-Id: Ib8857d83ef573dd64b8da71bb0363fd0429080bc
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5643490
> Reviewed-by: Alex Rudenko <alexr...@chromium.org>
> Commit-Queue: Changhao Han <chang...@chromium.org>
> Reviewed-by: Rune Lillesveen <fut...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1322147}

Bug: 40246493

Change-Id: I987a5d3f1ba4f87dd0f7ccf2fc1d6c96d80d3f1d

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5672498

Auto-Submit: Changhao Han <chang...@chromium.org>

Commit-Queue: Alex Rudenko <alexr...@chromium.org>

Reviewed-by: Rune Lillesveen <fut...@chromium.org>

Reviewed-by: Alex Rudenko <alexr...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1322676}

Files:

M third_party/blink/public/devtools_protocol/browser_protocol.pdl
M third_party/blink/renderer/core/css/out_of_flow_data.cc
M third_party/blink/renderer/core/css/out_of_flow_data.h
M third_party/blink/renderer/core/css/successful_position_option.cc
M third_party/blink/renderer/core/css/successful_position_option.h
M third_party/blink/renderer/core/inspector/inspector_css_agent.cc
M third_party/blink/renderer/core/inspector/inspector_style_sheet.cc
M third_party/blink/renderer/core/inspector/inspector_style_sheet.h
M third_party/blink/renderer/core/layout/out_of_flow_layout_part.cc
M third_party/blink/web_tests/inspector-protocol/css/css-get-position-try-expected.txt
M third_party/blink/web_tests/inspector-protocol/css/css-get-position-try.js
M third_party/blink/web_tests/inspector-protocol/resources/css-helper.js

Change size: M

Delta: 12 files changed, 112 insertions(+), 23 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Alex Rudenko, +1 by Rune Lillesveen

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Reland "[inspector] Add active position try rule index and pass it to inspector" [chromium/src : main]

Changhao Han (Gerrit)

Changhao Han voted and added 1 comment

Votes added by Changhao Han

1 comment

Related details

Changhao Han (Gerrit)

Changhao Han voted and added 1 comment

Votes added by Changhao Han

1 comment

Related details

Alex Rudenko (Gerrit)

Alex Rudenko added 1 comment

Related details

Changhao Han (Gerrit)

Changhao Han added 1 comment

Related details

Rune Lillesveen (Gerrit)

Rune Lillesveen added 1 comment

Related details

Changhao Han (Gerrit)

Changhao Han voted and added 1 comment

Votes added by Changhao Han

1 comment

Related details

Rune Lillesveen (Gerrit)

Rune Lillesveen voted

Related details

Alex Rudenko (Gerrit)

Alex Rudenko voted

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Change information