Remove -expected.txt for some tests under css/css-shape/shape-outside-values [chromium/src : main]

0 views
Skip to first unread message

Xianzhu Wang (Gerrit)

unread,
Jun 27, 2022, 5:42:42 PM6/27/22
to Weizhong Xia, blink-...@chromium.org

Attention is currently required from: Weizhong Xia.

Xianzhu Wang would like Weizhong Xia to review this change.

View Change

Remove -expected.txt for some tests under css/css-shape/shape-outside-values

They are removed in favor of the TestExpectations entries added in
crrev.com/1018349 to better track the bug.

Bug: 1339525
Change-Id: I4fa921012fd78f4c1d15875548de26d8bea57ade
---
D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-margin-001-expected.txt
D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-outside-circle-004-expected.txt
D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-outside-circle-005-expected.txt
D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-outside-ellipse-004-expected.txt
D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-outside-ellipse-005-expected.txt
D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-outside-inset-003-expected.txt
D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-outside-polygon-004-expected.txt
D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-outside-shape-arguments-000-expected.txt
D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-margin-001-expected.txt
D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-outside-circle-004-expected.txt
D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-outside-circle-005-expected.txt
D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-outside-ellipse-004-expected.txt
D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-outside-ellipse-005-expected.txt
D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-outside-inset-003-expected.txt
D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-outside-polygon-004-expected.txt
D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-outside-shape-arguments-000-expected.txt
16 files changed, 13 insertions(+), 5,457 deletions(-)


To view, visit change 3730328. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4fa921012fd78f4c1d15875548de26d8bea57ade
Gerrit-Change-Number: 3730328
Gerrit-PatchSet: 1
Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
Gerrit-Reviewer: Weizhong Xia <weiz...@google.com>
Gerrit-Attention: Weizhong Xia <weiz...@google.com>
Gerrit-MessageType: newchange

Xianzhu Wang (Gerrit)

unread,
Jun 27, 2022, 5:42:48 PM6/27/22
to blink-...@chromium.org, Weizhong Xia, chromium...@chromium.org

Attention is currently required from: Weizhong Xia.

View Change

    To view, visit change 3730328. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4fa921012fd78f4c1d15875548de26d8bea57ade
    Gerrit-Change-Number: 3730328
    Gerrit-PatchSet: 1
    Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
    Gerrit-Reviewer: Weizhong Xia <weiz...@google.com>
    Gerrit-Attention: Weizhong Xia <weiz...@google.com>
    Gerrit-Comment-Date: Mon, 27 Jun 2022 21:42:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Weizhong Xia (Gerrit)

    unread,
    Jun 27, 2022, 11:15:15 PM6/27/22
    to Xianzhu Wang, blink-...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org

    Attention is currently required from: Xianzhu Wang.

    Patch set 1:Code-Review +1

    View Change

      To view, visit change 3730328. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4fa921012fd78f4c1d15875548de26d8bea57ade
      Gerrit-Change-Number: 3730328
      Gerrit-PatchSet: 1
      Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
      Gerrit-Reviewer: Weizhong Xia <weiz...@google.com>
      Gerrit-Reviewer: Xianzhu Wang <wangx...@chromium.org>
      Gerrit-Attention: Xianzhu Wang <wangx...@chromium.org>
      Gerrit-Comment-Date: Tue, 28 Jun 2022 03:15:07 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Xianzhu Wang (Gerrit)

      unread,
      Jun 28, 2022, 1:06:43 AM6/28/22
      to blink-...@chromium.org, Weizhong Xia, Chromium LUCI CQ, chromium...@chromium.org

      Attention is currently required from: Xianzhu Wang.

      Patch set 1:Commit-Queue +2

      View Change

        To view, visit change 3730328. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I4fa921012fd78f4c1d15875548de26d8bea57ade
        Gerrit-Change-Number: 3730328
        Gerrit-PatchSet: 1
        Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org>
        Gerrit-Reviewer: Weizhong Xia <weiz...@google.com>
        Gerrit-Reviewer: Xianzhu Wang <wangx...@chromium.org>
        Gerrit-Attention: Xianzhu Wang <wangx...@chromium.org>
        Gerrit-Comment-Date: Tue, 28 Jun 2022 05:06:33 +0000

        Chromium LUCI CQ (Gerrit)

        unread,
        Jun 28, 2022, 1:13:52 AM6/28/22
        to Xianzhu Wang, blink-...@chromium.org, Weizhong Xia, chromium...@chromium.org

        Chromium LUCI CQ submitted this change.

        View Change


        Approvals: Xianzhu Wang: Commit Weizhong Xia: Looks good to me 
        Remove -expected.txt for some tests under css/css-shape/shape-outside-values

        They are removed in favor of the TestExpectations entries added in
        crrev.com/1018349 to better track the bug.

        Bug: 1339525
        Change-Id: I4fa921012fd78f4c1d15875548de26d8bea57ade
        Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3730328
        Reviewed-by: Weizhong Xia <weiz...@google.com>
        Commit-Queue: Xianzhu Wang <wangx...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1018541}

        ---
        D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-margin-001-expected.txt
        D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-outside-circle-004-expected.txt
        D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-outside-circle-005-expected.txt
        D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-outside-ellipse-004-expected.txt
        D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-outside-ellipse-005-expected.txt
        D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-outside-inset-003-expected.txt
        D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-outside-polygon-004-expected.txt
        D third_party/blink/web_tests/platform/linux/external/wpt/css/css-shapes/shape-outside/values/shape-outside-shape-arguments-000-expected.txt
        D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-margin-001-expected.txt
        D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-outside-circle-004-expected.txt
        D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-outside-circle-005-expected.txt
        D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-outside-ellipse-004-expected.txt
        D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-outside-ellipse-005-expected.txt
        D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-outside-inset-003-expected.txt
        D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-outside-polygon-004-expected.txt
        D third_party/blink/web_tests/platform/win/external/wpt/css/css-shapes/shape-outside/values/shape-outside-shape-arguments-000-expected.txt
        16 files changed, 17 insertions(+), 5,457 deletions(-)

        


        To view, visit change 3730328. To unsubscribe, or for help writing mail filters, visit settings.
        


         Gerrit-Project: chromium/src 
        

         Gerrit-Branch: main 
        

         Gerrit-Change-Id: I4fa921012fd78f4c1d15875548de26d8bea57ade 
        

         Gerrit-Change-Number: 3730328 
        

         Gerrit-PatchSet: 2 
        

         Gerrit-Owner: Xianzhu Wang <wangx...@chromium.org> 
        

         Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com> 
        

         Gerrit-Reviewer: Weizhong Xia <weiz...@google.com> 
        

         Gerrit-Reviewer: Xianzhu Wang <wangx...@chromium.org> 
        

        

         Gerrit-MessageType: merged 
        


        Reply all
        Reply to author
        Forward
        0 new messages