Implement SupportsUserDataHolder for composition. [chromium/src : main]

0 views

Skip to first unread message

Daniel Cheng (Gerrit)

unread,

1:02 AM (5 hours ago) 1:02 AM

to Daniel Cheng, David Benjamin, danakj, Enterprise Policy Reviews, Kevin McNee, James Maclean, Chromium LUCI CQ, chromium...@chromium.org, dullweb...@chromium.org, ffred...@chromium.org, msrame...@chromium.org, tluk+...@chromium.org, alexmo...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, navigation...@chromium.org, rhalava...@chromium.org, steimel+...@chromium.org, andysjl...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blundell+...@chromium.org, croissant-...@chromium.org, druber...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

Attention needed from David Benjamin and danakj

Daniel Cheng added 1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Daniel Cheng . resolved

WDYT? Terrible idea? Really terrible idea?

I originally implemented this because I wanted to use this for WebContents. However, it turned out to be Hard™, though I kind of feel like this is really the right thing to do.

The tricky part, of course, is there actually *are* things that depend on being generic SupportsUserData::Data and allowing themselves to be attached to, say, BrowserContext or WebContents.

Open in Gerrit

Related details

Attention is currently required from:

David Benjamin
danakj

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages