[M148] [Autofill] Do not dismiss KA if suggestion is loading. [chromium/src : refs/branch-heads/7778]
0 views
Skip to first unread message
Chrome Cherry Picker (Gerrit)
4:31 AM (5 hours ago) 4:31 AM
to Luchen Peng, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, browser-comp...@chromium.org
Chrome Cherry Picker voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rubber Stamper (Gerrit)
4:32 AM (5 hours ago) 4:32 AM
to Chrome Cherry Picker, Luchen Peng, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, browser-comp...@chromium.org
Rubber Stamper voted![]( "Open in Gerrit")
| Bot-Commit | +1 |
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
7:43 AM (2 hours ago) 7:43 AM
to Chrome Cherry Picker, Luchen Peng, Rubber Stamper, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, browser-comp...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[M148] [Autofill] Do not dismiss KA if suggestion is loading.
Original change's description:
> [Autofill] Do not dismiss KA if suggestion is loading.
>
> This changes includes:
> 1. Behavior change on the KA from always immediately dismiss to waiting for server fetch and then dismiss.
> 2. Adding UpdateStyleAndLayout in input_method_controller to prevent crashes when the user tries to edit text while a suggestion is being fetched
>
> Known behavior caveats for this change:
> 1. When the user tries to edit a field after accepting a suggestion, KA will disappear after first edit and the field will be overwritten when the suggestion value is filled
> 2. If the user selected a suggestion that requires server fetching, and then click into another field, when the previous suggestion is filled, it would clear the suggestion for the current focus field
>
> Screencast: http://shortn/_2sAjv5Q7yw
>
> Bug: 476755855
> Change-Id: I3548e655779eb9fc9817198cca95800b11cd1668
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7717845
> Reviewed-by: Friedrich Hauser <fried...@chromium.org>
> Reviewed-by: Joey Arhar <jar...@chromium.org>
> Reviewed-by: Bruno Braga <bruno...@google.com>
> Commit-Queue: Luchen Peng <luche...@google.com>
> Cr-Commit-Position: refs/heads/main@{#1611723}
(cherry picked from commit c77c9dcbb658d175ed15e7a4dd25a4c562262eea)
Bug: 502074706,476755855
Change-Id: I3548e655779eb9fc9817198cca95800b11cd1668
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Commit-Queue: Luchen Peng <luche...@google.com>
Auto-Submit: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/7778@{#443}
Cr-Branched-From: 77f495ee216d4c3cc784d33658bad4778c0680ee-refs/heads/main@{#1610480}
Files:
- M chrome/android/features/keyboard_accessory/internal/java/src/org/chromium/chrome/browser/keyboard_accessory/AutofillKeyboardAccessoryViewBridge.java
- M chrome/android/features/keyboard_accessory/internal/java/src/org/chromium/chrome/browser/keyboard_accessory/ManualFillingCoordinator.java
- M chrome/android/features/keyboard_accessory/internal/java/src/org/chromium/chrome/browser/keyboard_accessory/ManualFillingMediator.java
- M chrome/android/features/keyboard_accessory/junit/src/org/chromium/chrome/browser/keyboard_accessory/ManualFillingControllerTest.java
- M chrome/android/features/keyboard_accessory/junit/src/org/chromium/chrome/browser/keyboard_accessory/bar_component/KeyboardAccessoryControllerTest.java
- M chrome/browser/keyboard_accessory/android/internal/java/src/org/chromium/chrome/browser/keyboard_accessory/bar_component/KeyboardAccessoryMediator.java
- M chrome/browser/keyboard_accessory/android/java/src/org/chromium/chrome/browser/keyboard_accessory/ManualFillingComponent.java
- M chrome/browser/ui/autofill/autofill_keyboard_accessory_controller_impl.cc
- M chrome/browser/ui/autofill/autofill_keyboard_accessory_controller_impl_unittest.cc
- M components/autofill/android/java/src/org/chromium/components/autofill/AutofillDelegate.java
- M third_party/blink/renderer/core/editing/ime/input_method_controller.cc
Change size: M
Delta: 11 files changed, 213 insertions(+), 10 deletions(-)
Branch: refs/branch-heads/7778
Submit Requirements:
Code-Review: Bot-Commit+1 by Rubber Stamper
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages