[network] Rename AllowCSPFromHeaderValue to OriginOrWildcardHeaderValue [chromium/src : main]
1 view
Skip to first unread message
Brandon Maslen (Gerrit)
Jun 11, 2026, 6:08:48 PMJun 11
to Giovanni Del Valle, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mkwst+w...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Giovanni Del Valle
Brandon Maslen added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Brandon Maslen . resolved
Thanks for making this refactor in a separate PR to get ready for other changes that will consume this type.
File third_party/blink/renderer/platform/network/http_parsers.cc
Line 248, Patchset 3 (Latest):
blink::OriginOrWildcardHeaderValuePtr ConvertToBlink(
const OriginOrWildcardHeaderValuePtr& allow_csp_from) {
if (!allow_csp_from)
return nullptr;Brandon Maslen . unresolved
Given this helper is now a general helper would it make sense to rename the var from allow_csp_from to allow_from, header_value, or something similar?
Related details
Attention is currently required from:
- Giovanni Del Valle
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Del Valle (Gerrit)
Jun 11, 2026, 6:31:32 PMJun 11
to Brandon Maslen, Chromium LUCI CQ, chromium...@chromium.org, alexmo...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mkwst+w...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Brandon Maslen
Giovanni Del Valle added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/platform/network/http_parsers.cc
Line 248, Patchset 3:
blink::OriginOrWildcardHeaderValuePtr ConvertToBlink(
const OriginOrWildcardHeaderValuePtr& allow_csp_from) {
if (!allow_csp_from)
return nullptr;Brandon Maslen . resolved
Given this helper is now a general helper would it make sense to rename the var from allow_csp_from to allow_from, header_value, or something similar?
Giovanni Del Valle
Yes, I think this makes sense. I've renamed the var accordingly.
Related details
Attention is currently required from:
- Brandon Maslen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike West (Gerrit)
Jun 12, 2026, 3:05:19 AMJun 12
to Giovanni Del Valle, Kenichi Ishibashi, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Brandon Maslen, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, alexmo...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mkwst+w...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Arthur Sonzogni, Giovanni Del Valle and Kenichi Ishibashi
Mike West added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 7 (Latest):
Mike West . resolved
This looks pretty reasonable to me % the nit. Thanks!
Perhaps bashi@ could take a look at //services/network generally, and arthursonzogni@ could stamp //content/browser?
File third_party/blink/renderer/core/frame/integrity_policy_test.cc
Line 18, Patchset 7 (Latest):
#include "third_party/blink/renderer/platform/weborigin/security_origin.h"Mike West . unresolved
Nit: This might be helpful, but it's irrelevant to the change you're making in this CL. Please remove it to keep the CL focused on one change at a time.
Related details
Attention is currently required from:
- Arthur Sonzogni
- Giovanni Del Valle
- Kenichi Ishibashi
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike West (Gerrit)
Jun 12, 2026, 3:05:40 AMJun 12
to Giovanni Del Valle, Kenichi Ishibashi, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Brandon Maslen, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, alexmo...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mkwst+w...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Arthur Sonzogni, Giovanni Del Valle and Kenichi Ishibashi
Mike West added 1 comment![]( "Open in Gerrit")
Commit Message
Arthur Sonzogni (Gerrit)
Jun 12, 2026, 10:04:51 AMJun 12
to Giovanni Del Valle, Kenichi Ishibashi, android-bu...@system.gserviceaccount.com, Mike West, Brandon Maslen, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, alexmo...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mkwst+w...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Giovanni Del Valle and Kenichi Ishibashi
Arthur Sonzogni voted and added 1 comment![]( "Open in Gerrit")
Votes added by Arthur Sonzogni
| Code-Review | +1 |
1 comment
Patchset-level comments
Arthur Sonzogni . resolved
LGTM % the comments Mike already added. Thanks!
Related details
Attention is currently required from:
Giovanni Del Valle (Gerrit)
Jun 12, 2026, 4:45:44 PMJun 12
to Arthur Sonzogni, Kenichi Ishibashi, android-bu...@system.gserviceaccount.com, Mike West, Brandon Maslen, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, alexmo...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mkwst+w...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Kenichi Ishibashi and Mike West
Giovanni Del Valle added 1 comment![]( "Open in Gerrit")
Commit Message
Please tie this to a bug before landing.
Attention is currently required from:
- Kenichi Ishibashi
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Del Valle (Gerrit)
Jun 12, 2026, 4:54:17 PMJun 12
to Arthur Sonzogni, Kenichi Ishibashi, android-bu...@system.gserviceaccount.com, Mike West, Brandon Maslen, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, alexmo...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mkwst+w...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Kenichi Ishibashi and Mike West
Giovanni Del Valle added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/frame/integrity_policy_test.cc
Line 18, Patchset 7:
#include "third_party/blink/renderer/platform/weborigin/security_origin.h"Mike West . unresolved
Nit: This might be helpful, but it's irrelevant to the change you're making in this CL. Please remove it to keep the CL focused on one change at a time.
Giovanni Del Valle
So, this include was added to fix a build break specifically for Android. Moving OriginOrWildcardHeaderValue out of content_security_policy.mojom means its -blink.h no longer references url.mojom.Origin (which typemaps to blink::SecurityOrigin), so it stops transitively pulling in security_origin.h.
integrity_policy_test.cc was relying on that transitive include, so it fails to compile after the move. The Android trybot flags it as incomplete type 'blink::SecurityOrigin'
Brandon Maslen (Gerrit)
Jun 12, 2026, 5:05:31 PMJun 12
to Giovanni Del Valle, Arthur Sonzogni, Kenichi Ishibashi, android-bu...@system.gserviceaccount.com, Mike West, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, alexmo...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mkwst+w...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Giovanni Del Valle, Kenichi Ishibashi and Mike West
Brandon Maslen voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Giovanni Del Valle
- Kenichi Ishibashi
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Del Valle (Gerrit)
Jun 12, 2026, 6:33:11 PMJun 12
to Brandon Maslen, Arthur Sonzogni, Kenichi Ishibashi, android-bu...@system.gserviceaccount.com, Mike West, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, alexmo...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mkwst+w...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Kenichi Ishibashi and Mike West
Giovanni Del Valle added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/frame/integrity_policy_test.cc
Line 18, Patchset 7:
#include "third_party/blink/renderer/platform/weborigin/security_origin.h"Mike West . resolved
Giovanni Del ValleNit: This might be helpful, but it's irrelevant to the change you're making in this CL. Please remove it to keep the CL focused on one change at a time.
So, this include was added to fix a build break specifically for Android. Moving OriginOrWildcardHeaderValue out of content_security_policy.mojom means its -blink.h no longer references url.mojom.Origin (which typemaps to blink::SecurityOrigin), so it stops transitively pulling in security_origin.h.
integrity_policy_test.cc was relying on that transitive include, so it fails to compile after the move. The Android trybot flags it as incomplete type 'blink::SecurityOrigin'
Attention is currently required from:
- Kenichi Ishibashi
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kenichi Ishibashi (Gerrit)
Jun 14, 2026, 7:31:01 PMJun 14
to Giovanni Del Valle, Brandon Maslen, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Mike West, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, alexmo...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mkwst+w...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Giovanni Del Valle and Mike West
Kenichi Ishibashi voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Giovanni Del Valle
- Mike West
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mike West (Gerrit)
Jun 15, 2026, 5:56:09 AMJun 15
to Giovanni Del Valle, Kenichi Ishibashi, Brandon Maslen, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, alexmo...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mkwst+w...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Attention needed from Giovanni Del Valle
Mike West voted and added 1 comment![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Giovanni Del Valle
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Giovanni Del Valle (Gerrit)
Jun 15, 2026, 12:56:56 PMJun 15
to Mike West, Kenichi Ishibashi, Brandon Maslen, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, alexmo...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mkwst+w...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Giovanni Del Valle voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 15, 2026, 2:32:47 PMJun 15
to Giovanni Del Valle, Mike West, Kenichi Ishibashi, Brandon Maslen, Arthur Sonzogni, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-revi...@chromium.org, alexmo...@chromium.org, antoniosarto...@chromium.org, arthursonzog...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mkwst+w...@chromium.org, navigation...@chromium.org, network-ser...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[network] Rename AllowCSPFromHeaderValue to OriginOrWildcardHeaderValue
This is one in a series of CLs:
1. https://crrev.com/c/7926080 - [You are here.]
2. https://crrev.com/c/7925634 - Add Connection-Allowlist embedded enforcement primitives
3. https://crrev.com/c/7925636 - Add connectionallowlist iframe attribute + IPC transport
4. https://crrev.com/c/7933938 - Enforce Connection-Allowlist embedded enforcement handshake
`AllowCSPFromHeaderValue` is a mojom union representing the parsed value
of an HTTP response header whose grammar is either the token `*` or a
single serialized origin. Despite the `CSP` in its name, and its home in
content_security_policy.mojom, the type itself is not CSP-specific.
Rename it to the header-agnostic `OriginOrWildcardHeaderValue` and move
it into its own `origin_or_wildcard_header_value.mojom` file (and GN
target) so it can be reused by other `Allow-...-From`-style opt-in
headers (e.g. an upcoming Connection-Allowlist embedded-enforcement
header) without implying a tie to CSP or forcing a dependency on the CSP
mojom.
This is a pure rename + move of the type and its generated `*Ptr`,
`::Tag`, and `::New*` symbols. The `allow_csp_from` field, the
`ParseAllowCSPFromHeader` function, and the `Allow-CSP-From` header
string are intentionally left unchanged, as they remain CSP-specific.
Bug: 522111613
Change-Id: I98e046649ed5b6c3ea66ab427d139a15f5749a32
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Commit-Queue: Giovanni Del Valle <gdel...@microsoft.com>
Reviewed-by: Arthur Sonzogni <arthurs...@chromium.org>
Reviewed-by: Brandon Maslen <bra...@microsoft.com>
Reviewed-by: Mike West <mk...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1646963}
Files:
- M content/browser/renderer_host/navigation_request.cc
- M services/network/public/cpp/BUILD.gn
- M services/network/public/cpp/content_security_policy/content_security_policy.cc
- M services/network/public/cpp/content_security_policy/content_security_policy.h
- M services/network/public/mojom/BUILD.gn
- M services/network/public/mojom/content_security_policy.mojom
- A services/network/public/mojom/origin_or_wildcard_header_value.mojom
- M services/network/public/mojom/parsed_headers.mojom
- M third_party/blink/renderer/core/frame/integrity_policy_test.cc
- M third_party/blink/renderer/platform/network/http_parsers.cc
Change size: M
Delta: 10 files changed, 65 insertions(+), 35 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Kenichi Ishibashi, +1 by Arthur Sonzogni, +1 by Brandon Maslen, +1 by Mike West
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages