[blink][tracing] Expose V8 script id to more trace events [chromium/src : main]
0 views
Skip to first unread message
Camillo Bruni (Gerrit)
Jan 27, 2026, 9:04:23 AMJan 27
to Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org
Attention needed from Andrey Kosyakov
Camillo Bruni voted and added 1 comment![]( "Open in Gerrit")
Votes added by Camillo Bruni
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrey Kosyakov (Gerrit)
Jan 27, 2026, 7:21:07 PMJan 27
to Camillo Bruni, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org
Attention needed from Camillo Bruni
Andrey Kosyakov added 4 comments![]( "Open in Gerrit")
Patchset-level comments
Andrey Kosyakov . resolved
Can we please get some test coverage for this? These are generally covered by tests under inspector-protocol/tracing. There's some prior art here: third_party/blink/web_tests/http/tests/inspector-protocol/tracing/cpu-profiling.js
File third_party/blink/renderer/bindings/core/v8/v8_script_runner.cc
Line 354, Patchset 4 (Latest):
inspector_compile_script_event::ScriptId(script),Andrey Kosyakov . unresolved
nit: pass `script` as is and encapsulate id extraction logic in `Data()`?
Line 467, Patchset 4 (Latest):
inspector_compile_script_event::ScriptId(script),Andrey Kosyakov . unresolved
ditto
File third_party/blink/renderer/core/inspector/inspector_trace_events.h
Line 442, Patchset 4 (Latest):
int script_id,Andrey Kosyakov . unresolved
Not sure I understand why are you adding one here. There's a single call site and it passes `kNoScriptId`. Remove?
Related details
Attention is currently required from:
- Camillo Bruni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
9:23 AM (5 hours ago) 9:23 AM
to Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org
Attention needed from Andrey Kosyakov
Camillo Bruni added 3 comments![]( "Open in Gerrit")
File third_party/blink/renderer/bindings/core/v8/v8_script_runner.cc
nit: pass `script` as is and encapsulate id extraction logic in `Data()`?
Camillo Bruni
Done
Line 467, Patchset 4:
inspector_compile_script_event::ScriptId(script),Andrey Kosyakov . resolved
Camillo Bruniditto
Done
File third_party/blink/renderer/core/inspector/inspector_trace_events.h
Not sure I understand why are you adding one here. There's a single call site and it passes `kNoScriptId`. Remove?
Attention is currently required from:
- Andrey Kosyakov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Camillo Bruni (Gerrit)
11:02 AM (3 hours ago) 11:02 AM
to Andrey Kosyakov, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org
Attention needed from Andrey Kosyakov
Camillo Bruni added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Andrey Kosyakov (Gerrit)
12:49 PM (1 hour ago) 12:49 PM
to Camillo Bruni, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, dom+...@chromium.org, hiroshig...@chromium.org, kouhei...@chromium.org
Attention needed from Camillo Bruni
Andrey Kosyakov voted and added 2 comments![]( "Open in Gerrit")
Votes added by Andrey Kosyakov
| Code-Review | +1 |
2 comments
Patchset-level comments
Andrey Kosyakov . resolved
lgtm
File third_party/blink/renderer/bindings/core/v8/v8_code_cache.cc
Line 689, Patchset 5 (Latest):
inspector_compile_script_event::ScriptId(maybe_unbound_script),Andrey Kosyakov . unresolved
just `maybe_unound_script` now?
Related details
Attention is currently required from:
- Camillo Bruni
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages