[CE]: Add legacy runtime flag for UserMediaElement [chromium/src : main]

0 views
Skip to first unread message

Joey Arhar (Gerrit)

unread,
Jun 9, 2026, 3:56:26 PMJun 9
to Thomas Nguyen, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, srirama chandra sekhar, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jmedle...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Thomas Nguyen

Joey Arhar voted and added 2 comments

Votes added by Joey Arhar

Code-Review+1

2 comments

File third_party/blink/renderer/platform/runtime_enabled_features.json5
Line 6426, Patchset 3 (Latest): name: "UserMediaElementLegacy",
Joey Arhar . unresolved

Want to add a comment explaining what this flag does?

Line 6428, Patchset 3 (Latest): origin_trial_feature_name: "UserMediaElement",
Joey Arhar . unresolved

origin trial names are usually the same as the main flag name, right? want to add a comment explaining why this is not just "UserMediaElementLegacy"?

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Nguyen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6b113f4e08e95e110cbc265ec1844b52cdfae2c7
Gerrit-Change-Number: 7913025
Gerrit-PatchSet: 3
Gerrit-Owner: Thomas Nguyen <tun...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Jun 2026 19:56:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Nguyen (Gerrit)

unread,
Jun 10, 2026, 6:00:42 AMJun 10
to Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, srirama chandra sekhar, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jmedle...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Thomas Nguyen added 2 comments

File third_party/blink/renderer/platform/runtime_enabled_features.json5
Line 6426, Patchset 3: name: "UserMediaElementLegacy",
Joey Arhar . resolved

Want to add a comment explaining what this flag does?

Thomas Nguyen

Done

Line 6428, Patchset 3: origin_trial_feature_name: "UserMediaElement",
Joey Arhar . resolved

origin trial names are usually the same as the main flag name, right? want to add a comment explaining why this is not just "UserMediaElementLegacy"?

Thomas Nguyen

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6b113f4e08e95e110cbc265ec1844b52cdfae2c7
    Gerrit-Change-Number: 7913025
    Gerrit-PatchSet: 4
    Gerrit-Owner: Thomas Nguyen <tun...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Comment-Date: Wed, 10 Jun 2026 10:00:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Joey Arhar <jar...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Anders Hartvoll Ruud (Gerrit)

    unread,
    Jun 10, 2026, 7:22:51 AMJun 10
    to Thomas Nguyen, Katie D, Colin Blundell, Ravjit Uppal, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, srirama chandra sekhar, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jmedle...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Colin Blundell, Katie D, Ravjit Uppal and Thomas Nguyen

    Anders Hartvoll Ruud voted and added 1 comment

    Votes added by Anders Hartvoll Ruud

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 4 (Latest):
    Anders Hartvoll Ruud . resolved

    VirtualTestSuites lgtm

    (I assume that's why I'm here.)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Colin Blundell
    • Katie D
    • Ravjit Uppal
    • Thomas Nguyen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6b113f4e08e95e110cbc265ec1844b52cdfae2c7
    Gerrit-Change-Number: 7913025
    Gerrit-PatchSet: 4
    Gerrit-Owner: Thomas Nguyen <tun...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Katie D <ka...@chromium.org>
    Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>
    Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Attention: Ravjit Uppal <rav...@chromium.org>
    Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>
    Gerrit-Attention: Colin Blundell <blun...@chromium.org>
    Gerrit-Attention: Katie D <ka...@chromium.org>
    Gerrit-Comment-Date: Wed, 10 Jun 2026 11:22:33 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Colin Blundell (Gerrit)

    unread,
    Jun 10, 2026, 8:14:43 AMJun 10
    to Thomas Nguyen, Colin Blundell, Anders Hartvoll Ruud, Katie D, Ravjit Uppal, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, srirama chandra sekhar, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jmedle...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Katie D, Ravjit Uppal and Thomas Nguyen

    Colin Blundell voted and added 1 comment

    Votes added by Colin Blundell

    Code-Review+1

    1 comment

    Patchset-level comments
    Colin Blundell . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    Gerrit-Attention: Katie D <ka...@chromium.org>
    Gerrit-Comment-Date: Wed, 10 Jun 2026 12:14:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Katie D (Gerrit)

    unread,
    Jun 10, 2026, 2:45:19 PMJun 10
    to Thomas Nguyen, Colin Blundell, Anders Hartvoll Ruud, Ravjit Uppal, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, srirama chandra sekhar, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jmedle...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Ravjit Uppal and Thomas Nguyen

    Katie D voted and added 1 comment

    Votes added by Katie D

    Code-Review+1

    1 comment

    Patchset-level comments
    Katie D . resolved

    content/browser/accessibility LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Ravjit Uppal
    • Thomas Nguyen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    Gerrit-Comment-Date: Wed, 10 Jun 2026 18:44:46 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Ravjit Uppal (Gerrit)

    unread,
    Jun 12, 2026, 9:36:23 AM (12 days ago) Jun 12
    to Thomas Nguyen, Katie D, Colin Blundell, Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, srirama chandra sekhar, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jmedle...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Thomas Nguyen

    Ravjit Uppal voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Thomas Nguyen
    Gerrit-Attention: Thomas Nguyen <tun...@chromium.org>
    Gerrit-Comment-Date: Fri, 12 Jun 2026 13:35:59 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Thomas Nguyen (Gerrit)

    unread,
    Jun 15, 2026, 2:54:53 AM (10 days ago) Jun 15
    to Ravjit Uppal, Katie D, Colin Blundell, Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, srirama chandra sekhar, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jmedle...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

    Thomas Nguyen voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Gerrit-Comment-Date: Mon, 15 Jun 2026 06:54:28 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Thomas Nguyen (Gerrit)

    unread,
    Jun 15, 2026, 2:54:55 AM (10 days ago) Jun 15
    to Ravjit Uppal, Katie D, Colin Blundell, Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, srirama chandra sekhar, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jmedle...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

    Thomas Nguyen removed a vote from this change

    Removed Commit-Queue+2 by Thomas Nguyen <tun...@chromium.org>
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: deleteVote
    satisfied_requirement
    open
    diffy

    Thomas Nguyen (Gerrit)

    unread,
    Jun 15, 2026, 5:28:29 AM (10 days ago) Jun 15
    to Ravjit Uppal, Katie D, Colin Blundell, Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, srirama chandra sekhar, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jmedle...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

    Thomas Nguyen voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6b113f4e08e95e110cbc265ec1844b52cdfae2c7
    Gerrit-Change-Number: 7913025
    Gerrit-PatchSet: 5
    Gerrit-Owner: Thomas Nguyen <tun...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Katie D <ka...@chromium.org>
    Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>
    Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Permissions Reviews <permissio...@chromium.org>
    Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
    Gerrit-Comment-Date: Mon, 15 Jun 2026 09:28:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jun 15, 2026, 6:08:07 AM (10 days ago) Jun 15
    to Thomas Nguyen, Ravjit Uppal, Katie D, Colin Blundell, Anders Hartvoll Ruud, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, Permissions Reviews, srirama chandra sekhar, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, dtseng...@chromium.org, eric.c...@apple.com, extension...@chromium.org, feature-me...@chromium.org, francisjp...@google.com, jmedle...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    4 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    [CE]: Add legacy runtime flag for UserMediaElement

    Introduce the UserMediaElementLegacy runtime-enabled feature flag to
    gate legacy compatibility paths and attributes within the HTML user
    media element interface.

    This change allows for the separation of core user media element
    capabilities from legacy fallback behaviors (such as the 'type'
    attribute carried over from older permission element implementations).
    By mapping this new flag to the existing "UserMediaElement" origin
    trial name, both features can be evaluated concurrently during the
    trial phase while preserving a clean path for future deprecation.
    Fixed: 514279066
    Change-Id: I6b113f4e08e95e110cbc265ec1844b52cdfae2c7
    Reviewed-by: Colin Blundell <blun...@chromium.org>
    Reviewed-by: Joey Arhar <jar...@chromium.org>
    Reviewed-by: Katie D <ka...@chromium.org>
    Commit-Queue: Thomas Nguyen <tun...@chromium.org>
    Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
    Reviewed-by: Ravjit Uppal <rav...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1646686}
    Files:
    • M chrome/browser/controlled_frame/controlled_frame_permission_request_browsertest.cc
    • M chrome/browser/extensions/guest_view/web_view/web_view_media_access_apitest.cc
    • M chrome/browser/permissions/permission_element_browsertest.cc
    • M chrome/browser/ui/views/permissions/embedded_permission_prompt_interactive_uitest.cc
    • M chrome/browser/ui/views/permissions/embedded_permission_prompt_uitest.cc
    • M chrome/test/data/webui/webview/webui_webview_browsertest.cc
    • M components/permissions/pepc_initiated_permission_request_unittest.cc
    • M content/browser/accessibility/accessibility_action_browsertest.cc
    • M content/browser/accessibility/dump_accessibility_tree_browsertest.cc
    • M content/browser/permissions/embedded_permission_control_checker_unittest.cc
    • M third_party/blink/renderer/core/html/html_capability_element_base_test.cc
    • M third_party/blink/renderer/core/html/html_user_media_element.cc
    • M third_party/blink/renderer/core/html/html_user_media_element.idl
    • M third_party/blink/renderer/core/html/html_user_media_element_test.cc
    • M third_party/blink/renderer/platform/runtime_enabled_features.json5
    • M third_party/blink/web_tests/VirtualTestSuites
    Change size: M
    Delta: 16 files changed, 57 insertions(+), 12 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Colin Blundell, +1 by Katie D, +1 by Anders Hartvoll Ruud, +1 by Joey Arhar, +1 by Ravjit Uppal
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6b113f4e08e95e110cbc265ec1844b52cdfae2c7
    Gerrit-Change-Number: 7913025
    Gerrit-PatchSet: 6
    Gerrit-Owner: Thomas Nguyen <tun...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Katie D <ka...@chromium.org>
    Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>
    Gerrit-Reviewer: Thomas Nguyen <tun...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages