[M125] Disable KeyboardFocusableScrollers from stable [chromium/src : refs/branch-heads/6422]

0 views
Skip to first unread message

Rubber Stamper (Gerrit)

unread,
Apr 30, 2024, 12:35:14 PM4/30/24
to Di Zhang, Chromium LUCI CQ, AyeAye, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6422
Gerrit-Change-Id: I3b363bcf16a3c883d4cec68d7162e7d290477e73
Gerrit-Change-Number: 5490644
Gerrit-PatchSet: 1
Gerrit-Owner: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Comment-Date: Tue, 30 Apr 2024 16:35:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Apr 30, 2024, 1:57:17 PM4/30/24
to Di Zhang, Rubber Stamper, Chromium LUCI CQ, AyeAye, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org
Attention needed from Di Zhang

Mason Freed voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Di Zhang
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6422
Gerrit-Change-Id: I3b363bcf16a3c883d4cec68d7162e7d290477e73
Gerrit-Change-Number: 5490644
Gerrit-PatchSet: 1
Gerrit-Owner: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Di Zhang <dizh...@chromium.org>
Gerrit-Comment-Date: Tue, 30 Apr 2024 17:57:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Di Zhang (Gerrit)

unread,
Apr 30, 2024, 2:04:29 PM4/30/24
to Mason Freed, Rubber Stamper, Chromium LUCI CQ, AyeAye, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org

Di Zhang voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6422
Gerrit-Change-Id: I3b363bcf16a3c883d4cec68d7162e7d290477e73
Gerrit-Change-Number: 5490644
Gerrit-PatchSet: 1
Gerrit-Owner: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Comment-Date: Tue, 30 Apr 2024 18:04:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 30, 2024, 2:06:11 PM4/30/24
to Di Zhang, Mason Freed, Rubber Stamper, AyeAye, kinuko...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[M125] Disable KeyboardFocusableScrollers from stable

This is causing some elements to get incorrectly recognized as
focusable. Rolling back the release until we fix the bug.

(cherry picked from commit 54ed36f40085a38577bf76993aa21131f0bb2d9f)
Change-Id: I3b363bcf16a3c883d4cec68d7162e7d290477e73
Bug: 336490037, 40113891
Reviewed-by: Mason Freed <mas...@chromium.org>
Commit-Queue: Di Zhang <dizh...@chromium.org>
Commit-Queue: Mason Freed <mas...@chromium.org>
Auto-Submit: Di Zhang <dizh...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1292118}
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/branch-heads/6422@{#521}
Cr-Branched-From: 9012208d0ce02e0cf0adb9b62558627c356f3278-refs/heads/main@{#1287751}
Files:
  • M third_party/blink/renderer/platform/runtime_enabled_features.json5
Change size: XS
Delta: 1 file changed, 1 insertion(+), 2 deletions(-)
Branch: refs/branch-heads/6422
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mason Freed, Bot-Commit+1 by Rubber Stamper
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/6422
Gerrit-Change-Id: I3b363bcf16a3c883d4cec68d7162e7d290477e73
Gerrit-Change-Number: 5490644
Gerrit-PatchSet: 2
Gerrit-Owner: Di Zhang <dizh...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages