Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
kColor,
kWidth,
kStyle,
kBreak,
kOutset,
nit: not specifically related to this change, but while we're here, worth putting these in alphabetical order (same with all of the case statements they are referenced in in other files)
bool RuleOutset::ParseShorthand(
nit: the other shorthands above and below this place this method second, so may be worth swapping the ordering for consistency
CHECK(rule_outset);
nit: This shouldn't be needed given the if-statement above it
case CSSPropertyID::kRuleWidth:
return GetShorthandValueForBidirectionalGapRules(ruleWidthShorthand());
case CSSPropertyID::kRuleStyle:
nit: not related to this CL, but while we're here, could you swap the order of these for alphabetical order
<link rel="help" href="https://drafts.csswg.org/css-multicol/#propdef-column-rule">
<meta name="assert" content="column-rule supports the full grammar '<gap-rule-list> | <gap-auto-rule-list>'.">
nit: should this be rule-outset?
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
This CL implements parsing for `rule-outset` shorthand, defined
nit: "defined in"
bool RuleOutset::ParseShorthand(
Alison Mahernit: the other shorthands above and below this place this method second, so may be worth swapping the ordering for consistency
Actually, based on the other PR, it's the opposite, so I guess whichever order we decide on should be consistent between all of these
This CL implements parsing for `rule-outset` shorthand, defined
Javier Contrerasnit: "defined in"
Done
nit: not specifically related to this change, but while we're here, worth putting these in alphabetical order (same with all of the case statements they are referenced in in other files)
Removed in last CL as per my reply there.
Alison Mahernit: the other shorthands above and below this place this method second, so may be worth swapping the ordering for consistency
Actually, based on the other PR, it's the opposite, so I guess whichever order we decide on should be consistent between all of these
Done
nit: This shouldn't be needed given the if-statement above it
Done
case CSSPropertyID::kRuleWidth:
return GetShorthandValueForBidirectionalGapRules(ruleWidthShorthand());
case CSSPropertyID::kRuleStyle:
nit: not related to this CL, but while we're here, could you swap the order of these for alphabetical order
Done
<link rel="help" href="https://drafts.csswg.org/css-multicol/#propdef-column-rule">
Javier Contreras
Done
<meta name="assert" content="column-rule supports the full grammar '<gap-rule-list> | <gap-auto-rule-list>'.">
nit: should this be rule-outset?
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Code-Review | +1 |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/55434.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
[gap-decorations] Parsing `rule-outset` shorthand
This CL implements parsing for `rule-outset` shorthand, defined in
https://www.w3.org/TR/css-gaps-1/#propdef-rule-outset.
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/55434
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |