Stabilize number-appearance-vertical hover snapshot timing [chromium/src : main]
0 views
Skip to first unread message
Joanmarie Diggs (Gerrit)
Feb 26, 2026, 5:16:00 AM (3 days ago) Feb 26
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed
Joanmarie Diggs added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Feb 27, 2026, 5:29:35 PM (yesterday) Feb 27
to Joanmarie Diggs, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Joanmarie Diggs
Mason Freed voted and added 2 comments![]( "Open in Gerrit")
Votes added by Mason Freed
| Code-Review | +1 |
2 comments
Patchset-level comments
Mason Freed . resolved
LGTM
File third_party/blink/web_tests/fast/forms/number/number-appearance-vertical.html
Line 60, Patchset 4 (Latest):
if (window.testRunner)
testRunner.waitUntilDone();Mason Freed . unresolved
Given that the rest doesn't do anything, I think this should be
```
if (!window.testRunner)
return;
```
and then remove the check for `window.testRunner` below.
Related details
Attention is currently required from:
- Joanmarie Diggs
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joanmarie Diggs (Gerrit)
3:44 AM (17 hours ago) 3:44 AM
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Joanmarie Diggs added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/fast/forms/number/number-appearance-vertical.html
Given that the rest doesn't do anything, I think this should be
```
if (!window.testRunner)
return;
```and then remove the check for `window.testRunner` below.
Joanmarie Diggs
This code is not inside a function. So instead I put all the logic inside `if (window.testRunner) {}`.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joanmarie Diggs (Gerrit)
3:44 AM (17 hours ago) 3:44 AM
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Joanmarie Diggs voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
4:51 AM (16 hours ago) 4:51 AM
to Joanmarie Diggs, Mason Freed, chromium...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/web_tests/fast/forms/number/number-appearance-vertical.html
Insertions: 4, Deletions: 4.
@@ -57,14 +57,14 @@
// A spinbutton should be showing on the top (left)
input.focus();
}
-if (window.testRunner)
+if (window.testRunner) {
testRunner.waitUntilDone();
-runAfterLayoutAndPaint(function() {
runAfterLayoutAndPaint(function() {
- if (window.testRunner)
+ runAfterLayoutAndPaint(function() {
testRunner.notifyDone();
+ });
});
-});
+}
</script>
</body>
</html>
```
Change information
Commit message:
Stabilize number-appearance-vertical hover snapshot timing
This test sets :hover pseudo-class state and then finishes immediately.
On accessibility bot runs, the snapshot can be taken too early.
Finish after two layout-and-paint updates so the post-hover snapshot is
more reliable.
Bug: 487577798
Change-Id: I539461c1ce0e8829088eeac5ff04e9910657af9b
Reviewed-by: Mason Freed <mas...@chromium.org>
Commit-Queue: Joanmarie Diggs <jdi...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1591983}
Files:
- M third_party/blink/web_tests/fast/forms/number/number-appearance-vertical.html
Change size: S
Delta: 1 file changed, 12 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mason Freed
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages