Disable KeyboardFocusableScrollers from stable [chromium/src : main]

0 views

Skip to first unread message

Di Zhang (Gerrit)

unread,

Apr 24, 2024, 4:59:27 PM4/24/24

to Mason Freed, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Attention needed from Mason Freed

Di Zhang voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Mason Freed

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mason Freed (Gerrit)

unread,

Apr 24, 2024, 5:32:37 PM4/24/24

to Di Zhang, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Attention needed from Di Zhang

Mason Freed voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Di Zhang

Submit Requirements:

Code-Coverage
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Apr 24, 2024, 6:04:08 PM4/24/24

to Di Zhang, Mason Freed, chromium...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Disable KeyboardFocusableScrollers from stable

This is causing some elements to get incorrectly recognized as
focusable. Rolling back the release until we fix the bug.

Change-Id: I3b363bcf16a3c883d4cec68d7162e7d290477e73

Bug: 336490037, 40113891

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5484749

Reviewed-by: Mason Freed <mas...@chromium.org>

Commit-Queue: Di Zhang <dizh...@chromium.org>

Commit-Queue: Mason Freed <mas...@chromium.org>

Auto-Submit: Di Zhang <dizh...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1292118}

Files:

M third_party/blink/renderer/platform/runtime_enabled_features.json5

Change size: XS

Delta: 1 file changed, 1 insertion(+), 2 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Mason Freed

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages