[a11y] Fix null dereference when computing a pruned popover's details relation [chromium/src : main]

0 views
Skip to first unread message

Felipe Erias (Gerrit)

unread,
Jun 29, 2026, 10:07:44 PMJun 29
to David Tseng, Carlos Marcelo Barrera Nolasco, Gregory Dardyk, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Carlos Marcelo Barrera Nolasco, David Tseng and Gregory Dardyk

Felipe Erias voted and added 1 comment

Votes added by Felipe Erias

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Felipe Erias . resolved

Hello,

This CL fixes the NULL pointer crash at
https://issues.chromium.org/issues/487117774

The problem was that `AXObjectCache::Get()` may return null for a popover that has been pruned.

Thank you for your feedback.

Best,
Felipe

Open in Gerrit

Related details

Attention is currently required from:
  • Carlos Marcelo Barrera Nolasco
  • David Tseng
  • Gregory Dardyk
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6ca5ead6b9230b56c59e99a85ba2f02f6dc2c95f
Gerrit-Change-Number: 8017642
Gerrit-PatchSet: 4
Gerrit-Owner: Felipe Erias <felip...@igalia.com>
Gerrit-Reviewer: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
Gerrit-Reviewer: David Tseng <dts...@chromium.org>
Gerrit-Reviewer: Felipe Erias <felip...@igalia.com>
Gerrit-Reviewer: Gregory Dardyk <greg...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-Attention: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
Gerrit-Attention: David Tseng <dts...@chromium.org>
Gerrit-Attention: Gregory Dardyk <greg...@google.com>
Gerrit-Comment-Date: Tue, 30 Jun 2026 02:07:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

David Tseng (Gerrit)

unread,
Jul 14, 2026, 6:24:52 PM (12 days ago) Jul 14
to Felipe Erias, Carlos Marcelo Barrera Nolasco, Gregory Dardyk, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Carlos Marcelo Barrera Nolasco, Felipe Erias and Gregory Dardyk

David Tseng voted and added 1 comment

David Tseng added votes with a message

lgtm

Code-Review+1

1 comment

File third_party/blink/renderer/modules/accessibility/ax_object.cc
Line 2736, Patchset 5 (Latest): if (!ax_popover) {
David Tseng . unresolved

Is it worth consolidating these guards with the ones in GetInterestForTargetPopover into a common method? I only glossed over the two methods and found it confusing they differ subtely.

Open in Gerrit

Related details

Attention is currently required from:
  • Carlos Marcelo Barrera Nolasco
  • Felipe Erias
  • Gregory Dardyk
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6ca5ead6b9230b56c59e99a85ba2f02f6dc2c95f
Gerrit-Change-Number: 8017642
Gerrit-PatchSet: 5
Gerrit-Owner: Felipe Erias <felip...@igalia.com>
Gerrit-Reviewer: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
Gerrit-Reviewer: David Tseng <dts...@chromium.org>
Gerrit-Reviewer: Felipe Erias <felip...@igalia.com>
Gerrit-Reviewer: Gregory Dardyk <greg...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-Attention: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
Gerrit-Attention: Felipe Erias <felip...@igalia.com>
Gerrit-Attention: Gregory Dardyk <greg...@google.com>
Gerrit-Comment-Date: Tue, 14 Jul 2026 22:24:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joanmarie Diggs (Gerrit)

unread,
Jul 15, 2026, 9:08:30 AM (12 days ago) Jul 15
to Felipe Erias, David Tseng, Carlos Marcelo Barrera Nolasco, Gregory Dardyk, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Carlos Marcelo Barrera Nolasco, Felipe Erias and Gregory Dardyk

Joanmarie Diggs voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Carlos Marcelo Barrera Nolasco
  • Felipe Erias
  • Gregory Dardyk
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6ca5ead6b9230b56c59e99a85ba2f02f6dc2c95f
    Gerrit-Change-Number: 8017642
    Gerrit-PatchSet: 5
    Gerrit-Owner: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
    Gerrit-Reviewer: David Tseng <dts...@chromium.org>
    Gerrit-Reviewer: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: Gregory Dardyk <greg...@google.com>
    Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-Attention: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
    Gerrit-Attention: Felipe Erias <felip...@igalia.com>
    Gerrit-Attention: Gregory Dardyk <greg...@google.com>
    Gerrit-Comment-Date: Wed, 15 Jul 2026 13:08:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Felipe Erias (Gerrit)

    unread,
    Jul 22, 2026, 7:58:06 AM (5 days ago) Jul 22
    to Joanmarie Diggs, David Tseng, Carlos Marcelo Barrera Nolasco, Gregory Dardyk, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Carlos Marcelo Barrera Nolasco, David Tseng, Gregory Dardyk and Joanmarie Diggs

    Felipe Erias added 2 comments

    Patchset-level comments
    File-level comment, Patchset 7 (Latest):
    Felipe Erias . resolved

    Thank you for your feedback, please see my answer below.

    File third_party/blink/renderer/modules/accessibility/ax_object.cc
    Line 2736, Patchset 5: if (!ax_popover) {
    David Tseng . unresolved

    Is it worth consolidating these guards with the ones in GetInterestForTargetPopover into a common method? I only glossed over the two methods and found it confusing they differ subtely.

    Felipe Erias

    Good idea. I have consolidated the guards into `GetPopoverForDetailsRelation()`.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Carlos Marcelo Barrera Nolasco
    • David Tseng
    • Gregory Dardyk
    • Joanmarie Diggs
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6ca5ead6b9230b56c59e99a85ba2f02f6dc2c95f
    Gerrit-Change-Number: 8017642
    Gerrit-PatchSet: 7
    Gerrit-Owner: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
    Gerrit-Reviewer: David Tseng <dts...@chromium.org>
    Gerrit-Reviewer: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: Gregory Dardyk <greg...@google.com>
    Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-Attention: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
    Gerrit-Attention: David Tseng <dts...@chromium.org>
    Gerrit-Attention: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-Attention: Gregory Dardyk <greg...@google.com>
    Gerrit-Comment-Date: Wed, 22 Jul 2026 11:57:33 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: David Tseng <dts...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Tseng (Gerrit)

    unread,
    Jul 23, 2026, 11:02:01 AM (4 days ago) Jul 23
    to Felipe Erias, Joanmarie Diggs, Carlos Marcelo Barrera Nolasco, Gregory Dardyk, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Carlos Marcelo Barrera Nolasco, Felipe Erias, Gregory Dardyk and Joanmarie Diggs

    David Tseng voted and added 1 comment

    Votes added by David Tseng

    Code-Review+1

    1 comment

    File third_party/blink/renderer/modules/accessibility/ax_object.cc
    Line 2736, Patchset 5: if (!ax_popover) {
    David Tseng . resolved

    Is it worth consolidating these guards with the ones in GetInterestForTargetPopover into a common method? I only glossed over the two methods and found it confusing they differ subtely.

    Felipe Erias

    Good idea. I have consolidated the guards into `GetPopoverForDetailsRelation()`.

    David Tseng

    Acknowledged

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Carlos Marcelo Barrera Nolasco
    • Felipe Erias
    • Gregory Dardyk
    • Joanmarie Diggs
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I6ca5ead6b9230b56c59e99a85ba2f02f6dc2c95f
    Gerrit-Change-Number: 8017642
    Gerrit-PatchSet: 7
    Gerrit-Owner: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
    Gerrit-Reviewer: David Tseng <dts...@chromium.org>
    Gerrit-Reviewer: Felipe Erias <felip...@igalia.com>
    Gerrit-Reviewer: Gregory Dardyk <greg...@google.com>
    Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-Attention: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
    Gerrit-Attention: Felipe Erias <felip...@igalia.com>
    Gerrit-Attention: Joanmarie Diggs <jdi...@igalia.com>
    Gerrit-Attention: Gregory Dardyk <greg...@google.com>
    Gerrit-Comment-Date: Thu, 23 Jul 2026 15:01:44 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Felipe Erias <felip...@igalia.com>
    Comment-In-Reply-To: David Tseng <dts...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Joanmarie Diggs (Gerrit)

    unread,
    Jul 23, 2026, 11:07:42 AM (4 days ago) Jul 23
    to Felipe Erias, David Tseng, Carlos Marcelo Barrera Nolasco, Gregory Dardyk, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Carlos Marcelo Barrera Nolasco, Felipe Erias and Gregory Dardyk

    Joanmarie Diggs voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Carlos Marcelo Barrera Nolasco
    • Felipe Erias
    • Gregory Dardyk
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I6ca5ead6b9230b56c59e99a85ba2f02f6dc2c95f
      Gerrit-Change-Number: 8017642
      Gerrit-PatchSet: 7
      Gerrit-Owner: Felipe Erias <felip...@igalia.com>
      Gerrit-Reviewer: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
      Gerrit-Reviewer: David Tseng <dts...@chromium.org>
      Gerrit-Reviewer: Felipe Erias <felip...@igalia.com>
      Gerrit-Reviewer: Gregory Dardyk <greg...@google.com>
      Gerrit-Reviewer: Joanmarie Diggs <jdi...@igalia.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
      Gerrit-Attention: Carlos Marcelo Barrera Nolasco <carlos...@google.com>
      Gerrit-Attention: Felipe Erias <felip...@igalia.com>
      Gerrit-Attention: Gregory Dardyk <greg...@google.com>
      Gerrit-Comment-Date: Thu, 23 Jul 2026 15:07:23 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Felipe Erias (Gerrit)

      unread,
      Jul 26, 2026, 11:22:45 PM (5 hours ago) Jul 26
      to Joanmarie Diggs, David Tseng, Carlos Marcelo Barrera Nolasco, Gregory Dardyk, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
      Attention needed from Carlos Marcelo Barrera Nolasco and Gregory Dardyk

      Felipe Erias voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Carlos Marcelo Barrera Nolasco
      • Gregory Dardyk
      Gerrit-Attention: Gregory Dardyk <greg...@google.com>
      Gerrit-Comment-Date: Mon, 27 Jul 2026 03:22:20 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages