webrtc: measure lack of rtcp-mux again (and add a test) [chromium/src : main]
0 views
Skip to first unread message
Philipp Hancke (Gerrit)
Mar 5, 2026, 12:49:37 PMMar 5
to Harald Alvestrand, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
Attention needed from Harald Alvestrand
Philipp Hancke voted and added 1 comment![]( "Open in Gerrit")
Votes added by Philipp Hancke
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Harald Alvestrand
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philipp Hancke (Gerrit)
Mar 26, 2026, 5:59:37 AMMar 26
to Johannes Kron, Chromium LUCI CQ, Harald Alvestrand, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
Attention needed from Johannes Kron
Philipp Hancke added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Johannes Kron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Kron (Gerrit)
Mar 27, 2026, 8:20:14 AMMar 27
to Philipp Hancke, Chromium LUCI CQ, Harald Alvestrand, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
Attention needed from Philipp Hancke
Johannes Kron voted and added 2 comments![]( "Open in Gerrit")
Votes added by Johannes Kron
| Code-Review | +1 |
2 comments
Patchset-level comments
Johannes Kron . resolved
LGTM
File third_party/blink/web_tests/fast/peerconnection/RTCPeerConnection-without-rtcpmux.html
Line 49, Patchset 2 (Latest):
assert_not_equals(rtpTransport.selectedCandidatePairId, Johannes Kron . unresolved
Please fix this WARNING reported by Trailing Whitespace: Please remove the trailing whitespace.
Please remove the trailing whitespace.
Related details
Attention is currently required from:
- Philipp Hancke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philipp Hancke (Gerrit)
Mar 30, 2026, 3:10:17 AMMar 30
to Johannes Kron, Chromium LUCI CQ, Harald Alvestrand, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
Attention needed from Johannes Kron
Philipp Hancke added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/fast/peerconnection/RTCPeerConnection-without-rtcpmux.html
Line 49, Patchset 2:
assert_not_equals(rtpTransport.selectedCandidatePairId, Johannes Kron . resolved
Please fix this WARNING reported by Trailing Whitespace: Please remove the trailing whitespace.
Please remove the trailing whitespace.
Attention is currently required from:
- Johannes Kron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Kron (Gerrit)
Mar 30, 2026, 7:12:42 AMMar 30
to Philipp Hancke, Chromium LUCI CQ, Harald Alvestrand, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
Attention needed from Philipp Hancke
Johannes Kron voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Philipp Hancke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Harald Alvestrand (Gerrit)
Apr 10, 2026, 8:28:53 AM (3 days ago) Apr 10
to Philipp Hancke, Johannes Kron, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
Attention needed from Philipp Hancke
Harald Alvestrand voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Philipp Hancke
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Philipp Hancke (Gerrit)
5:02 AM (5 hours ago) 5:02 AM
to Harald Alvestrand, Johannes Kron, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
Philipp Hancke voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:51 AM (3 hours ago) 6:51 AM
to Philipp Hancke, Harald Alvestrand, Johannes Kron, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
webrtc: measure lack of rtcp-mux again (and add a test)
Bug: chromium:41314178
Change-Id: Id02b2b11bd2f67380246f8ea1936535e8c4221a0
Reviewed-by: Harald Alvestrand <h...@chromium.org>
Reviewed-by: Johannes Kron <kr...@chromium.org>
Commit-Queue: Philipp Hancke <philipp...@googlemail.com>
Cr-Commit-Position: refs/heads/main@{#1613613}
Files:
- M third_party/blink/web_tests/TestExpectations
- A third_party/blink/web_tests/fast/peerconnection/RTCPeerConnection-without-rtcpmux.html
- M tools/metrics/histograms/metadata/web_rtc/histograms.xml
Change size: M
Delta: 3 files changed, 63 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Harald Alvestrand, +1 by Johannes Kron
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages