Add crash key for dirty layout during painting. [chromium/src : main]
0 views
Skip to first unread message
Morten Stenshorne (Gerrit)
Feb 3, 2026, 9:11:32 AM (5 days ago) Feb 3
to Rune Lillesveen, Ian Kilpatrick, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick and Rune Lillesveen
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Ian Kilpatrick
- Rune Lillesveen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Rune Lillesveen (Gerrit)
Feb 3, 2026, 9:15:25 AM (5 days ago) Feb 3
to Morten Stenshorne, Rune Lillesveen, Ian Kilpatrick, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick and Morten Stenshorne
Rune Lillesveen voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Ian Kilpatrick
- Morten Stenshorne
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Morten Stenshorne (Gerrit)
Feb 3, 2026, 9:19:45 AM (5 days ago) Feb 3
to Rune Lillesveen, Ian Kilpatrick, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Ian Kilpatrick
Morten Stenshorne voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Ian Kilpatrick
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 3, 2026, 10:20:04 AM (5 days ago) Feb 3
to Morten Stenshorne, Rune Lillesveen, Ian Kilpatrick, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add crash key for dirty layout during painting.
Not sure where to begin. First of all, dump some information about the
layout tree without crashing at places where we bail when attempting to
paint while needing layout. Also do this in LayoutBlock::Paint() before
NOTREACHED().
Bug: 478682594
Change-Id: I0c5425f4661e079e94d51a1262de7c3190ba021b
Reviewed-by: Rune Lillesveen <fut...@chromium.org>
Commit-Queue: Morten Stenshorne <mste...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1578777}
Files:
- M third_party/blink/renderer/core/layout/layout_object.cc
- M third_party/blink/renderer/core/layout/layout_object.h
- M third_party/blink/renderer/core/paint/box_fragment_painter.cc
- M third_party/blink/renderer/core/paint/paint_layer.cc
Change size: S
Delta: 4 files changed, 35 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Rune Lillesveen
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chrome Crash (Prod) (Gerrit)
Feb 6, 2026, 10:35:58 PM (2 days ago) Feb 6
to Chromium LUCI CQ, Morten Stenshorne, Rune Lillesveen, Ian Kilpatrick, chromium...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Chrome Crash (Prod) has created a revert of this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages