Fix(mathml): Fix text node detection logic to properly handle floating elements. [chromium/src : main]

1 view
Skip to first unread message

THANK FLY (Gerrit)

unread,
Feb 27, 2026, 11:59:06 PM (21 hours ago) Feb 27
to Frédéric Wang, Ian Kilpatrick, Morten Stenshorne, Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Frédéric Wang, Morten Stenshorne and Philip Rogers

THANK FLY added 3 comments

Patchset-level comments
File-level comment, Patchset 1:
THANK FLY . resolved

Hi, I noticed that unit tests can't reproduce the dcheck using the example from the commit message, but chrome.exe will dcheck crash.So I didn't add a unit test here. Let me know if you have any suggestions.

Philip Rogers

I'd recommend a WPT crashtest for this.

Please add `third_party/blink/web_tests/external/wpt/mathml/crashtests/floating-text-crash.html` with:

```
<!DOCTYPE html>
<link rel="help" href="https://crbug.com/431272169">
This test passes if it does not crash.
<math>
  <mo style="width:1px;">!<!-- -->&rarr;</mo>
</math>

```

You can build with `autoninja -C out/Default blink_tests` and run this with `third_party/blink/tools/run_web_tests.py -t Debug external/wpt/mathml/crashtests/floating-text-crash.html`

THANK FLY

I added a html, and test in my local machine. It can reproduce dcheck crash and will be ok with my fixup.

File-level comment, Patchset 3 (Latest):
THANK FLY . resolved

I add a test html, please review again.thanks 😊
我添加了一个测试HTML代码，请再审核一次。谢谢。

Commit Message
Line 7, Patchset 1:Fix(mathml): Fix text node detection logic to properly handle floating
Philip Rogers . resolved

Please format the commit message like in https://chromium.googlesource.com/chromium/src/+/lkgr/docs/contributing.md#uploading-a-change-for-review, where the first line is a high-level description, then a newline, then the body of your commit message.

THANK FLY

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Frédéric Wang
  • Morten Stenshorne
  • Philip Rogers
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4b2b6edb590d24d9bab5ce9a3a8eee4d9eab8768
Gerrit-Change-Number: 7614911
Gerrit-PatchSet: 3
Gerrit-Owner: THANK FLY <thiefun...@gmail.com>
Gerrit-Reviewer: Frédéric Wang <fw...@igalia.com>
Gerrit-Reviewer: Morten Stenshorne <mste...@chromium.org>
Gerrit-Reviewer: THANK FLY <thiefun...@gmail.com>
Gerrit-CC: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-CC: Philip Rogers <p...@chromium.org>
Gerrit-Attention: Philip Rogers <p...@chromium.org>
Gerrit-Attention: Frédéric Wang <fw...@igalia.com>
Gerrit-Attention: Morten Stenshorne <mste...@chromium.org>
Gerrit-Comment-Date: Sat, 28 Feb 2026 04:58:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Philip Rogers <p...@chromium.org>
Comment-In-Reply-To: THANK FLY <thiefun...@gmail.com>
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages