COOP: restrict-properties reporting 4/*: Access reporting. [chromium/src : main]

Arthur Hemery (Gerrit)

unread,

May 17, 2023, 5:50:38 AM5/17/23

to alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org

Arthur Hemery uploaded patch set #4 to this change.

View Change

COOP: restrict-properties reporting 4/*: Access reporting.

Build on the existing virtual CoopRelatedGroup introduced in the
previous patch to add access reporting for COOP: restrict-properties.

Before installing access monitors, we compute whether the two windows
are in the same virtual CoopRelatedGroup. If so, that means they would
be able to use window.postMessage() and window.closed as usual. When
accesses are about to be reported we verify that we do not fall into
this special case.

Bug: 1424417
Change-Id: Icde8310fd269849d0f2c098a4a748eaed1584bcf
---
M content/browser/renderer_host/cross_origin_opener_policy_access_report_manager.cc
M content/browser/renderer_host/cross_origin_opener_policy_access_report_manager.h
M third_party/blink/public/mojom/frame/frame.mojom
M third_party/blink/renderer/core/frame/dom_window.cc
M third_party/blink/renderer/core/frame/dom_window.h
M third_party/blink/renderer/core/frame/local_frame_mojo_handler.cc
M third_party/blink/renderer/core/frame/local_frame_mojo_handler.h
A third_party/blink/web_tests/virtual/coop-restrict-properties/external/wpt/html/cross-origin-opener-policy/tentative/restrict-properties/access-reporting-openee-rp-ro.https-expected.txt
A third_party/blink/web_tests/virtual/coop-restrict-properties/external/wpt/html/cross-origin-opener-policy/tentative/restrict-properties/access-reporting-opener-rp-ro.https-expected.txt
9 files changed, 71 insertions(+), 32 deletions(-)

To view, visit change 4542646. To unsubscribe, or for help writing mail filters, visit settings.

Arthur Hemery (Gerrit)

unread,

May 17, 2023, 5:59:56 AM5/17/23

to alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org

Arthur Hemery uploaded patch set #5 to this change.

View Change

COOP: restrict-properties reporting 4/*: Access reporting.

Build on the existing virtual CoopRelatedGroup introduced in the
previous patch to add access reporting for COOP: restrict-properties.

Before installing access monitors, we compute whether the two windows
are in the same virtual CoopRelatedGroup. If so, that means they would

be able to use window.postMessage() and window.closed as usual. We
send the information all the way into the blink::AccessMonitor. When


accesses are about to be reported we verify that we do not fall into
this special case.

Bug: 1424417
Change-Id: Icde8310fd269849d0f2c098a4a748eaed1584bcf
---
M content/browser/renderer_host/cross_origin_opener_policy_access_report_manager.cc
M content/browser/renderer_host/cross_origin_opener_policy_access_report_manager.h
M third_party/blink/public/mojom/frame/frame.mojom
M third_party/blink/renderer/core/frame/dom_window.cc
M third_party/blink/renderer/core/frame/dom_window.h
M third_party/blink/renderer/core/frame/local_frame_mojo_handler.cc
M third_party/blink/renderer/core/frame/local_frame_mojo_handler.h
A third_party/blink/web_tests/virtual/coop-restrict-properties/external/wpt/html/cross-origin-opener-policy/tentative/restrict-properties/access-reporting-openee-rp-ro.https-expected.txt
A third_party/blink/web_tests/virtual/coop-restrict-properties/external/wpt/html/cross-origin-opener-policy/tentative/restrict-properties/access-reporting-opener-rp-ro.https-expected.txt
9 files changed, 71 insertions(+), 32 deletions(-)

To view, visit change 4542646. To unsubscribe, or for help writing mail filters, visit settings.

Arthur Hemery (Gerrit)

unread,

May 17, 2023, 6:10:59 AM5/17/23

to Camille Lamy, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org

Attention is currently required from: Camille Lamy.

Arthur Hemery would like Camille Lamy to review this change.

View Change

COOP: restrict-properties reporting 4/*: Access reporting.

Build on the existing virtual CoopRelatedGroup introduced in the
previous patch to add access reporting for COOP: restrict-properties.

Before installing access monitors, we compute whether the two windows
are in the same virtual CoopRelatedGroup. If so, that means they would
be able to use window.postMessage() and window.closed as usual. We
send the information all the way into the blink::AccessMonitor. When
accesses are about to be reported we verify that we do not fall into
this special case.

Bug: 1424417
Change-Id: Icde8310fd269849d0f2c098a4a748eaed1584bcf
---
M content/browser/renderer_host/cross_origin_opener_policy_access_report_manager.cc
M content/browser/renderer_host/cross_origin_opener_policy_access_report_manager.h
M third_party/blink/public/mojom/frame/frame.mojom
M third_party/blink/renderer/core/frame/dom_window.cc
M third_party/blink/renderer/core/frame/dom_window.h
M third_party/blink/renderer/core/frame/local_frame_mojo_handler.cc
M third_party/blink/renderer/core/frame/local_frame_mojo_handler.h
A third_party/blink/web_tests/virtual/coop-restrict-properties/external/wpt/html/cross-origin-opener-policy/tentative/restrict-properties/access-reporting-openee-rp-ro.https-expected.txt
A third_party/blink/web_tests/virtual/coop-restrict-properties/external/wpt/html/cross-origin-opener-policy/tentative/restrict-properties/access-reporting-opener-rp-ro.https-expected.txt
9 files changed, 71 insertions(+), 32 deletions(-)

To view, visit change 4542646. To unsubscribe, or for help writing mail filters, visit settings.

Arthur Hemery (Gerrit)

unread,

May 17, 2023, 6:50:46 AM5/17/23

to alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org

Attention is currently required from: Arthur Hemery, Camille Lamy.

Arthur Hemery uploaded patch set #7 to this change.

View Change

COOP: restrict-properties reporting 4/*: Access reporting.

Build on the existing virtual CoopRelatedGroup introduced in the
previous patch to add access reporting for COOP: restrict-properties.

Before installing access monitors, we compute whether the two windows
are in the same virtual CoopRelatedGroup. If so, that means they would
be able to use window.postMessage() and window.closed as usual. We
send the information all the way into the blink::AccessMonitor. When
accesses are about to be reported we verify that we do not fall into
this special case.

Low-Coverage-Reason: DomWindow changes are covered by WPTs.



Bug: 1424417
Change-Id: Icde8310fd269849d0f2c098a4a748eaed1584bcf
---
M content/browser/renderer_host/cross_origin_opener_policy_access_report_manager.cc
M content/browser/renderer_host/cross_origin_opener_policy_access_report_manager.h
M third_party/blink/public/mojom/frame/frame.mojom
M third_party/blink/renderer/core/frame/dom_window.cc
M third_party/blink/renderer/core/frame/dom_window.h
M third_party/blink/renderer/core/frame/local_frame_mojo_handler.cc
M third_party/blink/renderer/core/frame/local_frame_mojo_handler.h
A third_party/blink/web_tests/virtual/coop-restrict-properties/external/wpt/html/cross-origin-opener-policy/tentative/restrict-properties/access-reporting-openee-rp-ro.https-expected.txt
A third_party/blink/web_tests/virtual/coop-restrict-properties/external/wpt/html/cross-origin-opener-policy/tentative/restrict-properties/access-reporting-opener-rp-ro.https-expected.txt
9 files changed, 71 insertions(+), 32 deletions(-)

To view, visit change 4542646. To unsubscribe, or for help writing mail filters, visit settings.

Blink W3C Test Autoroller (Gerrit)

unread,

May 26, 2023, 8:26:26 AM5/26/23

to Arthur Hemery, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, Camille Lamy, Chromium LUCI CQ, Tricium, chromium...@chromium.org

Attention is currently required from: Camille Lamy.

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/40252.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

View Change

To view, visit change 4542646. To unsubscribe, or for help writing mail filters, visit settings.

Camille Lamy (Gerrit)

unread,

Jun 9, 2023, 8:22:47 AM6/9/23

to Arthur Hemery, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, Blink W3C Test Autoroller, Chromium LUCI CQ, Tricium, chromium...@chromium.org

Attention is currently required from: Arthur Hemery.

Patch set 12:Code-Review +1

View Change

1 comment:

Patchset:
- Patch Set #12:
  Thanks! Lgtm.

To view, visit change 4542646. To unsubscribe, or for help writing mail filters, visit settings.

Arthur Hemery (Gerrit)

unread,

Jun 9, 2023, 9:53:29 AM6/9/23

to alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, Camille Lamy, Blink W3C Test Autoroller, Chromium LUCI CQ, Tricium, chromium...@chromium.org

Attention is currently required from: Arthur Hemery.

Patch set 12:Commit-Queue +2

View Change

To view, visit change 4542646. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Jun 9, 2023, 10:50:16 AM6/9/23

to Arthur Hemery, alexmo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, Camille Lamy, Blink W3C Test Autoroller, Tricium, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Arthur Hemery: Commit
  Camille Lamy: Looks good to me

COOP: restrict-properties reporting 4/*: Access reporting.

Build on the existing virtual CoopRelatedGroup introduced in the
previous patch to add access reporting for COOP: restrict-properties.

Before installing access monitors, we compute whether the two windows
are in the same virtual CoopRelatedGroup. If so, that means they would
be able to use window.postMessage() and window.closed as usual. We
send the information all the way into the blink::AccessMonitor. When
accesses are about to be reported we verify that we do not fall into
this special case.

Low-Coverage-Reason: DomWindow changes are covered by WPTs.

Bug: 1424417
Change-Id: Icde8310fd269849d0f2c098a4a748eaed1584bcf

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4542646
Reviewed-by: Camille Lamy <cl...@chromium.org>
Commit-Queue: Arthur Hemery <ahe...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1155522}


---
M content/browser/renderer_host/cross_origin_opener_policy_access_report_manager.cc
M content/browser/renderer_host/cross_origin_opener_policy_access_report_manager.h
M third_party/blink/public/mojom/frame/frame.mojom
M third_party/blink/renderer/core/frame/dom_window.cc
M third_party/blink/renderer/core/frame/dom_window.h
M third_party/blink/renderer/core/frame/local_frame_mojo_handler.cc
M third_party/blink/renderer/core/frame/local_frame_mojo_handler.h
A third_party/blink/web_tests/virtual/coop-restrict-properties/external/wpt/html/cross-origin-opener-policy/tentative/restrict-properties/access-reporting-openee-rp-ro.https-expected.txt
A third_party/blink/web_tests/virtual/coop-restrict-properties/external/wpt/html/cross-origin-opener-policy/tentative/restrict-properties/access-reporting-opener-rp-ro.https-expected.txt
9 files changed, 71 insertions(+), 32 deletions(-)

To view, visit change 4542646. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward