Enable TwoCopyCanvasCapture on ChromeOS [chromium/src : main]

Zhaoliang Ma (Gerrit)

unread,

Oct 22, 2021, 1:05:47 AM10/22/21

to Guido Urdaneta, blink-...@chromium.org, feature-me...@chromium.org, poscia...@chromium.org, Dale Curtis, ccameron

Attention is currently required from: Guido Urdaneta.

Zhaoliang Ma would like Guido Urdaneta to review this change.

Enable TwoCopyCanvasCapture on ChromeOS

This CL enables the two copy canvas capture feature on ChromeOS.

Bug: 1201009, b/203695564
Change-Id: I8e2cfd6b099b961873792b9e6831d78b2680263c
---
M third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler.cc
1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler.cc b/third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler.cc
index d5faa2d..ed169a5 100644
--- a/third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler.cc
+++ b/third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler.cc
@@ -44,7 +44,7 @@
 
 const base::Feature kTwoCopyCanvasCapture {
   "TwoCopyCanvasCapture",
-#if defined(OS_MAC)
+#if defined(OS_MAC) || defined(OS_CHROMEOS)
       base::FEATURE_ENABLED_BY_DEFAULT
 #else
       base::FEATURE_DISABLED_BY_DEFAULT

To view, visit change 3234140. To unsubscribe, or for help writing mail filters, visit settings.

Zhaoliang Ma (Gerrit)

unread,

Oct 22, 2021, 1:05:51 AM10/22/21

to blink-...@chromium.org, feature-me...@chromium.org, poscia...@chromium.org, Guido Urdaneta, Dale Curtis, ccameron, chromium...@chromium.org

Attention is currently required from: Guido Urdaneta.

View Change

1 comment:

Patchset:
- Patch Set #4:
  Hi Guido, PTAL

To view, visit change 3234140. To unsubscribe, or for help writing mail filters, visit settings.

Guido Urdaneta (Gerrit)

unread,

Oct 25, 2021, 5:34:48 AM10/25/21

to Zhaoliang Ma, blink-...@chromium.org, feature-me...@chromium.org, poscia...@chromium.org, Chromium LUCI CQ, Dale Curtis, ccameron, chromium...@chromium.org

Attention is currently required from: Zhaoliang Ma.

Patch set 4:Code-Review +1

View Change

To view, visit change 3234140. To unsubscribe, or for help writing mail filters, visit settings.

ccameron (Gerrit)

unread,

Oct 25, 2021, 1:04:03 PM10/25/21

to Zhaoliang Ma, blink-...@chromium.org, feature-me...@chromium.org, poscia...@chromium.org, Guido Urdaneta, Chromium LUCI CQ, Dale Curtis, chromium...@chromium.org

Attention is currently required from: Zhaoliang Ma.

Patch set 4:Code-Review +1

View Change

To view, visit change 3234140. To unsubscribe, or for help writing mail filters, visit settings.

Dale Curtis (Gerrit)

unread,

Oct 25, 2021, 7:05:30 PM10/25/21

to Zhaoliang Ma, blink-...@chromium.org, feature-me...@chromium.org, poscia...@chromium.org, ccameron, Guido Urdaneta, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Zhaoliang Ma.

View Change

1 comment:

Patchset:
- Patch Set #4:
  Lets investigate the failures on https://chromium-review.googlesource.com/c/chromium/src/+/3238125 before landing this.
  WebCodecs GPU tests are failing when this is enabled, on Windows this highlighted an issue with the hardware encoders.
  See https://ci.chromium.org/ui/p/chromium/builders/try/gpu-fyi-try-chromeos-kevin/193/overview

To view, visit change 3234140. To unsubscribe, or for help writing mail filters, visit settings.

Zhaoliang Ma (Gerrit)

unread,

Oct 28, 2021, 3:42:25 AM10/28/21

to blink-...@chromium.org, feature-me...@chromium.org, poscia...@chromium.org, ccameron, Guido Urdaneta, Chromium LUCI CQ, Dale Curtis, chromium...@chromium.org

Attention is currently required from: Dale Curtis.

Patch set 5:Commit-Queue +1

View Change

2 comments:

Patchset:
- Patch Set #4:
  Lets investigate the failures on https://chromium-review.googlesource. […]
  Done
Patchset:
- Patch Set #5:
  please take another look

To view, visit change 3234140. To unsubscribe, or for help writing mail filters, visit settings.

Dale Curtis (Gerrit)

unread,

Oct 28, 2021, 2:13:57 PM10/28/21

to Zhaoliang Ma, blink-...@chromium.org, feature-me...@chromium.org, poscia...@chromium.org, ccameron, Guido Urdaneta, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Zhaoliang Ma.

Patch set 5:Code-Review +1

View Change

To view, visit change 3234140. To unsubscribe, or for help writing mail filters, visit settings.

Zhaoliang Ma (Gerrit)

unread,

Oct 29, 2021, 2:21:29 AM10/29/21

to blink-...@chromium.org, feature-me...@chromium.org, poscia...@chromium.org, Dale Curtis, ccameron, Guido Urdaneta, Chromium LUCI CQ, chromium...@chromium.org

Attention is currently required from: Zhaoliang Ma.

Patch set 5:Commit-Queue +2

View Change

To view, visit change 3234140. To unsubscribe, or for help writing mail filters, visit settings.

Chromium LUCI CQ (Gerrit)

unread,

Oct 29, 2021, 2:26:19 AM10/29/21

to Zhaoliang Ma, blink-...@chromium.org, feature-me...@chromium.org, poscia...@chromium.org, Dale Curtis, ccameron, Guido Urdaneta, chromium...@chromium.org

Chromium LUCI CQ submitted this change.

View Change

Approvals:
  Dale Curtis: Looks good to me
  ccameron: Looks good to me
  Guido Urdaneta: Looks good to me
  Zhaoliang Ma: Commit

Enable TwoCopyCanvasCapture on ChromeOS

This CL enables the two copy canvas capture feature on ChromeOS.

Bug: 1201009, b/203695564
Change-Id: I8e2cfd6b099b961873792b9e6831d78b2680263c

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3234140
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Reviewed-by: Guido Urdaneta <gui...@chromium.org>
Reviewed-by: ccameron <ccam...@chromium.org>
Commit-Queue: Zhaoliang Ma <zhaoli...@intel.com>
Cr-Commit-Position: refs/heads/main@{#936283}
---
M third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler.cc
1 file changed, 20 insertions(+), 1 deletion(-)

diff --git a/third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler.cc b/third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler.cc
index 27ab2d5..ad6c0d9 100644
--- a/third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler.cc
+++ b/third_party/blink/renderer/modules/mediacapturefromelement/canvas_capture_handler.cc
@@ -37,7 +37,8 @@


 
 const base::Feature kTwoCopyCanvasCapture {
   "TwoCopyCanvasCapture",
-#if defined(OS_MAC)

+// For ChromeOS, currently just enable this feature on X86 CPU, see b/203695564.
+#if defined(OS_MAC) || (defined(OS_CHROMEOS) && defined(ARCH_CPU_X86_FAMILY))


       base::FEATURE_ENABLED_BY_DEFAULT
 #else
       base::FEATURE_DISABLED_BY_DEFAULT

To view, visit change 3234140. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward