[Gardener] Revert "Multicast support in Direct Sockets #1" [chromium/src : main]

0 views
Skip to first unread message

Yifan Luo (Gerrit)

unread,
Sep 2, 2025, 10:35:18 AM9/2/25
to Rubber Stamper, AyeAye, Vlad Krot, Camille Lamy, Andrew Rayskiy, Chromium LUCI CQ, Andrey Kosyakov, Kentaro Hara, chromium...@chromium.org, Chromium IPC Reviews, AI Code Reviewer, Simon Hangl, Raphael Kubo da Costa, blink-...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, rmcelra...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Andrew Rayskiy, Andrey Kosyakov, Camille Lamy and Vlad Krot

Yifan Luo voted

Auto-Submit+1
Code-Review+1
Commit-Queue+2
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Rayskiy
  • Andrey Kosyakov
  • Camille Lamy
  • Vlad Krot
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I34c51e08ec9f94c0fd5d43de45beea3d15a18f2b
Gerrit-Change-Number: 6904272
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Luo <l...@chromium.org>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Reviewer: Camille Lamy <cl...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Vlad Krot <vk...@google.com>
Gerrit-Reviewer: Yifan Luo <l...@chromium.org>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Vlad Krot <vk...@google.com>
Gerrit-Attention: Camille Lamy <cl...@chromium.org>
Gerrit-Attention: Andrew Rayskiy <green...@google.com>
Gerrit-Attention: Andrey Kosyakov <ca...@chromium.org>
Gerrit-Comment-Date: Tue, 02 Sep 2025 14:35:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Sep 2, 2025, 10:35:21 AM9/2/25
to AyeAye, Vlad Krot, Camille Lamy, Andrew Rayskiy, Chromium LUCI CQ, Andrey Kosyakov, Kentaro Hara, chromium...@chromium.org, Chromium IPC Reviews, AI Code Reviewer, Simon Hangl, Raphael Kubo da Costa, blink-...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, rmcelra...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
Attention needed from Andrew Rayskiy, Andrey Kosyakov, Camille Lamy and Vlad Krot

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Rayskiy
  • Andrey Kosyakov
  • Camille Lamy
  • Vlad Krot
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Gerrit-Comment-Date: Tue, 02 Sep 2025 14:35:05 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Yifan Luo (Gerrit)

    unread,
    Sep 2, 2025, 10:35:45 AM9/2/25
    to Rubber Stamper, AyeAye, Vlad Krot, Camille Lamy, Andrew Rayskiy, Chromium LUCI CQ, Andrey Kosyakov, Kentaro Hara, chromium...@chromium.org, Chromium IPC Reviews, AI Code Reviewer, Simon Hangl, Raphael Kubo da Costa, blink-...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, rmcelra...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org
    Attention needed from Andrew Rayskiy, Andrey Kosyakov, Camille Lamy and Vlad Krot

    Yifan Luo voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Tue, 02 Sep 2025 14:35:20 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 2, 2025, 10:36:06 AM9/2/25
    to Yifan Luo, Rubber Stamper, AyeAye, Vlad Krot, Camille Lamy, Andrew Rayskiy, Andrey Kosyakov, Kentaro Hara, chromium...@chromium.org, Chromium IPC Reviews, AI Code Reviewer, Simon Hangl, Raphael Kubo da Costa, blink-...@chromium.org, jmedle...@chromium.org, blink-re...@chromium.org, rmcelra...@chromium.org, blink-revie...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [Gardener] Revert "Multicast support in Direct Sockets #1"

    This reverts commit ca80fdde7bdd64ec6a3baf615bcc473b2ecfe5d1.

    Reason for revert: Suspected causing test failure: https://ci.chromium.org/ui/p/chromium/builders/ci/fuchsia-arm64-cast-receiver-rel/26191/overview

    Bug: 398934282
    Original change's description:
    > Multicast support in Direct Sockets #1
    >
    > This CL adds IDL files for Multicast and necessary parameters to
    > UDPSocketOptions. Not everything is in place yet. cover: 1. Permission
    > Policy 2. Communication with real socket via mojo 3. Usage histograms 4.
    > Workers support 5. WPT tests (possibly).
    >
    > Explainer
    > https://github.com/explainers-by-googlers/multicast-in-direct-sockets.
    > Chrome Entry https://chromestatus.com/feature/5073740211814400 Intent to
    > prototype
    > https://groups.google.com/a/chromium.org/g/blink-dev/c/ADV4FZtN4nE
    >
    > The functionality is gated behind a blink flag MulticastInDirectSockets.
    >
    > Bug: 398934282
    > Change-Id: I57e7b982269b176e29657d07f69d838e016ad55f
    > Low-Coverage-Reason: TESTS_IN_SEPARATE_CL
    > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6894978
    > Commit-Queue: Vlad Krot <vk...@google.com>
    > Reviewed-by: Camille Lamy <cl...@chromium.org>
    > Reviewed-by: Andrew Rayskiy <green...@google.com>
    > Cr-Commit-Position: refs/heads/main@{#1509508}
    Bug: 398934282
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Change-Id: I34c51e08ec9f94c0fd5d43de45beea3d15a18f2b
    Commit-Queue: Yifan Luo <l...@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Reviewed-by: Yifan Luo <l...@chromium.org>
    Owners-Override: Yifan Luo <l...@chromium.org>
    Auto-Submit: Yifan Luo <l...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1509563}
    Files:
    • M content/browser/direct_sockets/direct_sockets_service_impl.cc
    • M content/browser/direct_sockets/direct_sockets_udp_browsertest.cc
    • M third_party/blink/public/mojom/direct_sockets/direct_sockets.mojom
    • M third_party/blink/renderer/bindings/generated_in_modules.gni
    • M third_party/blink/renderer/bindings/idl_in_modules.gni
    • M third_party/blink/renderer/modules/DEPS
    • M third_party/blink/renderer/modules/direct_sockets/BUILD.gn
    • M third_party/blink/renderer/modules/direct_sockets/README.md
    • D third_party/blink/renderer/modules/direct_sockets/multicast_controller.cc
    • D third_party/blink/renderer/modules/direct_sockets/multicast_controller.h
    • D third_party/blink/renderer/modules/direct_sockets/multicast_controller.idl
    • M third_party/blink/renderer/modules/direct_sockets/socket_connection.idl
    • M third_party/blink/renderer/modules/direct_sockets/socket_options.idl
    • M third_party/blink/renderer/modules/direct_sockets/udp_socket.cc
    • M third_party/blink/renderer/modules/direct_sockets/udp_socket.h
    Change size: L
    Delta: 15 files changed, 5 insertions(+), 359 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Yifan Luo, Bot-Commit+1 by Rubber Stamper
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I34c51e08ec9f94c0fd5d43de45beea3d15a18f2b
    Gerrit-Change-Number: 6904272
    Gerrit-PatchSet: 2
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages