Replace UNSAFE_TODO in AudioDestination with safe operations [chromium/src : main]

0 views
Skip to first unread message

Michael Wilson (Gerrit)

unread,
Mar 7, 2026, 1:47:08 AMMar 7
to Hongchan Choi, Chromium LUCI CQ, kelsen liu, Mahesh Kannan, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Hongchan Choi

Michael Wilson added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Michael Wilson . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Hongchan Choi
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaa38c3c67af891904ff7be0871f9c030b213c90e
Gerrit-Change-Number: 7645334
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Wilson <mjwi...@chromium.org>
Gerrit-Reviewer: Hongchan Choi <hong...@chromium.org>
Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
Gerrit-CC: Mahesh Kannan <kmah...@google.com>
Gerrit-CC: kelsen liu <kels...@chromium.org>
Gerrit-Attention: Hongchan Choi <hong...@chromium.org>
Gerrit-Comment-Date: Sat, 07 Mar 2026 06:46:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hongchan Choi (Gerrit)

unread,
Mar 9, 2026, 6:28:16 PMMar 9
to Chromium LUCI CQ, kelsen liu, Mahesh Kannan, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Michael Wilson

Hongchan Choi voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Wilson
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iaa38c3c67af891904ff7be0871f9c030b213c90e
    Gerrit-Change-Number: 7645334
    Gerrit-PatchSet: 1
    Gerrit-Owner: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Reviewer: Hongchan Choi <hong...@chromium.org>
    Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: Mahesh Kannan <kmah...@google.com>
    Gerrit-CC: kelsen liu <kels...@chromium.org>
    Gerrit-Attention: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Comment-Date: Mon, 09 Mar 2026 22:28:06 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Michael Wilson (Gerrit)

    unread,
    Mar 9, 2026, 9:05:43 PMMar 9
    to Hongchan Choi, Chromium LUCI CQ, kelsen liu, Mahesh Kannan, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Michael Wilson voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iaa38c3c67af891904ff7be0871f9c030b213c90e
    Gerrit-Change-Number: 7645334
    Gerrit-PatchSet: 1
    Gerrit-Owner: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Reviewer: Hongchan Choi <hong...@chromium.org>
    Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
    Gerrit-CC: Mahesh Kannan <kmah...@google.com>
    Gerrit-CC: kelsen liu <kels...@chromium.org>
    Gerrit-Comment-Date: Tue, 10 Mar 2026 01:05:32 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 9, 2026, 10:29:04 PMMar 9
    to Hongchan Choi, kelsen liu, Mahesh Kannan, chromium...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Replace UNSAFE_TODO in AudioDestination with safe operations

    Now that we have spanify methods in AudioChannel we can do this.

    This should cause no functional change.
    Bug: 401184803
    Change-Id: Iaa38c3c67af891904ff7be0871f9c030b213c90e
    Reviewed-by: Hongchan Choi <hong...@chromium.org>
    Commit-Queue: Michael Wilson <mjwi...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1596786}
    Files:
    • M third_party/blink/renderer/platform/audio/audio_destination.cc
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 5 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Hongchan Choi
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iaa38c3c67af891904ff7be0871f9c030b213c90e
    Gerrit-Change-Number: 7645334
    Gerrit-PatchSet: 2
    Gerrit-Owner: Michael Wilson <mjwi...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Hongchan Choi <hong...@chromium.org>
    Gerrit-Reviewer: Michael Wilson <mjwi...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages