[Headless]: Fix Forced Colors Tests for Headless Shell [chromium/src : main]
0 views
Skip to first unread message
Sam Davis Omekara (Gerrit)
Nov 12, 2024, 2:09:13 PMNov 12
to Weizhong Xia, Alison Maher, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Alison Maher and Weizhong Xia
Sam Davis Omekara added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Sam Davis Omekara . resolved
Hi @weiz...@google.com, is there a particular bot I can run to make sure these passes as anticipated.
Related details
Attention is currently required from:
- Alison Maher
- Weizhong Xia
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Weizhong Xia (Gerrit)
Nov 12, 2024, 2:18:44 PMNov 12
to Sam Davis Omekara, Chromium LUCI CQ, Alison Maher, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Alison Maher and Sam Davis Omekara
Weizhong Xia added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Sam Davis Omekara . resolved
Hi @weiz...@google.com, is there a particular bot I can run to make sure these passes as anticipated.
Weizhong Xia
Thanks, triggered (linux, mac13, win10)-wpt-chromium-rel on this CL. Please check results from there.
If the tests in this directory are all passing, you can add it to headless_shell.filter, then those tests will be run in CQ/CI with the new infra, and they won't be accidentally broken by other changes.
Related details
Attention is currently required from:
- Alison Maher
- Sam Davis Omekara
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam Davis Omekara (Gerrit)
Nov 12, 2024, 2:21:06 PMNov 12
to Chromium LUCI CQ, Weizhong Xia, Alison Maher, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Alison Maher
Sam Davis Omekara added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Sam Davis Omekara . resolved
Weizhong XiaHi @weiz...@google.com, is there a particular bot I can run to make sure these passes as anticipated.
Thanks, triggered (linux, mac13, win10)-wpt-chromium-rel on this CL. Please check results from there.
If the tests in this directory are all passing, you can add it to headless_shell.filter, then those tests will be run in CQ/CI with the new infra, and they won't be accidentally broken by other changes.
Sam Davis Omekara
Okay, expect this to pass mostly on win-10. For mac n linux, the issue is from the color pipeline in the ui layer way before we get to blink, so I have another change brewing that addresses that 🤓
Related details
Attention is currently required from:
- Alison Maher
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alison Maher (Gerrit)
Nov 12, 2024, 5:18:55 PMNov 12
to Sam Davis Omekara, Chromium LUCI CQ, Weizhong Xia, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Sam Davis Omekara
Alison Maher voted and added 1 comment![]( "Open in Gerrit")
Votes added by Alison Maher
| Code-Review | +1 |
1 comment
Commit Message
Line 20, Patchset 1 (Latest):
Alison Maher . unresolved
Might be worth noting that MacOS and Linux failures will also be followed up in a subsequent CL.
Related details
Attention is currently required from:
- Sam Davis Omekara
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam Davis Omekara (Gerrit)
Nov 12, 2024, 5:28:41 PMNov 12
to Alison Maher, Chromium LUCI CQ, Weizhong Xia, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Sam Davis Omekara added 1 comment![]( "Open in Gerrit")
Commit Message
Might be worth noting that MacOS and Linux failures will also be followed up in a subsequent CL.
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sam Davis Omekara (Gerrit)
Nov 12, 2024, 5:29:10 PMNov 12
to Alison Maher, Chromium LUCI CQ, Weizhong Xia, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Sam Davis Omekara voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 12, 2024, 5:38:13 PMNov 12
to Sam Davis Omekara, Alison Maher, Weizhong Xia, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[Headless]: Fix Forced Colors Tests for Headless Shell
This CL resolves issues with the forced colors mode tests in the
headless shell test environment. The errors occurred because the link
color in some reference files was not explicitly set to "VisitedText",
as is currently done in forced colors mode. Consequently, many actual
results did not match the expected results solely due to the link color
discrepancy. For more details, refer to this test bucket[1].
Most errors in the Windows scenario should be resolved with this
change, except for `forced-colors-mode-03.html`, which requires further
restructuring based on recent findings about the test's structure. This
will be addressed in a subsequent CL.
Failures on MacOS and Linux platforms will also be handled in a
subsequent CL.
[1]: https://chromium-layout-test-archives.storage.googleapis.com/results.html?json=chromium/ci/win10-wpt-chromium-rel/3919/headless_shell_wpt_tests_include_all%20%28experimental%29/full_results_jsonp.js
Bug: 368396826
Change-Id: Ifc925637e0f1438a5241017de7a2f3023380997e
Reviewed-by: Alison Maher <alm...@microsoft.com>
Commit-Queue: Sam Davis Omekara <samome...@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#1382010}
Files:
- M third_party/blink/web_tests/external/wpt/forced-colors-mode/backplate/forced-colors-mode-backplate-04-ref.html
- M third_party/blink/web_tests/external/wpt/forced-colors-mode/forced-colors-mode-36-ref.html
- M third_party/blink/web_tests/external/wpt/forced-colors-mode/forced-colors-mode-37-ref.html
- M third_party/blink/web_tests/external/wpt/forced-colors-mode/forced-colors-mode-38-ref.html
- M third_party/blink/web_tests/external/wpt/forced-colors-mode/forced-colors-mode-42-ref.html
- M third_party/blink/web_tests/external/wpt/forced-colors-mode/forced-colors-mode-44-ref.html
Change size: XS
Delta: 6 files changed, 8 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Alison Maher
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Nov 12, 2024, 6:07:09 PMNov 12
to Sam Davis Omekara, Chromium LUCI CQ, Alison Maher, Weizhong Xia, chromium...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/49131
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages