grammar/spellcheck: allow suggestion menu to show when moving the caret into the suggestion span [chromium/src : main]

[Philip Rogers (Gerrit)]

Attention needed from Chuong Ho and Koji Ishii

Philip Rogers added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Philip Rogers . unresolved

Can you add a test for this? text_suggestion_controller_test.cc has some examples. Try to cover the real-world scenarios you showed me in your video.

Open in Gerrit

Related details

Attention is currently required from:

• Chuong Ho
• Koji Ishii

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: Ia3173f6cd9eb40d4b973f7b07eb89c53278602a3

Gerrit-Change-Number: 6975309

Gerrit-PatchSet: 2

Gerrit-Owner: Chuong Ho <hdch...@chromium.org>

Gerrit-Reviewer: Chuong Ho <hdch...@chromium.org>

Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>

Gerrit-Reviewer: Philip Rogers <p...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Chuong Ho <hdch...@chromium.org>

Gerrit-Attention: Koji Ishii <ko...@chromium.org>

Gerrit-Comment-Date: Tue, 23 Sep 2025 23:16:00 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No