[CSS Modules] Create Import Map entry for Declarative CSS Modules [chromium/src : main]

0 views
Skip to first unread message

Rune Lillesveen (Gerrit)

unread,
Oct 14, 2025, 4:41:34 AM (yesterday) Oct 14
to Kurt Catti-Schmidt, Mason Freed, Rune Lillesveen, Hoch Hochkeppel, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, antoniosarto...@chromium.org, apavlo...@chromium.org, arthursonzog...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, mkwst+w...@chromium.org
Attention needed from Kurt Catti-Schmidt and Mason Freed

Rune Lillesveen added 3 comments

File third_party/blink/renderer/core/css/style_element.cc
Line 197, Patchset 6 (Latest): DCHECK(RuntimeEnabledFeatures::DeclarativeCSSModulesEnabled());
Rune Lillesveen . unresolved

CHECK?

Line 255, Patchset 6 (Latest):void StyleElement::CreateModule(Element& element, const String& text) {
Rune Lillesveen . unresolved

I find it a bit strange to have a "Create"-function that doesn't return a value.

Is there a more descriptive name that takes the Modulator mutations into account?

Line 298, Patchset 6 (Latest): DCHECK(import_map);
Rune Lillesveen . unresolved

Why not CHECK?

Open in Gerrit

Related details

Attention is currently required from:
  • Kurt Catti-Schmidt
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I68fa88d900a72be2e004249687912098c7a97812
Gerrit-Change-Number: 7038416
Gerrit-PatchSet: 6
Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Hoch Hochkeppel <mho...@microsoft.com>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
Gerrit-Comment-Date: Tue, 14 Oct 2025 08:40:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Kurt Catti-Schmidt (Gerrit)

unread,
Oct 14, 2025, 8:30:14 PM (yesterday) Oct 14
to Mason Freed, Rune Lillesveen, Hoch Hochkeppel, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, antoniosarto...@chromium.org, apavlo...@chromium.org, arthursonzog...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, mkwst+w...@chromium.org
Attention needed from Mason Freed and Rune Lillesveen

Kurt Catti-Schmidt added 3 comments

File third_party/blink/renderer/core/css/style_element.cc
Line 197, Patchset 6: DCHECK(RuntimeEnabledFeatures::DeclarativeCSSModulesEnabled());
Rune Lillesveen . resolved

CHECK?

Kurt Catti-Schmidt

Done

Line 255, Patchset 6:void StyleElement::CreateModule(Element& element, const String& text) {
Rune Lillesveen . resolved

I find it a bit strange to have a "Create"-function that doesn't return a value.

Is there a more descriptive name that takes the Modulator mutations into account?

Kurt Catti-Schmidt

Good point. Renamed to `AddImportMapEntry`.

Line 298, Patchset 6: DCHECK(import_map);
Rune Lillesveen . resolved

Why not CHECK?

Kurt Catti-Schmidt

Just more used to `DCHECK`. I converted a few more here.

Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
  • Rune Lillesveen
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I68fa88d900a72be2e004249687912098c7a97812
    Gerrit-Change-Number: 7038416
    Gerrit-PatchSet: 7
    Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Hoch Hochkeppel <mho...@microsoft.com>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Comment-Date: Wed, 15 Oct 2025 00:29:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Rune Lillesveen <fut...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rune Lillesveen (Gerrit)

    unread,
    2:36 AM (19 hours ago) 2:36 AM
    to Kurt Catti-Schmidt, Rune Lillesveen, Mason Freed, Hoch Hochkeppel, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, antoniosarto...@chromium.org, apavlo...@chromium.org, arthursonzog...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, mkwst+w...@chromium.org
    Attention needed from Kurt Catti-Schmidt and Mason Freed

    Rune Lillesveen voted and added 2 comments

    Votes added by Rune Lillesveen

    Code-Review+1

    2 comments

    Patchset-level comments
    File-level comment, Patchset 7 (Latest):
    Rune Lillesveen . resolved

    lgtm

    File third_party/blink/renderer/core/css/style_element.h
    Line 75, Patchset 7 (Latest): void AddImportMapEntry(Element&, const String&);
    Rune Lillesveen . unresolved

    Nit: 'source_text' or just 'text' since the type 'String' doesn't clearly state what this parameter is.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kurt Catti-Schmidt
    • Mason Freed
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I68fa88d900a72be2e004249687912098c7a97812
    Gerrit-Change-Number: 7038416
    Gerrit-PatchSet: 7
    Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Hoch Hochkeppel <mho...@microsoft.com>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Kurt Catti-Schmidt <ksc...@microsoft.com>
    Gerrit-Comment-Date: Wed, 15 Oct 2025 06:35:45 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kurt Catti-Schmidt (Gerrit)

    unread,
    12:25 PM (9 hours ago) 12:25 PM
    to Rune Lillesveen, Mason Freed, Hoch Hochkeppel, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, antoniosarto...@chromium.org, apavlo...@chromium.org, arthursonzog...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, mkwst+w...@chromium.org
    Attention needed from Mason Freed

    Kurt Catti-Schmidt voted and added 1 comment

    Votes added by Kurt Catti-Schmidt

    Commit-Queue+1

    1 comment

    File third_party/blink/renderer/core/css/style_element.h
    Line 75, Patchset 7: void AddImportMapEntry(Element&, const String&);
    Rune Lillesveen . resolved

    Nit: 'source_text' or just 'text' since the type 'String' doesn't clearly state what this parameter is.

    Kurt Catti-Schmidt

    Went with `text` for consistency with other methods in this file.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mason Freed
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I68fa88d900a72be2e004249687912098c7a97812
      Gerrit-Change-Number: 7038416
      Gerrit-PatchSet: 7
      Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
      Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Hoch Hochkeppel <mho...@microsoft.com>
      Gerrit-Attention: Mason Freed <mas...@chromium.org>
      Gerrit-Comment-Date: Wed, 15 Oct 2025 16:24:41 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Comment-In-Reply-To: Rune Lillesveen <fut...@chromium.org>
      satisfied_requirement
      open
      diffy

      Blink W3C Test Autoroller (Gerrit)

      unread,
      12:43 PM (8 hours ago) 12:43 PM
      to Kurt Catti-Schmidt, Rune Lillesveen, Mason Freed, Hoch Hochkeppel, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, antoniosarto...@chromium.org, apavlo...@chromium.org, arthursonzog...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, mkwst+w...@chromium.org
      Attention needed from Mason Freed

      Message from Blink W3C Test Autoroller

      Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/55456.

      When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

      WPT Export docs:
      https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Mason Freed
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I68fa88d900a72be2e004249687912098c7a97812
      Gerrit-Change-Number: 7038416
      Gerrit-PatchSet: 8
      Gerrit-Owner: Kurt Catti-Schmidt <ksc...@microsoft.com>
      Gerrit-Reviewer: Kurt Catti-Schmidt <ksc...@microsoft.com>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Hoch Hochkeppel <mho...@microsoft.com>
      Gerrit-Attention: Mason Freed <mas...@chromium.org>
      Gerrit-Comment-Date: Wed, 15 Oct 2025 16:43:41 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages