Reland "Fix double-counting of script execution duration for nested scripts" [chromium/src : main]

[keyou z (Gerrit)]

Attention needed from Charles Hager, Hiroshige Hayashizaki and Minoru Chikamune

keyou z added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

keyou z . resolved

This CL is ready for review.

Open in Gerrit

Related details

Attention is currently required from:

• Charles Hager
• Hiroshige Hayashizaki
• Minoru Chikamune

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5694951c21cb7688877e3b963e6da97af678939c

Gerrit-Change-Number: 6933980

Gerrit-PatchSet: 2

Gerrit-Owner: keyou z <qqki...@gmail.com>

Gerrit-Reviewer: Charles Hager <clh...@google.com>

Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Charles Hager <clh...@google.com>

Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Attention: Minoru Chikamune <chik...@chromium.org>

Gerrit-Comment-Date: Wed, 10 Sep 2025 07:14:29 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Minoru Chikamune (Gerrit)]

Attention needed from Charles Hager, Hiroshige Hayashizaki and keyou z

Minoru Chikamune added 2 comments

File third_party/blink/renderer/core/testing/data/script/nested-script.js

Line 5, Patchset 2 (Latest):while (Date.now() - start < 200) {

Minoru Chikamune . unresolved

Perhaps this must be `<=`?

File third_party/blink/renderer/core/testing/data/script/parser-blocked-inline-nested-script.html

Line 8, Patchset 2 (Latest): while (Date.now() - start < 200) {

Minoru Chikamune . unresolved

ditto.

Open in Gerrit

Related details

Attention is currently required from:

• Charles Hager
• Hiroshige Hayashizaki
• keyou z

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5694951c21cb7688877e3b963e6da97af678939c

Gerrit-Change-Number: 6933980

Gerrit-PatchSet: 2

Gerrit-Owner: keyou z <qqki...@gmail.com>

Gerrit-Reviewer: Charles Hager <clh...@google.com>

Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Charles Hager <clh...@google.com>

Gerrit-Attention: keyou z <qqki...@gmail.com>

Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Comment-Date: Wed, 10 Sep 2025 07:17:32 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Minoru Chikamune (Gerrit)]

Attention needed from Charles Hager, Hiroshige Hayashizaki and keyou z

Minoru Chikamune voted and added 3 comments

Votes added by Minoru Chikamune

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Minoru Chikamune . resolved

Thanks!

File third_party/blink/renderer/core/testing/data/script/nested-script.js

Line 5, Patchset 2 (Latest):while (Date.now() - start < 200) {

Minoru Chikamune . resolved

Perhaps this must be `<=`?

Minoru Chikamune

Sorry, never mind. I was wrong.

File third_party/blink/renderer/core/testing/data/script/parser-blocked-inline-nested-script.html

Line 8, Patchset 2 (Latest): while (Date.now() - start < 200) {

Minoru Chikamune . resolved

ditto.

Minoru Chikamune

Done

Open in Gerrit

Related details

Attention is currently required from:

• Charles Hager
• Hiroshige Hayashizaki
• keyou z

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5694951c21cb7688877e3b963e6da97af678939c

Gerrit-Change-Number: 6933980

Gerrit-PatchSet: 2

Gerrit-Owner: keyou z <qqki...@gmail.com>

Gerrit-Reviewer: Charles Hager <clh...@google.com>

Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Charles Hager <clh...@google.com>

Gerrit-Attention: keyou z <qqki...@gmail.com>

Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Comment-Date: Wed, 10 Sep 2025 07:24:51 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: Minoru Chikamune <chik...@chromium.org>

[keyou z (Gerrit)]

Attention needed from Charles Hager, Hiroshige Hayashizaki and Minoru Chikamune

keyou z added 2 comments

File third_party/blink/renderer/core/testing/data/script/nested-script.js

Line 5, Patchset 2:while (Date.now() - start < 200) {

Minoru Chikamune . resolved

Perhaps this must be `<=`?

keyou z

Nice catch, it's more simpler to make the UT robust. Thanks!

File third_party/blink/renderer/core/testing/data/script/parser-blocked-inline-nested-script.html

Line 8, Patchset 2: while (Date.now() - start < 200) {

Minoru Chikamune . resolved

ditto.

keyou z

Acknowledged

Open in Gerrit

Related details

Attention is currently required from:

• Charles Hager
• Hiroshige Hayashizaki
• Minoru Chikamune

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5694951c21cb7688877e3b963e6da97af678939c

Gerrit-Change-Number: 6933980

Gerrit-PatchSet: 3

Gerrit-Owner: keyou z <qqki...@gmail.com>

Gerrit-Reviewer: Charles Hager <clh...@google.com>

Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Charles Hager <clh...@google.com>

Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Attention: Minoru Chikamune <chik...@chromium.org>

Gerrit-Comment-Date: Wed, 10 Sep 2025 07:40:46 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Minoru Chikamune <chik...@chromium.org>

[Minoru Chikamune (Gerrit)]

Attention needed from Charles Hager, Hiroshige Hayashizaki and keyou z

Minoru Chikamune added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Minoru Chikamune . resolved

Probably it's good to run `android-14-x64-rel` tryjob since this was failing before.

Open in Gerrit

Related details

Attention is currently required from:

• Charles Hager
• Hiroshige Hayashizaki
• keyou z

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5694951c21cb7688877e3b963e6da97af678939c

Gerrit-Change-Number: 6933980

Gerrit-PatchSet: 4

Gerrit-Owner: keyou z <qqki...@gmail.com>

Gerrit-Reviewer: Charles Hager <clh...@google.com>

Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Charles Hager <clh...@google.com>

Gerrit-Attention: keyou z <qqki...@gmail.com>

Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Comment-Date: Wed, 10 Sep 2025 07:46:35 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[keyou z (Gerrit)]

Attention needed from Charles Hager, Hiroshige Hayashizaki and Minoru Chikamune

keyou z added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Minoru Chikamune . resolved

Probably it's good to run `android-14-x64-rel` tryjob since this was failing before.

keyou z

Can you help to run the tryjob as I'm not a dry-runner?

Open in Gerrit

Related details

Attention is currently required from:

• Charles Hager
• Hiroshige Hayashizaki
• Minoru Chikamune

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5694951c21cb7688877e3b963e6da97af678939c

Gerrit-Change-Number: 6933980

Gerrit-PatchSet: 4

Gerrit-Owner: keyou z <qqki...@gmail.com>

Gerrit-Reviewer: Charles Hager <clh...@google.com>

Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>

Gerrit-Reviewer: keyou z <qqki...@gmail.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Charles Hager <clh...@google.com>

Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Attention: Minoru Chikamune <chik...@chromium.org>

Gerrit-Comment-Date: Wed, 10 Sep 2025 07:52:18 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Minoru Chikamune <chik...@chromium.org>

[Minoru Chikamune (Gerrit)]

Attention needed from Charles Hager, Hiroshige Hayashizaki and keyou z

Minoru Chikamune added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Minoru Chikamune . resolved

Probably it's good to run `android-14-x64-rel` tryjob since this was failing before.

keyou z

Can you help to run the tryjob as I'm not a dry-runner?

Minoru Chikamune

Sure. Done.

Open in Gerrit

Related details

Attention is currently required from:

• Charles Hager
• Hiroshige Hayashizaki
• keyou z

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5694951c21cb7688877e3b963e6da97af678939c

Gerrit-Change-Number: 6933980

Gerrit-PatchSet: 4

Gerrit-Owner: keyou z <qqki...@gmail.com>

Gerrit-Reviewer: Charles Hager <clh...@google.com>

Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>

Gerrit-Reviewer: keyou z <qqki...@gmail.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Charles Hager <clh...@google.com>

Gerrit-Attention: keyou z <qqki...@gmail.com>

Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Comment-Date: Wed, 10 Sep 2025 07:53:38 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: keyou z <qqki...@gmail.com>

Comment-In-Reply-To: Minoru Chikamune <chik...@chromium.org>

[keyou z (Gerrit)]

Attention needed from Charles Hager, Hiroshige Hayashizaki and Minoru Chikamune

keyou z added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

keyou z . resolved

This CL has passed the run, and is ready for review.

Open in Gerrit

Related details

Attention is currently required from:

• Charles Hager
• Hiroshige Hayashizaki
• Minoru Chikamune

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5694951c21cb7688877e3b963e6da97af678939c

Gerrit-Change-Number: 6933980

Gerrit-PatchSet: 4

Gerrit-Owner: keyou z <qqki...@gmail.com>

Gerrit-Reviewer: Charles Hager <clh...@google.com>

Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>

Gerrit-Reviewer: keyou z <qqki...@gmail.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Charles Hager <clh...@google.com>

Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Attention: Minoru Chikamune <chik...@chromium.org>

Gerrit-Comment-Date: Wed, 10 Sep 2025 09:36:31 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Minoru Chikamune (Gerrit)]

Attention needed from Charles Hager, Hiroshige Hayashizaki and keyou z

Minoru Chikamune voted and added 1 comment

Votes added by Minoru Chikamune

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Minoru Chikamune . resolved

Thank you! LGTM.

Open in Gerrit

Related details

Attention is currently required from:

• Charles Hager
• Hiroshige Hayashizaki
• keyou z

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5694951c21cb7688877e3b963e6da97af678939c

Gerrit-Change-Number: 6933980

Gerrit-PatchSet: 4

Gerrit-Owner: keyou z <qqki...@gmail.com>

Gerrit-Reviewer: Charles Hager <clh...@google.com>

Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>

Gerrit-Reviewer: keyou z <qqki...@gmail.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Charles Hager <clh...@google.com>

Gerrit-Attention: keyou z <qqki...@gmail.com>

Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Comment-Date: Wed, 10 Sep 2025 09:37:37 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

[Charles Hager (Gerrit)]

Attention needed from Hiroshige Hayashizaki and keyou z

Charles Hager voted Code-Review+1

Code-Review

+1

Open in Gerrit

Related details

Attention is currently required from:

• Hiroshige Hayashizaki
• keyou z

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5694951c21cb7688877e3b963e6da97af678939c

Gerrit-Change-Number: 6933980

Gerrit-PatchSet: 4

Gerrit-Owner: keyou z <qqki...@gmail.com>

Gerrit-Reviewer: Charles Hager <clh...@google.com>

Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>

Gerrit-Reviewer: keyou z <qqki...@gmail.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: keyou z <qqki...@gmail.com>

Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Comment-Date: Wed, 10 Sep 2025 16:57:43 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[keyou z (Gerrit)]

Attention needed from Hiroshige Hayashizaki

keyou z added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

keyou z . resolved

Hi @hiro...@chromium.org, please review again and send it to CQ. Thank you!

Open in Gerrit

Related details

Attention is currently required from:

• Hiroshige Hayashizaki

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5694951c21cb7688877e3b963e6da97af678939c

Gerrit-Change-Number: 6933980

Gerrit-PatchSet: 4

Gerrit-Owner: keyou z <qqki...@gmail.com>

Gerrit-Reviewer: Charles Hager <clh...@google.com>

Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>

Gerrit-Reviewer: keyou z <qqki...@gmail.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Comment-Date: Fri, 12 Sep 2025 02:48:16 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[keyou z (Gerrit)]

Attention needed from Hiroshige Hayashizaki

keyou z added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

keyou z . resolved

Ping...

Gerrit-Comment-Date: Tue, 16 Sep 2025 11:40:02 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[keyou z (Gerrit)]

Attention needed from Hiroshige Hayashizaki

keyou z added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

keyou z . resolved

Hi @hiro...@chromium.org, please review again and send it to CQ. Thank you!

keyou z

Hi @hiro...@chromium.org, it's been a while since I've heard back from you, so if you've seen it, please reply. Thank you!

Gerrit-Comment-Date: Thu, 18 Sep 2025 06:25:43 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: keyou z <qqki...@gmail.com>

[keyou z (Gerrit)]

Attention needed from Hiroshige Hayashizaki and Xiaocheng Hu

keyou z added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

keyou z . resolved

Hi @xiaoc...@chromium.org, can you provide a more +1 and help send it to CQ? Thank you!

Open in Gerrit

Related details

Attention is currently required from:

• Hiroshige Hayashizaki
• Xiaocheng Hu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5694951c21cb7688877e3b963e6da97af678939c

Gerrit-Change-Number: 6933980

Gerrit-PatchSet: 4

Gerrit-Owner: keyou z <qqki...@gmail.com>

Gerrit-Reviewer: Charles Hager <clh...@google.com>

Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>

Gerrit-Reviewer: Xiaocheng Hu <xiaoc...@chromium.org>

Gerrit-Reviewer: keyou z <qqki...@gmail.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Xiaocheng Hu <xiaoc...@chromium.org>

Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Comment-Date: Tue, 23 Sep 2025 07:59:55 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Xiaocheng Hu (Gerrit)]

Attention needed from Hiroshige Hayashizaki and keyou z

Xiaocheng Hu added 1 comment

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Xiaocheng Hu . resolved

Could you add to the CL description:

• The reason why the previous CL got reverted
• The difference between this CL and the reverted one, and how did it fix the issue found in the revert CL

Thank you!

Open in Gerrit

Related details

Attention is currently required from:

• Hiroshige Hayashizaki
• keyou z

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5694951c21cb7688877e3b963e6da97af678939c

Gerrit-Change-Number: 6933980

Gerrit-PatchSet: 4

Gerrit-Owner: keyou z <qqki...@gmail.com>

Gerrit-Reviewer: Charles Hager <clh...@google.com>

Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>

Gerrit-Reviewer: Xiaocheng Hu <xiaoc...@chromium.org>

Gerrit-Reviewer: keyou z <qqki...@gmail.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: keyou z <qqki...@gmail.com>

Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Comment-Date: Tue, 23 Sep 2025 09:19:52 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[keyou z (Gerrit)]

Attention needed from Hiroshige Hayashizaki and Xiaocheng Hu

keyou z added 2 comments

Patchset-level comments

File-level comment, Patchset 4:

Xiaocheng Hu . resolved

Could you add to the CL description:

• The reason why the previous CL got reverted
• The difference between this CL and the reverted one, and how did it fix the issue found in the revert CL

Thank you!

keyou z

Done.

File-level comment, Patchset 5 (Latest):

keyou z . resolved

Commit message was updated.

Open in Gerrit

Related details

Attention is currently required from:

• Hiroshige Hayashizaki
• Xiaocheng Hu

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I5694951c21cb7688877e3b963e6da97af678939c

Gerrit-Change-Number: 6933980

Gerrit-PatchSet: 5

Gerrit-Owner: keyou z <qqki...@gmail.com>

Gerrit-Reviewer: Charles Hager <clh...@google.com>

Gerrit-Reviewer: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Reviewer: Minoru Chikamune <chik...@chromium.org>

Gerrit-Reviewer: Xiaocheng Hu <xiaoc...@chromium.org>

Gerrit-Reviewer: keyou z <qqki...@gmail.com>

Gerrit-CC: AyeAye <android-bu...@system.gserviceaccount.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Xiaocheng Hu <xiaoc...@chromium.org>

Gerrit-Attention: Hiroshige Hayashizaki <hiro...@chromium.org>

Gerrit-Comment-Date: Wed, 24 Sep 2025 02:25:41 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Xiaocheng Hu <xiaoc...@chromium.org>