[EventTiming] Rename targetIdentifier to targetSelector after feedback. [chromium/src : main]
0 views
Skip to first unread message
Michal Mocny (Gerrit)
10:35 AM (11 hours ago) 10:35 AM
to Scott Haseley, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org
Attention needed from Scott Haseley
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Johannes Henkel (Gerrit)
11:55 AM (9 hours ago) 11:55 AM
to Michal Mocny, Scott Haseley, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org
Attention needed from Michal Mocny and Scott Haseley
Johannes Henkel voted and added 1 comment![]( "Open in Gerrit")
Votes added by Johannes Henkel
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Johannes Henkel . resolved
Nice!
I guess the feature doesn't have some wpt except for the idl, is that right? Perhaps worth creating a bug for that?
Related details
Attention is currently required from:
- Michal Mocny
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Haseley (Gerrit)
12:12 PM (9 hours ago) 12:12 PM
to Michal Mocny, Johannes Henkel, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org
Attention needed from Michal Mocny
Scott Haseley voted and added 1 comment![]( "Open in Gerrit")
Votes added by Scott Haseley
| Code-Review | +1 |
1 comment
Patchset-level comments
Scott Haseley . resolved
LGTM. Looks like the tests just need to be updated.
Related details
Attention is currently required from:
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michal Mocny (Gerrit)
12:29 PM (9 hours ago) 12:29 PM
to Scott Haseley, Johannes Henkel, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org
Michal Mocny added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Scott Haseley . resolved
LGTM. Looks like the tests just need to be updated.
Michal Mocny
Yeah woops, lol.
Johannes Henkel . resolved
Nice!
I guess the feature doesn't have some wpt except for the idl, is that right? Perhaps worth creating a bug for that?
Michal Mocny
I'm just silly and forgot to update the WPT
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michal Mocny (Gerrit)
5:17 PM (4 hours ago) 5:17 PM
to AyeAye, Scott Haseley, Johannes Henkel, Chromium LUCI CQ, chromium...@chromium.org, lighthouse-eng-extern...@google.com, blink-revie...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org
Attention needed from Johannes Henkel and Scott Haseley
Michal Mocny added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/event-timing/target-selector.html
Line 18, Patchset 2 (Latest):
if ('targetSelector' in entry) {Michal Mocny . unresolved
This patch just updates the previous test, but I'm realizing that we don't require this attribute to pass the test (well, maybe down below we will fail with the matchingElements check...)
I wonder if its better to make this non-optional, but then mark the test as tentative?
Related details
Attention is currently required from:
- Johannes Henkel
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Haseley (Gerrit)
5:21 PM (4 hours ago) 5:21 PM
to Michal Mocny, AyeAye, Johannes Henkel, Chromium LUCI CQ, chromium...@chromium.org, lighthouse-eng-extern...@google.com, blink-revie...@chromium.org, android-web...@chromium.org, ashleynewson+w...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, speed-metrics...@chromium.org
Attention needed from Johannes Henkel and Michal Mocny
Scott Haseley added 1 comment![]( "Open in Gerrit")
File third_party/blink/web_tests/external/wpt/event-timing/target-selector.html
Line 18, Patchset 2 (Latest):
if ('targetSelector' in entry) {Michal Mocny . unresolved
This patch just updates the previous test, but I'm realizing that we don't require this attribute to pass the test (well, maybe down below we will fail with the matchingElements check...)
I wonder if its better to make this non-optional, but then mark the test as tentative?
Scott Haseley
I was going to suggest .tentative last review but forgot -- that might be the way to go for now.
Related details
Attention is currently required from:
- Johannes Henkel
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages