Allow recoverable errors for Direct Sockets UDP [chromium/src : main]

0 views
Skip to first unread message

Andrew Rayskiy (Gerrit)

unread,
Feb 5, 2026, 10:34:04 AMFeb 5
to Simon Hangl, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Simon Hangl

Andrew Rayskiy voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Simon Hangl
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9a4d5f751483cc3e4ebe95245cdc3247d19e033b
Gerrit-Change-Number: 7548069
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Simon Hangl <sim...@google.com>
Gerrit-Attention: Simon Hangl <sim...@google.com>
Gerrit-Comment-Date: Thu, 05 Feb 2026 15:33:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Simon Hangl (Gerrit)

unread,
Feb 5, 2026, 10:37:50 AMFeb 5
to Andrew Rayskiy, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Andrew Rayskiy

Simon Hangl voted and added 1 comment

Votes added by Simon Hangl

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Rayskiy
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9a4d5f751483cc3e4ebe95245cdc3247d19e033b
    Gerrit-Change-Number: 7548069
    Gerrit-PatchSet: 2
    Gerrit-Owner: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Andrew Rayskiy <green...@google.com>
    Gerrit-Comment-Date: Thu, 05 Feb 2026 15:37:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Andrew Rayskiy (Gerrit)

    unread,
    Feb 5, 2026, 11:55:57 AMFeb 5
    to Simon Hangl, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org

    Andrew Rayskiy voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9a4d5f751483cc3e4ebe95245cdc3247d19e033b
    Gerrit-Change-Number: 7548069
    Gerrit-PatchSet: 2
    Gerrit-Owner: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Simon Hangl <sim...@google.com>
    Gerrit-Comment-Date: Thu, 05 Feb 2026 16:55:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 5, 2026, 11:58:44 AMFeb 5
    to Andrew Rayskiy, Simon Hangl, chromium...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Allow recoverable errors for Direct Sockets UDP

    Some prevalent errors in readable/writable UDP streams are seemingly
    easily recoverable; this patch ignores them (while keeping the UMA log)
    instead of aborting the stream.
    Change-Id: I9a4d5f751483cc3e4ebe95245cdc3247d19e033b
    Reviewed-by: Simon Hangl <sim...@google.com>
    Commit-Queue: Andrew Rayskiy <green...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1580169}
    Files:
    • M third_party/blink/renderer/modules/direct_sockets/BUILD.gn
    • A third_party/blink/renderer/modules/direct_sockets/direct_sockets_features.cc
    • A third_party/blink/renderer/modules/direct_sockets/direct_sockets_features.h
    • M third_party/blink/renderer/modules/direct_sockets/udp_readable_stream_wrapper.cc
    • M third_party/blink/renderer/modules/direct_sockets/udp_writable_stream_wrapper.cc
    Change size: M
    Delta: 5 files changed, 46 insertions(+), 4 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Simon Hangl
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9a4d5f751483cc3e4ebe95245cdc3247d19e033b
    Gerrit-Change-Number: 7548069
    Gerrit-PatchSet: 3
    Gerrit-Owner: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Simon Hangl <sim...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages