TaskAttribution: Rename variables and functions [chromium/src : main]

0 views
Skip to first unread message

Guohui Deng (Gerrit)

unread,
Jun 17, 2025, 12:50:59 PM6/17/25
to Chromium LUCI CQ, Scott Haseley, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
Attention needed from Scott Haseley

Guohui Deng added 7 comments

Commit Message
Line 7, Patchset 1:[Refactor TaskAttribution] Rename |parent_task|
Scott Haseley . resolved

nit:

```suggestion
TaskAttribution: Rename |parent_task|
```

Guohui Deng

Done. I heavily edited the commit message due to new changes.

Line 9, Patchset 1:These variables are propogated from parents but they are just task
Scott Haseley . resolved

Please fix this WARNING reported by Spellchecker: "propogated" is a possible misspelling of "propagated".

Analyzer Description: Checks for common typos.
Owner: chops-so...@google.com

"propogated" is a possible misspelling of "propagated".

To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER

Guohui Deng

ditto.

File content/browser/android/app_web_message_port.cc
Line 117, Patchset 1: // set the agent cluster ID to the embedder's, and nullify its parent task ID.
Scott Haseley . resolved

here too.

Guohui Deng

Done

Line 120, Patchset 1: transferable_message.task_id = std::nullopt;
Scott Haseley . resolved

Maybe `task_attribution_id` (or alternatively `task_state_id`)? It would be nice to (fully) get away from the idea that tasks have IDs.

Guohui Deng

Yes and I used `task_state_id` in consistency with "task state".

File content/browser/service_worker/service_worker_object_host.cc
Line 96, Patchset 1: // message's parent task ID.
Scott Haseley . resolved

nit: here too

Guohui Deng

Done

File third_party/blink/renderer/core/messaging/message_port.cc
Line 145, Patchset 1: if (scheduler::TaskAttributionInfo* task = tracker->RunningTask()) {
Scott Haseley . resolved

Maybe rename this one too?

Guohui Deng

Done

File third_party/blink/renderer/core/scheduler/scheduled_action.cc
Line 69, Patchset 1: function_->SetTaskState(tracker->RunningTask());
Scott Haseley . resolved

As a follow-up, I wonder if we should rename this too now? Maybe `CurrentTaskState()` or something would be clearer?

Guohui Deng

Good idea and I appended this CL with this change.

Open in Gerrit

Related details

Attention is currently required from:
  • Scott Haseley
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I19195d44b57e2b135461ecf32c65c253509ed649
Gerrit-Change-Number: 6642605
Gerrit-PatchSet: 1
Gerrit-Owner: Guohui Deng <guohu...@microsoft.com>
Gerrit-Reviewer: Guohui Deng <guohu...@microsoft.com>
Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Scott Haseley <shas...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Jun 2025 16:50:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Scott Haseley <shas...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Scott Haseley (Gerrit)

unread,
Jun 17, 2025, 4:33:21 PM6/17/25
to Guohui Deng, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
Attention needed from Guohui Deng

Scott Haseley voted and added 3 comments

Votes added by Scott Haseley

Code-Review+1

3 comments

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Scott Haseley . resolved

A couple of nits to improve comments, but this is great; thanks!

File third_party/blink/public/mojom/messaging/transferable_message.mojom
Line 40, Patchset 4 (Latest): // The ID in the state of the task initiating the message.
Scott Haseley . unresolved
```suggestion
  // The ID of the task state initiating the message.
```
File third_party/blink/renderer/core/script/pending_script.h
Line 212, Patchset 4 (Latest): // The state of the task that loaded the script.
Scott Haseley . unresolved

Maybe something like:

```suggestion
  // The `TaskAttributionInfo` associated with the task that loaded the script.
```

?

Open in Gerrit

Related details

Attention is currently required from:
  • Guohui Deng
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I19195d44b57e2b135461ecf32c65c253509ed649
    Gerrit-Change-Number: 6642605
    Gerrit-PatchSet: 4
    Gerrit-Owner: Guohui Deng <guohu...@microsoft.com>
    Gerrit-Reviewer: Guohui Deng <guohu...@microsoft.com>
    Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Guohui Deng <guohu...@microsoft.com>
    Gerrit-Comment-Date: Tue, 17 Jun 2025 20:33:11 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Guohui Deng (Gerrit)

    unread,
    Jun 17, 2025, 5:11:28 PM6/17/25
    to Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
    Attention needed from Scott Haseley

    Guohui Deng added 2 comments

    File third_party/blink/public/mojom/messaging/transferable_message.mojom
    Line 40, Patchset 4: // The ID in the state of the task initiating the message.
    Scott Haseley . resolved
    ```suggestion
      // The ID of the task state initiating the message.
    ```
    Guohui Deng

    Done. I was trying to avoid saying the "task state initiating the message". I thought it's better to say "task"(instead of "task state") that "initiates the message". But something like the below is too verbose:

    "The ID of the task state associated with the task initiating the message".

    If you think any alternative is better, I will be happy to modify this CL accordingly.

    File third_party/blink/renderer/core/script/pending_script.h
    Line 212, Patchset 4: // The state of the task that loaded the script.
    Scott Haseley . resolved

    Maybe something like:

    ```suggestion
      // The `TaskAttributionInfo` associated with the task that loaded the script.
    ```

    ?

    Guohui Deng

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Scott Haseley
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I19195d44b57e2b135461ecf32c65c253509ed649
    Gerrit-Change-Number: 6642605
    Gerrit-PatchSet: 5
    Gerrit-Owner: Guohui Deng <guohu...@microsoft.com>
    Gerrit-Reviewer: Guohui Deng <guohu...@microsoft.com>
    Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Scott Haseley <shas...@chromium.org>
    Gerrit-Comment-Date: Tue, 17 Jun 2025 21:11:18 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Scott Haseley (Gerrit)

    unread,
    Jun 17, 2025, 6:53:59 PM6/17/25
    to Guohui Deng, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
    Attention needed from Guohui Deng

    Scott Haseley added 1 comment

    File third_party/blink/public/mojom/messaging/transferable_message.mojom
    Line 40, Patchset 4: // The ID in the state of the task initiating the message.
    Scott Haseley . unresolved
    ```suggestion
      // The ID of the task state initiating the message.
    ```
    Guohui Deng

    Done. I was trying to avoid saying the "task state initiating the message". I thought it's better to say "task"(instead of "task state") that "initiates the message". But something like the below is too verbose:

    "The ID of the task state associated with the task initiating the message".

    If you think any alternative is better, I will be happy to modify this CL accordingly.

    Scott Haseley

    But something like the below is too verbose:

    "The ID of the task state associated with the task initiating the message".

    Actually this SGTM (I think it's clearer); can we use that?

    Alternatively, something like "The TaskAttributionId of the task initiating the message, if any.", if you want to be less verbose?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Guohui Deng
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedNo-Unresolved-Comments
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I19195d44b57e2b135461ecf32c65c253509ed649
      Gerrit-Change-Number: 6642605
      Gerrit-PatchSet: 5
      Gerrit-Owner: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Comment-Date: Tue, 17 Jun 2025 22:53:49 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Scott Haseley <shas...@chromium.org>
      Comment-In-Reply-To: Guohui Deng <guohu...@microsoft.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Guohui Deng (Gerrit)

      unread,
      Jun 18, 2025, 11:27:44 AM6/18/25
      to Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
      Attention needed from Scott Haseley

      Guohui Deng added 1 comment

      File third_party/blink/public/mojom/messaging/transferable_message.mojom
      Line 40, Patchset 4: // The ID in the state of the task initiating the message.
      Scott Haseley . resolved
      ```suggestion
        // The ID of the task state initiating the message.
      ```
      Guohui Deng

      Done. I was trying to avoid saying the "task state initiating the message". I thought it's better to say "task"(instead of "task state") that "initiates the message". But something like the below is too verbose:

      "The ID of the task state associated with the task initiating the message".

      If you think any alternative is better, I will be happy to modify this CL accordingly.

      Scott Haseley

      But something like the below is too verbose:

      "The ID of the task state associated with the task initiating the message".

      Actually this SGTM (I think it's clearer); can we use that?

      Alternatively, something like "The TaskAttributionId of the task initiating the message, if any.", if you want to be less verbose?

      Guohui Deng

      I think "The TaskAttributionId ..." is the best! I used it.
      I will request for more reviewers after you approve this CL.
      Thanks!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Scott Haseley
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I19195d44b57e2b135461ecf32c65c253509ed649
      Gerrit-Change-Number: 6642605
      Gerrit-PatchSet: 6
      Gerrit-Owner: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Scott Haseley <shas...@chromium.org>
      Gerrit-Comment-Date: Wed, 18 Jun 2025 15:27:35 +0000
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Scott Haseley (Gerrit)

      unread,
      Jun 18, 2025, 2:28:02 PM6/18/25
      to Guohui Deng, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
      Attention needed from Guohui Deng

      Scott Haseley voted and added 1 comment

      Votes added by Scott Haseley

      Code-Review+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 6 (Latest):
      Scott Haseley . resolved

      LGTM

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Guohui Deng
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I19195d44b57e2b135461ecf32c65c253509ed649
      Gerrit-Change-Number: 6642605
      Gerrit-PatchSet: 6
      Gerrit-Owner: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Comment-Date: Wed, 18 Jun 2025 18:27:53 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Guohui Deng (Gerrit)

      unread,
      Jun 18, 2025, 5:17:17 PM6/18/25
      to Jinsuk Kim, Ken Buchanan, Yoshisato Yanagisawa, Chromium IPC Reviews, Jeremy Roman, Daniel Cheng, Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
      Attention needed from Chromium IPC Reviews, Daniel Cheng, Jeremy Roman, Jinsuk Kim, Ken Buchanan and Yoshisato Yanagisawa

      Guohui Deng added 1 comment

      Patchset-level comments
      Guohui Deng . resolved

      This CL needs owners' approval. Thanks for reviewing.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Chromium IPC Reviews
      • Daniel Cheng
      • Jeremy Roman
      • Jinsuk Kim
      • Ken Buchanan
      • Yoshisato Yanagisawa
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I19195d44b57e2b135461ecf32c65c253509ed649
      Gerrit-Change-Number: 6642605
      Gerrit-PatchSet: 6
      Gerrit-Owner: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
      Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
      Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
      Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
      Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-Attention: Yoshisato Yanagisawa <yyana...@chromium.org>
      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
      Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
      Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-Attention: Jinsuk Kim <jins...@chromium.org>
      Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
      Gerrit-Comment-Date: Wed, 18 Jun 2025 21:17:08 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      gwsq (Gerrit)

      unread,
      Jun 18, 2025, 5:19:06 PM6/18/25
      to Guohui Deng, Chromium IPC Reviews, Jinsuk Kim, Ken Buchanan, Yoshisato Yanagisawa, Jeremy Roman, Daniel Cheng, Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
      Attention needed from Daniel Cheng, Jeremy Roman, Jinsuk Kim, Ken Buchanan and Yoshisato Yanagisawa

      Message from gwsq

      From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
      IPC: dch...@chromium.org, ke...@chromium.org

      📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

      IPC reviewer(s): dch...@chromium.org, ke...@chromium.org

      Note: IPC gwsq added no new reviewers; existing reviewers satisfied requirements!

      Reviewer source(s):
      dch...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Daniel Cheng
      • Jeremy Roman
      • Jinsuk Kim
      • Ken Buchanan
      • Yoshisato Yanagisawa
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I19195d44b57e2b135461ecf32c65c253509ed649
      Gerrit-Change-Number: 6642605
      Gerrit-PatchSet: 6
      Gerrit-Owner: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
      Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
      Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
      Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
      Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Yoshisato Yanagisawa <yyana...@chromium.org>
      Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
      Gerrit-Attention: Jeremy Roman <jbr...@chromium.org>
      Gerrit-Attention: Jinsuk Kim <jins...@chromium.org>
      Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
      Gerrit-Comment-Date: Wed, 18 Jun 2025 21:18:59 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Jeremy Roman (Gerrit)

      unread,
      Jun 18, 2025, 6:32:06 PM6/18/25
      to Guohui Deng, Chromium IPC Reviews, Jinsuk Kim, Ken Buchanan, Yoshisato Yanagisawa, Jeremy Roman, Daniel Cheng, Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
      Attention needed from Daniel Cheng, Guohui Deng, Jinsuk Kim, Ken Buchanan and Yoshisato Yanagisawa

      Jeremy Roman added 1 comment

      Patchset-level comments
      Jeremy Roman . resolved

      third_party/blink/public/common/messaging/transferable_message.h lgtm

      You didn't specify which files I was to review, so if there are any others that need my attention, let me know.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Daniel Cheng
      • Guohui Deng
      Gerrit-Attention: Jinsuk Kim <jins...@chromium.org>
      Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
      Gerrit-Attention: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Comment-Date: Wed, 18 Jun 2025 22:32:00 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Jeremy Roman (Gerrit)

      unread,
      Jun 18, 2025, 6:32:12 PM6/18/25
      to Guohui Deng, Jeremy Roman, Chromium IPC Reviews, Jinsuk Kim, Ken Buchanan, Yoshisato Yanagisawa, Daniel Cheng, Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
      Attention needed from Daniel Cheng, Guohui Deng, Jinsuk Kim, Ken Buchanan and Yoshisato Yanagisawa

      Jeremy Roman voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Daniel Cheng
      • Guohui Deng
      • Jinsuk Kim
      • Ken Buchanan
      • Yoshisato Yanagisawa
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      Gerrit-Comment-Date: Wed, 18 Jun 2025 22:32:05 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Daniel Cheng (Gerrit)

      unread,
      Jun 18, 2025, 7:56:57 PM6/18/25
      to Guohui Deng, Daniel Cheng, Jeremy Roman, Chromium IPC Reviews, Jinsuk Kim, Ken Buchanan, Yoshisato Yanagisawa, Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
      Attention needed from Guohui Deng, Jinsuk Kim, Ken Buchanan and Yoshisato Yanagisawa

      Daniel Cheng voted and added 1 comment

      Votes added by Daniel Cheng

      Code-Review+1

      1 comment

      Patchset-level comments
      Daniel Cheng . resolved

      LGTM

      Open in Gerrit

      Related details

      Attention is currently required from:
      Gerrit-Attention: Jinsuk Kim <jins...@chromium.org>
      Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
      Gerrit-Attention: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Comment-Date: Wed, 18 Jun 2025 23:56:50 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Jinsuk Kim (Gerrit)

      unread,
      Jun 19, 2025, 8:54:24 AM6/19/25
      to Guohui Deng, Daniel Cheng, Jeremy Roman, Chromium IPC Reviews, Ken Buchanan, Yoshisato Yanagisawa, Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
      Attention needed from Guohui Deng, Ken Buchanan and Yoshisato Yanagisawa

      Jinsuk Kim voted and added 1 comment

      Votes added by Jinsuk Kim

      Code-Review+1

      1 comment

      Patchset-level comments
      Jinsuk Kim . resolved

      content/../android lgtm

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Guohui Deng
      • Ken Buchanan
      • Yoshisato Yanagisawa
      Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
      Gerrit-Attention: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Comment-Date: Thu, 19 Jun 2025 12:54:15 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Guohui Deng (Gerrit)

      unread,
      Jun 19, 2025, 12:12:57 PM6/19/25
      to Jonathan Ross, Ben Kelly, Jinsuk Kim, Daniel Cheng, Jeremy Roman, Chromium IPC Reviews, Ken Buchanan, Yoshisato Yanagisawa, Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
      Attention needed from Ben Kelly, Jonathan Ross, Ken Buchanan and Yoshisato Yanagisawa

      Guohui Deng added 1 comment

      Patchset-level comments
      Guohui Deng . resolved

      Sorry I didn't specify exactly what files need owner review from who. There are still a few needs owner approval.

      @ke...@chromium.org and @jon...@chromium.org: Would either of you owner review `render_frame_host_impl.cc`?

      @wande...@meta.com and @yyana...@chromium.org: Would either of you owner review `content/browser/service_worker/`?

      Thanks a lot.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Ben Kelly
      • Jonathan Ross
      • Ken Buchanan
      • Yoshisato Yanagisawa
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I19195d44b57e2b135461ecf32c65c253509ed649
      Gerrit-Change-Number: 6642605
      Gerrit-PatchSet: 6
      Gerrit-Owner: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Ben Kelly <wande...@meta.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
      Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
      Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
      Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
      Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
      Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Yoshisato Yanagisawa <yyana...@chromium.org>
      Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
      Gerrit-Attention: Jonathan Ross <jon...@chromium.org>
      Gerrit-Attention: Ben Kelly <wande...@meta.com>
      Gerrit-Comment-Date: Thu, 19 Jun 2025 16:12:44 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy

      Jonathan Ross (Gerrit)

      unread,
      Jun 19, 2025, 4:57:46 PM6/19/25
      to Guohui Deng, Ben Kelly, Jinsuk Kim, Daniel Cheng, Jeremy Roman, Chromium IPC Reviews, Ken Buchanan, Yoshisato Yanagisawa, Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
      Attention needed from Ben Kelly, Guohui Deng, Ken Buchanan and Yoshisato Yanagisawa

      Jonathan Ross voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Ben Kelly
      • Guohui Deng
      • Ken Buchanan
      • Yoshisato Yanagisawa
      Gerrit-Attention: Ben Kelly <wande...@meta.com>
      Gerrit-Attention: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Comment-Date: Thu, 19 Jun 2025 20:57:38 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Yoshisato Yanagisawa (Gerrit)

      unread,
      Jun 20, 2025, 6:23:10 AM6/20/25
      to Guohui Deng, Jonathan Ross, Ben Kelly, Jinsuk Kim, Daniel Cheng, Jeremy Roman, Chromium IPC Reviews, Ken Buchanan, Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
      Attention needed from Ben Kelly, Guohui Deng and Ken Buchanan

      Yoshisato Yanagisawa voted and added 1 comment

      Votes added by Yoshisato Yanagisawa

      Code-Review+1

      1 comment

      Patchset-level comments
      Yoshisato Yanagisawa . resolved

      SW lgtm.
      It actually set std::nullopt, and does not track.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Ben Kelly
      • Guohui Deng
      • Ken Buchanan
      Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
      Gerrit-Attention: Ben Kelly <wande...@meta.com>
      Gerrit-Attention: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Comment-Date: Fri, 20 Jun 2025 10:22:37 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Ben Kelly (Gerrit)

      unread,
      Jun 20, 2025, 9:15:53 AM6/20/25
      to Guohui Deng, Yoshisato Yanagisawa, Jonathan Ross, Jinsuk Kim, Daniel Cheng, Jeremy Roman, Chromium IPC Reviews, Ken Buchanan, Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
      Attention needed from Guohui Deng and Ken Buchanan

      Ben Kelly voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Guohui Deng
      • Ken Buchanan
      Gerrit-Attention: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Comment-Date: Fri, 20 Jun 2025 13:15:44 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Ken Buchanan (Gerrit)

      unread,
      Jun 20, 2025, 9:16:14 AM6/20/25
      to Guohui Deng, Ben Kelly, Yoshisato Yanagisawa, Jonathan Ross, Jinsuk Kim, Daniel Cheng, Jeremy Roman, Chromium IPC Reviews, Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org
      Attention needed from Guohui Deng

      Ken Buchanan added 1 comment

      Patchset-level comments
      Ken Buchanan . resolved

      My review isn't needed.

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Guohui Deng
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I19195d44b57e2b135461ecf32c65c253509ed649
      Gerrit-Change-Number: 6642605
      Gerrit-PatchSet: 6
      Gerrit-Owner: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Ben Kelly <wande...@meta.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
      Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
      Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
      Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
      Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: Kentaro Hara <har...@chromium.org>
      Gerrit-CC: Nate Chapin <jap...@chromium.org>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
      Gerrit-CC: gwsq
      Gerrit-Attention: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Comment-Date: Fri, 20 Jun 2025 13:16:04 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy

      Guohui Deng (Gerrit)

      unread,
      Jun 20, 2025, 11:16:23 AM6/20/25
      to Ben Kelly, Yoshisato Yanagisawa, Jonathan Ross, Jinsuk Kim, Daniel Cheng, Jeremy Roman, Chromium IPC Reviews, Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org

      Guohui Deng voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Gerrit-Comment-Date: Fri, 20 Jun 2025 15:16:10 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Guohui Deng (Gerrit)

      unread,
      Jun 20, 2025, 11:16:44 AM6/20/25
      to Ben Kelly, Yoshisato Yanagisawa, Jonathan Ross, Jinsuk Kim, Daniel Cheng, Jeremy Roman, Chromium IPC Reviews, Scott Haseley, Nate Chapin, AyeAye, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org

      Guohui Deng added 1 comment

      Patchset-level comments
      Guohui Deng . resolved

      Thanks!

      Gerrit-Comment-Date: Fri, 20 Jun 2025 15:16:31 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jun 20, 2025, 12:13:02 PM6/20/25
      to Guohui Deng, Ben Kelly, Yoshisato Yanagisawa, Jonathan Ross, Jinsuk Kim, Daniel Cheng, Jeremy Roman, Chromium IPC Reviews, Scott Haseley, Nate Chapin, AyeAye, Alexis Menard, chromium...@chromium.org, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Hiroki Nakagawa, scheduler-...@chromium.org, core-timi...@chromium.org, gavinp...@chromium.org, speed-metrics...@chromium.org, chikamu...@chromium.org, loading...@chromium.org, alexmo...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, creis...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, web-schedulin...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      TaskAttribution: Rename variables and functions

      "parent task" --> "task state"; "task id" --> "task state id";
      "RunningTask" --> "CurrentTaskState"

      The reasons are: 1) An instance of TaskAttributionInfo is a task state;
      2) A "task id" is just part of a "task state" and we are moving away
      from the concept of "task id"; 3) TaskAttributionTracker returns the
      state of the task, not the task itself.

      No behavior change is expected to result from this CL.
      Bug: 423956115
      Change-Id: I19195d44b57e2b135461ecf32c65c253509ed649
      Reviewed-by: Jinsuk Kim <jins...@chromium.org>
      Reviewed-by: Yoshisato Yanagisawa <yyana...@chromium.org>
      Reviewed-by: Ben Kelly <wande...@meta.com>
      Commit-Queue: Guohui Deng <guohu...@microsoft.com>
      Reviewed-by: Jeremy Roman <jbr...@chromium.org>
      Reviewed-by: Jonathan Ross <jon...@chromium.org>
      Reviewed-by: Daniel Cheng <dch...@chromium.org>
      Reviewed-by: Scott Haseley <shas...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1476550}
      Files:
      • M content/browser/android/app_web_message_port.cc
      • M content/browser/renderer_host/render_frame_host_impl.cc
      • M content/browser/service_worker/service_worker_container_host.cc
      • M content/browser/service_worker/service_worker_context_wrapper.cc
      • M content/browser/service_worker/service_worker_object_host.cc
      • M content/browser/service_worker/service_worker_version.cc
      • M third_party/blink/common/messaging/transferable_message_mojom_traits.cc
      • M third_party/blink/public/common/messaging/transferable_message.h
      • M third_party/blink/public/common/messaging/transferable_message_mojom_traits.h
      • M third_party/blink/public/mojom/messaging/transferable_message.mojom
      • M third_party/blink/renderer/bindings/core/v8/callback_invoke_helper.cc
      • M third_party/blink/renderer/core/frame/local_dom_window.cc
      • M third_party/blink/renderer/core/frame/local_dom_window.h
      • M third_party/blink/renderer/core/loader/document_loader.cc
      • M third_party/blink/renderer/core/messaging/blink_transferable_message.cc
      • M third_party/blink/renderer/core/messaging/blink_transferable_message.h
      • M third_party/blink/renderer/core/messaging/blink_transferable_message_mojom_traits.h
      • M third_party/blink/renderer/core/messaging/message_port.cc
      • M third_party/blink/renderer/core/scheduler/dom_scheduler.cc
      • M third_party/blink/renderer/core/scheduler/dom_task.cc
      • M third_party/blink/renderer/core/scheduler/dom_task.h
      • M third_party/blink/renderer/core/scheduler/scheduled_action.cc
      • M third_party/blink/renderer/core/scheduler/scheduled_action.h
      • M third_party/blink/renderer/core/scheduler/task_attribution_tracker_impl.cc
      • M third_party/blink/renderer/core/scheduler/task_attribution_tracker_impl.h
      • M third_party/blink/renderer/core/scheduler/window_idle_tasks.cc
      • M third_party/blink/renderer/core/script/classic_pending_script.cc
      • M third_party/blink/renderer/core/script/classic_pending_script.h
      • M third_party/blink/renderer/core/script/module_pending_script.cc
      • M third_party/blink/renderer/core/script/module_pending_script.h
      • M third_party/blink/renderer/core/script/pending_script.cc
      • M third_party/blink/renderer/core/script/pending_script.h
      • M third_party/blink/renderer/core/script/script_loader.cc
      • M third_party/blink/renderer/core/script/script_runner_test.cc
      • M third_party/blink/renderer/core/timing/soft_navigation_heuristics.cc
      • M third_party/blink/renderer/core/timing/soft_navigation_heuristics_test.cc
      • M third_party/blink/renderer/core/view_transition/view_transition_supplement.cc
      • M third_party/blink/renderer/core/xmlhttprequest/xml_http_request.cc
      • M third_party/blink/renderer/core/xmlhttprequest/xml_http_request.h
      • M third_party/blink/renderer/platform/bindings/callback_function_base.cc
      • M third_party/blink/renderer/platform/bindings/callback_function_base.h
      • M third_party/blink/renderer/platform/scheduler/public/task_attribution_tracker.h
      • M third_party/blink/tools/blinkpy/presubmit/audit_non_blink_usage.py
      Change size: L
      Delta: 43 files changed, 139 insertions(+), 130 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Jeremy Roman, +1 by Daniel Cheng, +1 by Jinsuk Kim, +1 by Yoshisato Yanagisawa, +1 by Jonathan Ross, +1 by Scott Haseley, +1 by Ben Kelly
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I19195d44b57e2b135461ecf32c65c253509ed649
      Gerrit-Change-Number: 6642605
      Gerrit-PatchSet: 7
      Gerrit-Owner: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Ben Kelly <wande...@meta.com>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: Guohui Deng <guohu...@microsoft.com>
      Gerrit-Reviewer: Jeremy Roman <jbr...@chromium.org>
      Gerrit-Reviewer: Jinsuk Kim <jins...@chromium.org>
      Gerrit-Reviewer: Jonathan Ross <jon...@chromium.org>
      Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
      Gerrit-Reviewer: Yoshisato Yanagisawa <yyana...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages