feature flag for multicast direct sockets [chromium/src : main]

0 views
Skip to first unread message

Vlad Krot (Gerrit)

unread,
Aug 27, 2025, 11:15:08 AM8/27/25
to Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, pwa-com...@google.com, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Vlad Krot voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id8ff9a1f7b16347b6d87cb6d1684569da2d4c357
Gerrit-Change-Number: 6890773
Gerrit-PatchSet: 3
Gerrit-Owner: Vlad Krot <vk...@google.com>
Gerrit-Reviewer: Vlad Krot <vk...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Comment-Date: Wed, 27 Aug 2025 15:14:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dominik Bylica (Gerrit)

unread,
Aug 27, 2025, 11:24:13 AM8/27/25
to Vlad Krot, Andrew Rayskiy, Dmitry Gozman, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, pwa-com...@google.com, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Andrew Rayskiy, Dmitry Gozman and Vlad Krot

Dominik Bylica voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Rayskiy
  • Dmitry Gozman
  • Vlad Krot
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id8ff9a1f7b16347b6d87cb6d1684569da2d4c357
    Gerrit-Change-Number: 6890773
    Gerrit-PatchSet: 3
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Reviewer: Dominik Bylica <byl...@google.com>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Vlad Krot <vk...@google.com>
    Gerrit-Attention: Andrew Rayskiy <green...@google.com>
    Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Comment-Date: Wed, 27 Aug 2025 15:23:58 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Rayskiy (Gerrit)

    unread,
    Aug 27, 2025, 11:33:41 AM8/27/25
    to Vlad Krot, Dominik Bylica, Dmitry Gozman, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, pwa-com...@google.com, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Dmitry Gozman and Vlad Krot

    Andrew Rayskiy voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dmitry Gozman
    • Vlad Krot
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id8ff9a1f7b16347b6d87cb6d1684569da2d4c357
    Gerrit-Change-Number: 6890773
    Gerrit-PatchSet: 3
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Reviewer: Dominik Bylica <byl...@google.com>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Vlad Krot <vk...@google.com>
    Gerrit-Attention: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Comment-Date: Wed, 27 Aug 2025 15:33:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dmitry Gozman (Gerrit)

    unread,
    Aug 28, 2025, 5:38:52 AM8/28/25
    to Vlad Krot, Andrew Rayskiy, Dominik Bylica, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, pwa-com...@google.com, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
    Attention needed from Vlad Krot

    Dmitry Gozman voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vlad Krot
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id8ff9a1f7b16347b6d87cb6d1684569da2d4c357
    Gerrit-Change-Number: 6890773
    Gerrit-PatchSet: 5
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Reviewer: Dominik Bylica <byl...@google.com>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Vlad Krot <vk...@google.com>
    Gerrit-Comment-Date: Thu, 28 Aug 2025 09:38:36 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Vlad Krot (Gerrit)

    unread,
    Aug 28, 2025, 7:50:54 AM8/28/25
    to Dmitry Gozman, Andrew Rayskiy, Dominik Bylica, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, pwa-com...@google.com, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Vlad Krot voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id8ff9a1f7b16347b6d87cb6d1684569da2d4c357
    Gerrit-Change-Number: 6890773
    Gerrit-PatchSet: 6
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Reviewer: Dominik Bylica <byl...@google.com>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Thu, 28 Aug 2025 11:50:38 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Aug 28, 2025, 8:07:30 AM8/28/25
    to Vlad Krot, Dmitry Gozman, Andrew Rayskiy, Dominik Bylica, Chromium Metrics Reviews, chromium...@chromium.org, pwa-com...@google.com, asvitki...@chromium.org, asvitkine...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    5 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: chrome/browser/flag_descriptions.cc
    Insertions: 8, Deletions: 8.

    @@ -2703,6 +2703,14 @@
         "(i.e., have the same title and the same hostname) of another tile with "
         "higher score.";
     
    +#if !BUILDFLAG(IS_ANDROID)
    +const char kMulticastInDirectSocketsName[] = "Multicast in Direct Sockets API";
    +const char kMulticastInDirectSocketsDescription[] =
    +    "Enables access Multicast in Direct Sockets API. See "
    +    "https://github.com/explainers-by-googlers/multicast-in-direct-sockets for "
    +    "details.";
    +#endif  // !BUILDFLAG(IS_ANDROID)
    +
     const char kCanvas2DLayersName[] =
         "Enables canvas 2D methods BeginLayer and EndLayer";
     const char kCanvas2DLayersDescription[] =
    @@ -7418,14 +7426,6 @@
         "Enables the Quick Settings Calendar to display Google Calendar events for "
         "up to 10 of the user's calendars.";
     
    -#if !BUILDFLAG(IS_ANDROID)
    -const char kMulticastInDirectSocketsName[] = "Multicast in Direct Sockets API";
    -const char kMulticastInDirectSocketsDescription[] =
    -    "Enables access Multicast in Direct Sockets API. See "
    -    "https://github.com/explainers-by-googlers/multicast-in-direct-sockets for "
    -    "details.";
    -#endif  // !BUILDFLAG(IS_ANDROID)
    -
     #if BUILDFLAG(IS_CHROMEOS)
     const char kMultiCaptureUsageIndicatorUpdateName[] =
         "Use reworked multi capture usage indicators";
    ```
    ```
    The name of the file: chrome/browser/flag_descriptions.h
    Insertions: 5, Deletions: 5.

    @@ -1579,6 +1579,11 @@
     extern const char kMostVisitedTilesVisualDeduplicationName[];
     extern const char kMostVisitedTilesVisualDeduplicationDescription[];
     
    +#if !BUILDFLAG(IS_ANDROID)
    +extern const char kMulticastInDirectSocketsName[];
    +extern const char kMulticastInDirectSocketsDescription[];
    +#endif  // !BUILDFLAG(IS_ANDROID)
    +
     extern const char kCanvas2DLayersName[];
     extern const char kCanvas2DLayersDescription[];
     
    @@ -4273,11 +4278,6 @@
     extern const char kMultiCalendarSupportName[];
     extern const char kMultiCalendarSupportDescription[];
     
    -#if !BUILDFLAG(IS_ANDROID)
    -extern const char kMulticastInDirectSocketsName[];
    -extern const char kMulticastInDirectSocketsDescription[];
    -#endif  // !BUILDFLAG(IS_ANDROID)
    -
     extern const char kMultiCaptureUsageIndicatorUpdateName[];
     extern const char kMultiCaptureUsageIndicatorUpdateDescription[];
     
    ```

    Change information

    Commit message:
    feature flag for multicast direct sockets

    Runtime blink flag is added to runtime_enabled_features.json5 and to
    chrome://flags For more info on what is a multicast
    https://github.com/explainers-by-googlers/Multicast-in-Direct-Sockets

    Intent to prototype:
    https://groups.google.com/a/chromium.org/g/blink-dev/c/ADV4FZtN4nE
    Change-Id: Id8ff9a1f7b16347b6d87cb6d1684569da2d4c357
    Bug: 398934282
    Reviewed-by: Dominik Bylica <byl...@google.com>
    Reviewed-by: Andrew Rayskiy <green...@google.com>
    Reviewed-by: Dmitry Gozman <dgo...@chromium.org>
    Commit-Queue: Vlad Krot <vk...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1507662}
    Files:
    • M chrome/browser/about_flags.cc
    • M chrome/browser/flag-metadata.json
    • M chrome/browser/flag_descriptions.cc
    • M chrome/browser/flag_descriptions.h
    • M third_party/blink/renderer/platform/runtime_enabled_features.json5
    • M tools/metrics/histograms/enums.xml
    Change size: S
    Delta: 6 files changed, 33 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Andrew Rayskiy, +1 by Dmitry Gozman, +1 by Dominik Bylica
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id8ff9a1f7b16347b6d87cb6d1684569da2d4c357
    Gerrit-Change-Number: 6890773
    Gerrit-PatchSet: 7
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dmitry Gozman <dgo...@chromium.org>
    Gerrit-Reviewer: Dominik Bylica <byl...@google.com>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages