[FedCM] Remove traces of revoke [chromium/src : main]
Christian Biesinger (Gerrit)
Attention is currently required from: Zachary Tan.
Christian Biesinger would like Zachary Tan to review this change.
[FedCM] Remove traces of revoke
Now that revoke has been removed in https://crrev.com/c/3712167,
this removes the final few traces.
R=tanza...@chromium.org
Bug: 1335232
Change-Id: I5e4e18ce358c8d68003fdc65b7d71cb98b83d5df
---
M third_party/blink/web_tests/external/wpt/credential-management/support/fedcm-manifest-not-in-list/fedcm.json
D third_party/blink/web_tests/external/wpt/credential-management/support/revoke.py
2 files changed, 15 insertions(+), 7 deletions(-)
diff --git a/third_party/blink/web_tests/external/wpt/credential-management/support/fedcm-manifest-not-in-list/fedcm.json b/third_party/blink/web_tests/external/wpt/credential-management/support/fedcm-manifest-not-in-list/fedcm.json
index 9d919790..c044a7f 100644
--- a/third_party/blink/web_tests/external/wpt/credential-management/support/fedcm-manifest-not-in-list/fedcm.json
+++ b/third_party/blink/web_tests/external/wpt/credential-management/support/fedcm-manifest-not-in-list/fedcm.json
@@ -2,5 +2,4 @@
"accounts_endpoint": "../accounts.py",
"client_metadata_endpoint": "../client_metadata.py",
"id_token_endpoint": "../id_token.py",
- "revocation_endpoint": "../revoke.py"
}
diff --git a/third_party/blink/web_tests/external/wpt/credential-management/support/revoke.py b/third_party/blink/web_tests/external/wpt/credential-management/support/revoke.py
deleted file mode 100644
index ed6fe00d..0000000
--- a/third_party/blink/web_tests/external/wpt/credential-management/support/revoke.py
+++ /dev/null
@@ -1,6 +0,0 @@
-def main(request, response):
- if not b"hint" in request.POST:
- return (500, [], "Missing hint")
- if request.POST[b"hint"] == b"fail":
- return (500, [], "Fail requested")
- return (204, [], "")
To view, visit change 3727309. To unsubscribe, or for help writing mail filters, visit settings.
Blink W3C Test Autoroller (Gerrit)
Attention is currently required from: Zachary Tan.
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/34611.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Zachary Tan (Gerrit)
Attention is currently required from: Christian Biesinger.
1 comment:
Patchset:
Thanks!
To view, visit change 3727309. To unsubscribe, or for help writing mail filters, visit settings.
Christian Biesinger (Gerrit)
Attention is currently required from: Yi Gu.
Christian Biesinger would like Yi Gu to review this change.
To view, visit change 3727309. To unsubscribe, or for help writing mail filters, visit settings.
Christian Biesinger (Gerrit)
Attention is currently required from: Yi Gu.
1 comment:
Patchset:
Can you mark code-review +1, Zach?
Adding Yi in case you can't
To view, visit change 3727309. To unsubscribe, or for help writing mail filters, visit settings.
Zachary Tan (Gerrit)
Attention is currently required from: Christian Biesinger, Yi Gu.
1 comment:
Patchset:
Can you mark code-review +1, Zach? […]
Sadly I can't :(
To view, visit change 3727309. To unsubscribe, or for help writing mail filters, visit settings.
Yi Gu (Gerrit)
Attention is currently required from: Christian Biesinger.
Patch set 1:Code-Review +1
1 comment:
Patchset:
I think only committers can CR+1. Zack feel free to write down LGTM 😊
To view, visit change 3727309. To unsubscribe, or for help writing mail filters, visit settings.
Zachary Tan (Gerrit)
Attention is currently required from: Christian Biesinger.
1 comment:
Patchset:
LGTM 😄
To view, visit change 3727309. To unsubscribe, or for help writing mail filters, visit settings.
Christian Biesinger (Gerrit)
Attention is currently required from: Christian Biesinger.
Patch set 1:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
[FedCM] Remove traces of revoke
Now that revoke has been removed in https://crrev.com/c/3712167,
this removes the final few traces.
R=tanza...@chromium.org
Bug: 1335232
Change-Id: I5e4e18ce358c8d68003fdc65b7d71cb98b83d5df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3727309
Reviewed-by: Yi Gu <yi...@chromium.org>
Commit-Queue: Christian Biesinger <cbies...@chromium.org>
Auto-Submit: Christian Biesinger <cbies...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1018408}
---
M third_party/blink/web_tests/external/wpt/credential-management/support/fedcm-manifest-not-in-list/fedcm.json
D third_party/blink/web_tests/external/wpt/credential-management/support/revoke.py
2 files changed, 20 insertions(+), 7 deletions(-)
diff --git a/third_party/blink/web_tests/external/wpt/credential-management/support/fedcm-manifest-not-in-list/fedcm.json b/third_party/blink/web_tests/external/wpt/credential-management/support/fedcm-manifest-not-in-list/fedcm.json
index 9d919790..c044a7f 100644
--- a/third_party/blink/web_tests/external/wpt/credential-management/support/fedcm-manifest-not-in-list/fedcm.json
+++ b/third_party/blink/web_tests/external/wpt/credential-management/support/fedcm-manifest-not-in-list/fedcm.json
@@ -2,5 +2,4 @@
"accounts_endpoint": "../accounts.py",
"client_metadata_endpoint": "../client_metadata.py",
"id_token_endpoint": "../id_token.py",
- "revocation_endpoint": "../revoke.py"
}
diff --git a/third_party/blink/web_tests/external/wpt/credential-management/support/revoke.py b/third_party/blink/web_tests/external/wpt/credential-management/support/revoke.py
deleted file mode 100644
index ed6fe00d..0000000
--- a/third_party/blink/web_tests/external/wpt/credential-management/support/revoke.py
+++ /dev/null
@@ -1,6 +0,0 @@
-def main(request, response):
- if not b"hint" in request.POST:
- return (500, [], "Missing hint")
- if request.POST[b"hint"] == b"fail":
- return (500, [], "Fail requested")
- return (204, [], "")
To view, visit change 3727309. To unsubscribe, or for help writing mail filters, visit settings.
Blink W3C Test Autoroller (Gerrit)
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/34611