[M144] Disable H.264 SEI recovery points as keyframes [chromium/src : refs/branch-heads/7559]
0 views
Skip to first unread message
Dale Curtis (Gerrit)
Dec 18, 2025, 1:56:50 PM (2 days ago) Dec 18
to Nathan Hebert, AyeAye, feature-me...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Nathan Hebert
Dale Curtis voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Nathan Hebert
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nathan Hebert (Gerrit)
Dec 18, 2025, 1:59:28 PM (2 days ago) Dec 18
to Dale Curtis, AyeAye, feature-me...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Nathan Hebert voted and added 1 comment![]( "Open in Gerrit")
Votes added by Nathan Hebert
| Commit-Queue | +2 |
1 comment
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Nathan Hebert . resolved
Thanks for the quick review, Dale.
Re Lint-1, b/464062740 has merge approval for the M144. I don't know what the linter is confused about. I'll see if I can CQ+2 with Lint-1.
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nathan Hebert (Gerrit)
Dec 18, 2025, 2:05:54 PM (2 days ago) Dec 18
to Alon Bajayo, Chromium LUCI CQ, Dale Curtis, AyeAye, feature-me...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Nathan Hebert added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Nathan Hebert . resolved
CC-ing Alon. Is there something that I need to do for the merge approval linter's approval. Sorry for making more work for you.
FWIW, I just filed a ticket for the linter: b/470095989
Related details
Attention set is empty
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nathan Hebert (Gerrit)
Dec 18, 2025, 6:16:36 PM (2 days ago) Dec 18
to Srinivas Sista, Alon Bajayo, Chromium LUCI CQ, Dale Curtis, AyeAye, feature-me...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Srinivas Sista
Nathan Hebert added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Nathan Hebert . resolved
I chatted with Alon and he mentioned that this is a known issue. Thanks!
Adding srinivassista@ as a reviewer for overriding the lint failure. This has been approved for M144 in b/issues/464062740#comment69
Related details
Attention is currently required from:
- Srinivas Sista
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alon Bajayo (Gerrit)
Dec 18, 2025, 6:21:37 PM (2 days ago) Dec 18
to Nathan Hebert, Srinivas Sista, Chromium LUCI CQ, Dale Curtis, AyeAye, feature-me...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Nathan Hebert and Srinivas Sista
Alon Bajayo voted Commit-Queue+2![]( "Open in Gerrit")
Attention is currently required from:
- Nathan Hebert
- Srinivas Sista
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nathan Hebert (Gerrit)
Dec 18, 2025, 6:41:37 PM (2 days ago) Dec 18
to Alon Bajayo, Srinivas Sista, Chromium LUCI CQ, Dale Curtis, AyeAye, feature-me...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Attention needed from Alon Bajayo and Srinivas Sista
Nathan Hebert voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention is currently required from:
- Alon Bajayo
- Srinivas Sista
Submit Requirements:
Code-Owners
Code-Review
Lint
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 18, 2025, 8:27:36 PM (2 days ago) Dec 18
to Nathan Hebert, Alon Bajayo, Srinivas Sista, Dale Curtis, AyeAye, feature-me...@chromium.org, blink-...@chromium.org, blink-revie...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[M144] Disable H.264 SEI recovery points as keyframes
The additional SEI parsing seems to break the parser state during
Netflix playback. For now, stop doing that SEI parsing until we can
figure out what is going on with the parser.
Also, adds webcodecs tests expectations for SEI recovery point tests.
These can be deleted when the underlying fix is made.
(cherry picked from commit b2b2d458cda3fa931f12a06673d1cf3649f19c54)
Merge-Approval-Bypass=Approved through ChromeOS process, not Chrome
Bug: 464062740
Change-Id: I29ce5fa66f2ac6547c1a7f3bbd049e9a62fc8b31
Reviewed-by: Dale Curtis <dalec...@chromium.org>
Commit-Queue: Nathan Hebert <nhe...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1557832}
Cr-Commit-Position: refs/branch-heads/7559@{#1629}
Cr-Branched-From: 223dfbac1c7542a06b422390d954afe5b560b607-refs/heads/main@{#1552494}
Files:
- M media/base/media_switches.cc
- A third_party/blink/web_tests/external/wpt/webcodecs/videoDecoder-h264-sei.https.any.worker_h264_sei_annexb-expected.txt
- A third_party/blink/web_tests/external/wpt/webcodecs/videoDecoder-h264-sei.https.any.worker_h264_sei_avc-expected.txt
- A third_party/blink/web_tests/external/wpt/webcodecs/videoDecoder-h264-sei.https.any_h264_sei_annexb-expected.txt
- A third_party/blink/web_tests/external/wpt/webcodecs/videoDecoder-h264-sei.https.any_h264_sei_avc-expected.txt
Change size: S
Delta: 5 files changed, 21 insertions(+), 1 deletion(-)
Branch: refs/branch-heads/7559
Submit Requirements:
Code-Review: +1 by Dale Curtis
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages