Multicast support in Direct Sockets #2 [chromium/src : main]

0 views
Skip to first unread message

Vlad Krot (Gerrit)

unread,
Sep 2, 2025, 9:25:25 AM9/2/25
to Andrew Rayskiy, AI Code Reviewer, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Simon Hangl, pwa-com...@google.com, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
Attention needed from Andrew Rayskiy

Vlad Krot added 1 comment

File third_party/blink/renderer/modules/direct_sockets/multicast_controller.h
Line 80, Patchset 1: std::optional<net::IPAddress> CreateAndCheckIpAddress(
AI Code Reviewer . resolved

nit: The parameter names `ip_address` and `exception_state` can be omitted from the function declaration in the header file, as their purpose is clear from the types and the function name. Please specify them in the implementation file instead. (Blink Style Guide: Naming - May leave obvious parameter names out of function declarations)
***

_To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options: \
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason \
 \
This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent). \
AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve. \
[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_
Vlad Krot

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Rayskiy
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ibcd0d6e38cd6963c256428fc1ccc03e16827004c
Gerrit-Change-Number: 6897672
Gerrit-PatchSet: 8
Gerrit-Owner: Vlad Krot <vk...@google.com>
Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
Gerrit-Reviewer: Vlad Krot <vk...@google.com>
Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-Attention: Andrew Rayskiy <green...@google.com>
Gerrit-Comment-Date: Tue, 02 Sep 2025 13:25:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Rayskiy (Gerrit)

unread,
Sep 2, 2025, 9:36:01 AM9/2/25
to Vlad Krot, AI Code Reviewer, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Simon Hangl, pwa-com...@google.com, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
Attention needed from Vlad Krot

Andrew Rayskiy voted and added 1 comment

Votes added by Andrew Rayskiy

Code-Review+1

1 comment

File content/test/data/direct_sockets/udp.js
Line 1, Patchset 8 (Latest):// Copyright 2022 The Chromium Authors
Andrew Rayskiy . unresolved

I believe we don't add copyright to test data?

Open in Gerrit

Related details

Attention is currently required from:
  • Vlad Krot
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibcd0d6e38cd6963c256428fc1ccc03e16827004c
    Gerrit-Change-Number: 6897672
    Gerrit-PatchSet: 8
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Vlad Krot <vk...@google.com>
    Gerrit-Comment-Date: Tue, 02 Sep 2025 13:35:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vlad Krot (Gerrit)

    unread,
    Sep 2, 2025, 9:53:34 AM9/2/25
    to Andrew Rayskiy, AI Code Reviewer, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Simon Hangl, pwa-com...@google.com, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
    Attention needed from Andrew Rayskiy

    Vlad Krot added 1 comment

    File content/test/data/direct_sockets/udp.js
    Line 1, Patchset 8 (Latest):// Copyright 2022 The Chromium Authors
    Andrew Rayskiy . unresolved

    I believe we don't add copyright to test data?

    Vlad Krot

    I added it because presubmit complains

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Rayskiy
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibcd0d6e38cd6963c256428fc1ccc03e16827004c
    Gerrit-Change-Number: 6897672
    Gerrit-PatchSet: 8
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Andrew Rayskiy <green...@google.com>
    Gerrit-Comment-Date: Tue, 02 Sep 2025 13:53:15 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Andrew Rayskiy <green...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vlad Krot (Gerrit)

    unread,
    Sep 2, 2025, 9:55:11 AM9/2/25
    to Chromium IPC Reviews, Alex Rudenko, Maks Orlovich, Andrew Rayskiy, AI Code Reviewer, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Simon Hangl, pwa-com...@google.com, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
    Attention needed from Alex Rudenko and Andrew Rayskiy

    Vlad Krot added 1 comment

    Patchset-level comments
    File-level comment, Patchset 8 (Latest):
    Vlad Krot . resolved

    Please review Page.pdl

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Rudenko
    • Andrew Rayskiy
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibcd0d6e38cd6963c256428fc1ccc03e16827004c
    Gerrit-Change-Number: 6897672
    Gerrit-PatchSet: 8
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-Attention: Andrew Rayskiy <green...@google.com>
    Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Sep 2025 13:54:55 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vlad Krot (Gerrit)

    unread,
    Sep 2, 2025, 9:56:27 AM9/2/25
    to Chromium IPC Reviews, Alex Rudenko, Maks Orlovich, Andrew Rayskiy, AI Code Reviewer, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Simon Hangl, pwa-com...@google.com, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
    Attention needed from Alex Rudenko and Andrew Rayskiy

    Vlad Krot added 1 comment

    Patchset-level comments
    Vlad Krot . resolved

    alexr...@chromium.org Please review /Page.pdl
    morl...@chromium.org Please review /permissions_policy_features.json5

    Gerrit-Comment-Date: Tue, 02 Sep 2025 13:56:10 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    gwsq (Gerrit)

    unread,
    Sep 2, 2025, 9:58:24 AM9/2/25
    to Vlad Krot, Chromium IPC Reviews, Kinuko Yasuda, Alex Rudenko, Maks Orlovich, Andrew Rayskiy, AI Code Reviewer, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Simon Hangl, pwa-com...@google.com, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
    Attention needed from Alex Rudenko, Andrew Rayskiy and Kinuko Yasuda

    Message from gwsq

    From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
    IPC: kin...@chromium.org

    📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

    IPC reviewer(s): kin...@chromium.org


    Reviewer source(s):
    kin...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alex Rudenko
    • Andrew Rayskiy
    • Kinuko Yasuda
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibcd0d6e38cd6963c256428fc1ccc03e16827004c
    Gerrit-Change-Number: 6897672
    Gerrit-PatchSet: 8
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Kinuko Yasuda <kin...@chromium.org>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Kinuko Yasuda <kin...@chromium.org>
    Gerrit-Attention: Andrew Rayskiy <green...@google.com>
    Gerrit-Attention: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Sep 2025 13:57:40 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Alex Rudenko (Gerrit)

    unread,
    Sep 2, 2025, 10:02:22 AM9/2/25
    to Vlad Krot, Chromium IPC Reviews, Kinuko Yasuda, Maks Orlovich, Andrew Rayskiy, AI Code Reviewer, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Simon Hangl, pwa-com...@google.com, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
    Attention needed from Andrew Rayskiy, Kinuko Yasuda and Vlad Krot

    Alex Rudenko voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Rayskiy
    • Kinuko Yasuda
    • Vlad Krot
    Gerrit-Attention: Vlad Krot <vk...@google.com>
    Gerrit-Attention: Kinuko Yasuda <kin...@chromium.org>
    Gerrit-Attention: Andrew Rayskiy <green...@google.com>
    Gerrit-Comment-Date: Tue, 02 Sep 2025 14:02:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Rayskiy (Gerrit)

    unread,
    Sep 2, 2025, 10:09:54 AM9/2/25
    to Vlad Krot, Alex Rudenko, Chromium IPC Reviews, Kinuko Yasuda, AI Code Reviewer, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Simon Hangl, pwa-com...@google.com, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
    Attention needed from Kinuko Yasuda and Vlad Krot

    Andrew Rayskiy voted and added 1 comment

    Votes added by Andrew Rayskiy

    Code-Review+1

    1 comment

    File content/test/data/direct_sockets/udp.js
    Line 1, Patchset 8:// Copyright 2022 The Chromium Authors
    Andrew Rayskiy . unresolved

    I believe we don't add copyright to test data?

    Vlad Krot

    I added it because presubmit complains

    Andrew Rayskiy

    <surprised-pikachu-face>

    You sure? This feels extremely weird.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kinuko Yasuda
    • Vlad Krot
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibcd0d6e38cd6963c256428fc1ccc03e16827004c
    Gerrit-Change-Number: 6897672
    Gerrit-PatchSet: 9
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Kinuko Yasuda <kin...@chromium.org>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Vlad Krot <vk...@google.com>
    Gerrit-Attention: Kinuko Yasuda <kin...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Sep 2025 14:09:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Vlad Krot <vk...@google.com>
    Comment-In-Reply-To: Andrew Rayskiy <green...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Vlad Krot (Gerrit)

    unread,
    Sep 2, 2025, 10:24:12 AM9/2/25
    to Alex Rudenko, Chromium IPC Reviews, Kinuko Yasuda, Andrew Rayskiy, AI Code Reviewer, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Simon Hangl, pwa-com...@google.com, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
    Attention needed from Kinuko Yasuda

    Vlad Krot voted and added 1 comment

    Votes added by Vlad Krot

    Commit-Queue+1

    1 comment

    File content/test/data/direct_sockets/udp.js
    Line 1, Patchset 8:// Copyright 2022 The Chromium Authors
    Andrew Rayskiy . resolved

    I believe we don't add copyright to test data?

    Vlad Krot

    I added it because presubmit complains

    Andrew Rayskiy

    <surprised-pikachu-face>

    You sure? This feels extremely weird.

    Vlad Krot

    Sure.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kinuko Yasuda
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibcd0d6e38cd6963c256428fc1ccc03e16827004c
    Gerrit-Change-Number: 6897672
    Gerrit-PatchSet: 9
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Kinuko Yasuda <kin...@chromium.org>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Kinuko Yasuda <kin...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Sep 2025 14:23:52 +0000
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Rayskiy (Gerrit)

    unread,
    Sep 2, 2025, 10:24:30 AM9/2/25
    to Vlad Krot, Alex Rudenko, Chromium IPC Reviews, Kinuko Yasuda, AI Code Reviewer, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Simon Hangl, pwa-com...@google.com, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
    Attention needed from Kinuko Yasuda

    Andrew Rayskiy voted and added 1 comment

    Votes added by Andrew Rayskiy

    Code-Review+1

    1 comment

    File content/test/data/direct_sockets/udp.js
    Line 1, Patchset 8:// Copyright 2022 The Chromium Authors
    Andrew Rayskiy . resolved

    I believe we don't add copyright to test data?

    Andrew Rayskiy

    Acknowledged

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kinuko Yasuda
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibcd0d6e38cd6963c256428fc1ccc03e16827004c
    Gerrit-Change-Number: 6897672
    Gerrit-PatchSet: 8
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Kinuko Yasuda <kin...@chromium.org>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Kinuko Yasuda <kin...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Sep 2025 14:24:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Andrew Rayskiy <green...@google.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Maks Orlovich (Gerrit)

    unread,
    Sep 2, 2025, 10:36:21 AM9/2/25
    to Vlad Krot, Alex Rudenko, Chromium IPC Reviews, Kinuko Yasuda, Andrew Rayskiy, AI Code Reviewer, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Simon Hangl, pwa-com...@google.com, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
    Attention needed from Kinuko Yasuda and Vlad Krot

    Maks Orlovich voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Kinuko Yasuda
    • Vlad Krot
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibcd0d6e38cd6963c256428fc1ccc03e16827004c
    Gerrit-Change-Number: 6897672
    Gerrit-PatchSet: 9
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Kinuko Yasuda <kin...@chromium.org>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Vlad Krot <vk...@google.com>
    Gerrit-Attention: Kinuko Yasuda <kin...@chromium.org>
    Gerrit-Comment-Date: Tue, 02 Sep 2025 14:36:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kinuko Yasuda (Gerrit)

    unread,
    Sep 2, 2025, 12:34:18 PM9/2/25
    to Vlad Krot, Maks Orlovich, Alex Rudenko, Chromium IPC Reviews, Andrew Rayskiy, AI Code Reviewer, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Simon Hangl, pwa-com...@google.com, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org
    Attention needed from Vlad Krot

    Kinuko Yasuda voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Vlad Krot
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Gerrit-Comment-Date: Tue, 02 Sep 2025 16:33:59 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Vlad Krot (Gerrit)

    unread,
    Sep 3, 2025, 11:27:00 AM9/3/25
    to Kinuko Yasuda, Maks Orlovich, Alex Rudenko, Chromium IPC Reviews, Andrew Rayskiy, AI Code Reviewer, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Simon Hangl, pwa-com...@google.com, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org

    Vlad Krot voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibcd0d6e38cd6963c256428fc1ccc03e16827004c
    Gerrit-Change-Number: 6897672
    Gerrit-PatchSet: 10
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Kinuko Yasuda <kin...@chromium.org>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Comment-Date: Wed, 03 Sep 2025 15:26:40 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 3, 2025, 1:11:59 PM9/3/25
    to Vlad Krot, Kinuko Yasuda, Maks Orlovich, Alex Rudenko, Chromium IPC Reviews, Andrew Rayskiy, AI Code Reviewer, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, Simon Hangl, pwa-com...@google.com, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, network-ser...@chromium.org, rmcelra...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    9 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: tools/metrics/histograms/metadata/blink/enums.xml
    Insertions: 5, Deletions: 3.

    The diff is too large to show. Please review the diff.
    ```
    ```
    The name of the file: third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
    Insertions: 5, Deletions: 3.

    The diff is too large to show. Please review the diff.
    ```

    Change information

    Commit message:
    Multicast support in Direct Sockets #2

    This CL adds 'direct-sockets-multicast' permission policy. Tests for if
    the permission policy is present/absent, and UseCounter for idl file
    multicast_controller.idl.

    Previous CL:
    https://chromium-review.googlesource.com/c/chromium/src/+/6894978/13

    Explainer
    https://github.com/explainers-by-googlers/multicast-in-direct-sockets.
    Chrome Entry https://chromestatus.com/feature/5073740211814400 Intent to
    prototype
    https://groups.google.com/a/chromium.org/g/blink-dev/c/ADV4FZtN4nE
    Bug: 398934282
    Low-Coverage-Reason: TESTS_IN_SEPARATE_CL
    Change-Id: Ibcd0d6e38cd6963c256428fc1ccc03e16827004c
    Commit-Queue: Vlad Krot <vk...@google.com>
    Reviewed-by: Alex Rudenko <alexr...@chromium.org>
    Reviewed-by: Kinuko Yasuda <kin...@chromium.org>
    Reviewed-by: Andrew Rayskiy <green...@google.com>
    Reviewed-by: Maks Orlovich <morl...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1510350}
    Files:
    • M content/browser/direct_sockets/direct_sockets_service_impl.cc
    • M content/browser/direct_sockets/direct_sockets_test_utils.cc
    • M content/browser/direct_sockets/direct_sockets_udp_browsertest.cc
    • M content/test/data/direct_sockets/udp.js
    • M services/network/public/cpp/permissions_policy/permissions_policy_features.json5
    • M services/network/public/mojom/permissions_policy/permissions_policy_feature.mojom
    • M third_party/blink/public/devtools_protocol/domains/Page.pdl
    • M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
    • M third_party/blink/renderer/modules/direct_sockets/multicast_controller.idl
    • M third_party/blink/renderer/modules/direct_sockets/udp_socket.cc
    • M third_party/blink/web_tests/wpt_internal/isolated-permissions-policy/permissions_policy.https.html
    • M tools/metrics/histograms/metadata/blink/enums.xml
    Change size: M
    Delta: 12 files changed, 205 insertions(+), 36 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Maks Orlovich, +1 by Kinuko Yasuda, +1 by Alex Rudenko, +1 by Andrew Rayskiy
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ibcd0d6e38cd6963c256428fc1ccc03e16827004c
    Gerrit-Change-Number: 6897672
    Gerrit-PatchSet: 11
    Gerrit-Owner: Vlad Krot <vk...@google.com>
    Gerrit-Reviewer: Alex Rudenko <alexr...@chromium.org>
    Gerrit-Reviewer: Andrew Rayskiy <green...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kinuko Yasuda <kin...@chromium.org>
    Gerrit-Reviewer: Maks Orlovich <morl...@chromium.org>
    Gerrit-Reviewer: Vlad Krot <vk...@google.com>
    Gerrit-CC: AI Code Reviewer <peep-gen...@system.gserviceaccount.com>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages