Revert "LCP: Use largest painted image for web-exposed entry" [chromium/src : main]

0 views
Skip to first unread message

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,
Feb 6, 2026, 10:52:59 PM (2 days ago) Feb 6
to Rubber Stamper, Scott Haseley, Chromium LUCI CQ, Michal Mocny, AyeAye, Blink W3C Test Autoroller, chromium...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org
Attention needed from Michal Mocny and Scott Haseley

Message from luci-bi...@appspot.gserviceaccount.com

LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.

Open in Gerrit

Related details

Attention is currently required from:
  • Michal Mocny
  • Scott Haseley
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic5637d16e4206a0bd4fdfc95f47620053649378e
Gerrit-Change-Number: 7551162
Gerrit-PatchSet: 1
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Attention: Scott Haseley <shas...@chromium.org>
Gerrit-Attention: Michal Mocny <mmo...@chromium.org>
Gerrit-Comment-Date: Sat, 07 Feb 2026 03:52:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Feb 6, 2026, 10:53:18 PM (2 days ago) Feb 6
to luci-bi...@appspot.gserviceaccount.com, Scott Haseley, Chromium LUCI CQ, Michal Mocny, AyeAye, Blink W3C Test Autoroller, chromium...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org
Attention needed from Michal Mocny and Scott Haseley

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Michal Mocny
  • Scott Haseley
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic5637d16e4206a0bd4fdfc95f47620053649378e
    Gerrit-Change-Number: 7551162
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-Attention: Scott Haseley <shas...@chromium.org>
    Gerrit-Attention: Michal Mocny <mmo...@chromium.org>
    Gerrit-Comment-Date: Sat, 07 Feb 2026 03:53:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Michal Mocny (Gerrit)

    unread,
    Feb 7, 2026, 1:19:10 PM (yesterday) Feb 7
    to luci-bi...@appspot.gserviceaccount.com, Rubber Stamper, Scott Haseley, Chromium LUCI CQ, AyeAye, Blink W3C Test Autoroller, chromium...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org
    Attention needed from Scott Haseley

    Michal Mocny added 1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Michal Mocny . resolved

    I'll wait for Scott to decide if Revert is best before branch Monday, but: I see that all three failing tests are for the LCPPTimingPredictor feature, which is still disabled by default, and AFAIK might no longer be planned to ship?

    Quickly looking at the tests I can see how the order of expectations might be brittle/need updating, but I haven't had a chance to dig further.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Scott Haseley
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic5637d16e4206a0bd4fdfc95f47620053649378e
    Gerrit-Change-Number: 7551162
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Michal Mocny <mmo...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-Attention: Scott Haseley <shas...@chromium.org>
    Gerrit-Comment-Date: Sat, 07 Feb 2026 18:19:05 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Michal Mocny (Gerrit)

    unread,
    Feb 7, 2026, 1:20:29 PM (yesterday) Feb 7
    to luci-bi...@appspot.gserviceaccount.com, Rubber Stamper, Scott Haseley, Chromium LUCI CQ, AyeAye, Blink W3C Test Autoroller, chromium...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org
    Attention needed from Scott Haseley

    Michal Mocny added 1 comment

    Patchset-level comments
    Michal Mocny . resolved

    I'll wait for Scott to decide if Revert is best before branch Monday, but: I see that all three failing tests are for the LCPPTimingPredictor feature, which is still disabled by default, and AFAIK might no longer be planned to ship?

    Quickly looking at the tests I can see how the order of expectations might be brittle/need updating, but I haven't had a chance to dig further.

    Michal Mocny

    (In other words, might be worth checking with the feature owners if these tests are needed or could temporarily be disabled-- keeping the tests passing exactly as written might not be desired chrome behaviour)

    Gerrit-Comment-Date: Sat, 07 Feb 2026 18:20:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Michal Mocny <mmo...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages