[APC] Visible bounding box must fit inside viewport and within outer bounding box [chromium/src : main]

0 views

Skip to first unread message

AI Code Reviewer (Gerrit)

unread,

6:49 PM (4 hours ago) 6:49 PM

to Aaron Leventhal, Chromium LUCI CQ, chromium...@chromium.org, aleventh...@chromium.org, blink-...@chromium.org, mfoltz+wa...@chromium.org

Attention needed from Aaron Leventhal

AI Code Reviewer added 1 comment

File third_party/blink/renderer/modules/content_extraction/ai_page_content_agent.h

Line 188, Patchset 1 (Latest): bool lifecycle_observer_registered_ = false;

AI Code Reviewer . unresolved

nit: Per the Blink Style Guide: Naming - 'Precede boolean values with words like “is” and “did”', please consider renaming these boolean member variables. For example, `lifecycle_observer_registered_` could be `is_lifecycle_observer_registered_`.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **Won't fix**: reason | **b/<bug_id>** | **Invalid:** reason

_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_

Open in Gerrit

Related details

Attention is currently required from:

Aaron Leventhal

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages