[TabFavicon] Augment with async database fallback on Android [chromium/src : main]

1 view

Skip to first unread message

Calder Kitagawa (Gerrit)

unread,

May 25, 2026, 10:51:54 PM (4 hours ago) May 25

to Hu, Ningxin, Alex Keng, (Julie)Jeongeun Kim, Jiewei Qian, agriev...@chromium.org, blink-rev...@chromium.org, abigailbk...@google.com, aashna...@google.com, blink-...@chromium.org, alexmo...@chromium.org

Attention needed from Fiaz Muhammad and Madhav Pruthi

Calder Kitagawa has uploaded the change for review

Calder Kitagawa removed Hu, Ningxin, Alex Keng, (Julie)Jeongeun Kim, Jiewei Qian, Akihiro Ota, agriev...@chromium.org, blink-rev...@chromium.org, abigailbk...@google.com, aashna...@google.com, blink-...@chromium.org and alexmo...@chromium.org from reviewers of this change.

Commit message

[TabFavicon] Augment with async database fallback on Android

This commit adds support for fetching favicons asynchronously from the
local favicon database on Android using FaviconHelper when the
WebContents is null (frozen tabs). It preserves existing sync behavior
(and not using fallback) for other components by introducing overloaded
getBitmap/getFavicon methods.

Bug: 475267465

Change-Id: I82b9d474f6d18fe7104d376487e1a4a16a6a6964

Change diff

Change information

Files:

M chrome/android/java/src/org/chromium/chrome/browser/tab/DEPS
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabFavicon.java
M chrome/android/java/src/org/chromium/chrome/browser/tab/TabFaviconTest.java
M chrome/browser/android/tab_favicon.cc
M chrome/browser/android/tab_favicon.h

Change size: L

Delta: 5 files changed, 393 insertions(+), 34 deletions(-)

Open in Gerrit

Related details

Attention is currently required from:

Fiaz Muhammad
Madhav Pruthi

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages