[html-in-canvas] Prevent composited layers for inlines [chromium/src : main]

0 views
Skip to first unread message

Philip Rogers (Gerrit)

unread,
Mar 20, 2026, 5:29:38 PM (2 days ago) Mar 20
to Stefan Zager, AyeAye, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Stefan Zager

Philip Rogers voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Stefan Zager
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic1eb62eb0e2965f358d5b356b395a1e90566aa24
Gerrit-Change-Number: 7688577
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Stefan Zager <sza...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Mar 2026 21:29:29 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Philip Rogers (Gerrit)

unread,
Mar 20, 2026, 6:47:00 PM (2 days ago) Mar 20
to Chromium LUCI CQ, Stefan Zager, AyeAye, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Stefan Zager

Philip Rogers voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Stefan Zager
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic1eb62eb0e2965f358d5b356b395a1e90566aa24
Gerrit-Change-Number: 7688577
Gerrit-PatchSet: 4
Gerrit-Owner: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-Attention: Stefan Zager <sza...@chromium.org>
Gerrit-Comment-Date: Fri, 20 Mar 2026 22:46:50 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Stefan Zager (Gerrit)

unread,
Mar 21, 2026, 6:13:41 PM (7 hours ago) Mar 21
to Philip Rogers, Chromium LUCI CQ, AyeAye, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Philip Rogers

Stefan Zager voted and added 1 comment

Votes added by Stefan Zager

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Stefan Zager . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic1eb62eb0e2965f358d5b356b395a1e90566aa24
    Gerrit-Change-Number: 7688577
    Gerrit-PatchSet: 4
    Gerrit-Owner: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Comment-Date: Sat, 21 Mar 2026 22:13:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 21, 2026, 6:17:32 PM (7 hours ago) Mar 21
    to Philip Rogers, Stefan Zager, AyeAye, Menard, Alexis, chromium...@chromium.org, Olga Gerchikov, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [html-in-canvas] Prevent composited layers for inlines

    We have code to prevent compositing reasons for canvas descendants,
    other than direct children of the canvas. This code had an incorrect
    check for LayoutBox, and was not run for inlines, resulting in
    compositing.
    Fixed: 493957490
    Change-Id: Ic1eb62eb0e2965f358d5b356b395a1e90566aa24
    Commit-Queue: Stefan Zager <sza...@chromium.org>
    Auto-Submit: Philip Rogers <p...@chromium.org>
    Reviewed-by: Stefan Zager <sza...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1603086}
    Files:
    • M third_party/blink/renderer/core/paint/compositing/compositing_reason_finder.cc
    • A third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/opacity-animation-ref.html
    • A third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/opacity-animation.html
    Change size: M
    Delta: 3 files changed, 75 insertions(+), 3 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Stefan Zager
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic1eb62eb0e2965f358d5b356b395a1e90566aa24
    Gerrit-Change-Number: 7688577
    Gerrit-PatchSet: 5
    Gerrit-Owner: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages