Deprecate opt-in Attribution Reporting API surfaces [chromium/src : main]

0 views
Skip to first unread message

Andrew Paseltiner (Gerrit)

unread,
Nov 12, 2025, 6:28:51 PM (2 days ago) Nov 12
to Nan Lin, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org
Attention needed from Nan Lin

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Nan Lin
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ifee9a4f54edd977a90b0b4ed536f874aa5106945
Gerrit-Change-Number: 7133159
Gerrit-PatchSet: 5
Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
Gerrit-Attention: Nan Lin <lin...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Nov 2025 23:28:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Nan Lin (Gerrit)

unread,
2:17 PM (9 hours ago) 2:17 PM
to Andrew Paseltiner, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org
Attention needed from Andrew Paseltiner

Nan Lin added 1 comment

File third_party/blink/renderer/core/frame/attribution_src_loader.cc
Line 161, Patchset 8 (Latest): Deprecation::CountDeprecation(window,
Nan Lin . unresolved

Can we also add the deprecation for ARA response headers in regular non-keep-alive fetches? https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/frame/attribution_src_loader.cc;l=834

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Paseltiner
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifee9a4f54edd977a90b0b4ed536f874aa5106945
    Gerrit-Change-Number: 7133159
    Gerrit-PatchSet: 8
    Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
    Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Comment-Date: Fri, 14 Nov 2025 19:17:37 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Paseltiner (Gerrit)

    unread,
    2:19 PM (9 hours ago) 2:19 PM
    to Nan Lin, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org
    Attention needed from Nan Lin

    Andrew Paseltiner added 1 comment

    File third_party/blink/renderer/core/frame/attribution_src_loader.cc
    Line 161, Patchset 8 (Latest): Deprecation::CountDeprecation(window,
    Nan Lin . unresolved

    Can we also add the deprecation for ARA response headers in regular non-keep-alive fetches? https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/frame/attribution_src_loader.cc;l=834

    Andrew Paseltiner

    I'd prefer to do that in a followup CL so that it works uniformly for keep-alive and non-keep-alive. Otherwise, I'm concerned that there could be confusion for developers seeing the deprecation notices only some of the time.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nan Lin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifee9a4f54edd977a90b0b4ed536f874aa5106945
    Gerrit-Change-Number: 7133159
    Gerrit-PatchSet: 8
    Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
    Gerrit-Attention: Nan Lin <lin...@chromium.org>
    Gerrit-Comment-Date: Fri, 14 Nov 2025 19:19:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Nan Lin <lin...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nan Lin (Gerrit)

    unread,
    2:22 PM (9 hours ago) 2:22 PM
    to Andrew Paseltiner, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org
    Attention needed from Andrew Paseltiner

    Nan Lin added 1 comment

    File third_party/blink/renderer/core/frame/attribution_src_loader.cc
    Line 161, Patchset 8 (Latest): Deprecation::CountDeprecation(window,
    Nan Lin . unresolved

    Can we also add the deprecation for ARA response headers in regular non-keep-alive fetches? https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/frame/attribution_src_loader.cc;l=834

    Andrew Paseltiner

    I'd prefer to do that in a followup CL so that it works uniformly for keep-alive and non-keep-alive. Otherwise, I'm concerned that there could be confusion for developers seeing the deprecation notices only some of the time.

    Nan Lin

    Can you add a TODO to follow up? The keep-alive one may need to count deprecation from the browser.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Paseltiner
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ifee9a4f54edd977a90b0b4ed536f874aa5106945
    Gerrit-Change-Number: 7133159
    Gerrit-PatchSet: 8
    Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
    Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Comment-Date: Fri, 14 Nov 2025 19:22:16 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Nan Lin <lin...@chromium.org>
    Comment-In-Reply-To: Andrew Paseltiner <apase...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Andrew Paseltiner (Gerrit)

    unread,
    2:25 PM (9 hours ago) 2:25 PM
    to Nan Lin, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org
    Attention needed from Nan Lin

    Andrew Paseltiner added 1 comment

    File third_party/blink/renderer/core/frame/attribution_src_loader.cc
    Line 161, Patchset 8: Deprecation::CountDeprecation(window,
    Nan Lin . resolved

    Can we also add the deprecation for ARA response headers in regular non-keep-alive fetches? https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/frame/attribution_src_loader.cc;l=834

    Andrew Paseltiner

    I'd prefer to do that in a followup CL so that it works uniformly for keep-alive and non-keep-alive. Otherwise, I'm concerned that there could be confusion for developers seeing the deprecation notices only some of the time.

    Nan Lin

    Can you add a TODO to follow up? The keep-alive one may need to count deprecation from the browser.

    Andrew Paseltiner

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nan Lin
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ifee9a4f54edd977a90b0b4ed536f874aa5106945
      Gerrit-Change-Number: 7133159
      Gerrit-PatchSet: 9
      Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
      Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
      Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
      Gerrit-Attention: Nan Lin <lin...@chromium.org>
      Gerrit-Comment-Date: Fri, 14 Nov 2025 19:25:04 +0000
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nan Lin (Gerrit)

      unread,
      2:27 PM (9 hours ago) 2:27 PM
      to Andrew Paseltiner, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org
      Attention needed from Andrew Paseltiner

      Nan Lin voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andrew Paseltiner
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ifee9a4f54edd977a90b0b4ed536f874aa5106945
        Gerrit-Change-Number: 7133159
        Gerrit-PatchSet: 9
        Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
        Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
        Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
        Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
        Gerrit-Comment-Date: Fri, 14 Nov 2025 19:27:03 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Andrew Paseltiner (Gerrit)

        unread,
        2:29 PM (9 hours ago) 2:29 PM
        to Daniel Cheng, Nan Lin, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org
        Attention needed from Daniel Cheng

        Andrew Paseltiner added 1 comment

        Patchset-level comments
        File-level comment, Patchset 9 (Latest):
        Andrew Paseltiner . resolved

        + @dch...@chromium.org for `third_party/blink/renderer/core/frame`.

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Daniel Cheng
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ifee9a4f54edd977a90b0b4ed536f874aa5106945
        Gerrit-Change-Number: 7133159
        Gerrit-PatchSet: 9
        Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
        Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
        Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
        Gerrit-Comment-Date: Fri, 14 Nov 2025 19:29:13 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: No
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Daniel Cheng (Gerrit)

        unread,
        4:58 PM (6 hours ago) 4:58 PM
        to Andrew Paseltiner, Daniel Cheng, Nan Lin, Chromium LUCI CQ, chromium...@chromium.org, apaselti...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, devtools-re...@chromium.org, jmedle...@chromium.org
        Attention needed from Andrew Paseltiner

        Daniel Cheng voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        • Andrew Paseltiner
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ifee9a4f54edd977a90b0b4ed536f874aa5106945
        Gerrit-Change-Number: 7133159
        Gerrit-PatchSet: 10
        Gerrit-Owner: Andrew Paseltiner <apase...@chromium.org>
        Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
        Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
        Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
        Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
        Gerrit-Comment-Date: Fri, 14 Nov 2025 21:58:14 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy
        Reply all
        Reply to author
        Forward
        0 new messages