Update constructor.js to avoid MutationEvent [chromium/src : main]
0 views
Skip to first unread message
Minju Kim (Gerrit)
Feb 4, 2026, 9:38:15 PM (4 days ago) Feb 4
to Kent Tamura, Kentaro Hara, AyeAye, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Kent Tamura and Kentaro Hara
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Kent Tamura
- Kentaro Hara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kent Tamura (Gerrit)
Feb 5, 2026, 12:04:42 AM (4 days ago) Feb 5
to Minju Kim, Mason Freed, Kentaro Hara, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org, Kent Tamura
Attention needed from Kentaro Hara, Mason Freed and Minju Kim
Kent Tamura added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kent Tamura . resolved
IMO Mason is more appropriate reviewer.
Related details
Attention is currently required from:
- Kentaro Hara
- Mason Freed
- Minju Kim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Feb 5, 2026, 4:18:57 PM (3 days ago) Feb 5
to Minju Kim, Kentaro Hara, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Kentaro Hara and Minju Kim
Mason Freed voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mason Freed
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Kentaro Hara
- Minju Kim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Minju Kim (Gerrit)
Feb 5, 2026, 9:46:18 PM (3 days ago) Feb 5
to Mason Freed, Kentaro Hara, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Kentaro Hara
Minju Kim added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Mason Freed . resolved
Great! thanks for the cleanup.
Minju Kim
🙏
Minju Kim . resolved
One more vote needed.
Hi @har...@chromium.org, Could you please take a look at this?
Related details
Attention is currently required from:
- Kentaro Hara
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
Feb 5, 2026, 10:17:47 PM (3 days ago) Feb 5
to Minju Kim, Mason Freed, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Minju Kim
Kentaro Hara voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Minju Kim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Minju Kim (Gerrit)
Feb 6, 2026, 12:15:45 AM (3 days ago) Feb 6
to Kentaro Hara, Mason Freed, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Kentaro Hara and Mason Freed
Minju Kim added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Minju Kim . resolved
Rebased, sorry. Could you please take another look?
Related details
Attention is currently required from:
- Kentaro Hara
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
Feb 6, 2026, 12:25:42 AM (3 days ago) Feb 6
to Minju Kim, Mason Freed, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed and Minju Kim
Kentaro Hara voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Mason Freed
- Minju Kim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Feb 6, 2026, 8:30:23 PM (2 days ago) Feb 6
to Minju Kim, Kentaro Hara, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Minju Kim
Mason Freed voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Minju Kim
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Minju Kim (Gerrit)
Feb 6, 2026, 9:25:20 PM (2 days ago) Feb 6
to Mason Freed, Kentaro Hara, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, blink-...@chromium.org
Minju Kim voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 6, 2026, 9:36:09 PM (2 days ago) Feb 6
to Minju Kim, Mason Freed, Kentaro Hara, AyeAye, chromium...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Update constructor.js to avoid MutationEvent
MutationEvent was removed, but this test only used it to
validate constructor and prototype inheritance for Event subclasses.
Use CustomEvent instead to keep testing the same behavior.
Bug: 1446498
Change-Id: Id260c87d9657fa05f7cac9a35e3c66e630aa7516
Reviewed-by: Mason Freed <mas...@chromium.org>
Commit-Queue: Minju Kim <mk...@igalia.com>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1581261}
Files:
- M third_party/blink/web_tests/TestExpectations
- M third_party/blink/web_tests/fast/js/constructor-expected.txt
- M third_party/blink/web_tests/fast/js/script-tests/constructor.js
Change size: S
Delta: 3 files changed, 5 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mason Freed, +1 by Kentaro Hara
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages