Reland "[tracing] Deduplicate Blink.Responsiveness.UserInteraction trace events" [chromium/src : main]
Etienne Pierre-Doray (Gerrit)
New activity on the change![]( "Open in Gerrit")
Related details
- Michal Mocny
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michal Mocny (Gerrit)
Michal Mocny voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michal Mocny
| Code-Review | +1 |
1 comment
LGTM, but please update the description with a Bug pointing to both the original and a reason for revert, and add to description what changed in this CL (i.e. undo the removal of the trace event).
(I also assume you didnt actually test the lighthouse audit works-- I assume it would do *something* but I haven't confirmed the results will be identical after this change lands. Still-- I think we need to, and may soon, just update the lighthouse audit implementation anyway)
Related details
- Etienne Pierre-Doray
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +2 |
LGTM, but please update the description with a Bug pointing to both the original and a reason for revert, and add to description what changed in this CL (i.e. undo the removal of the trace event).
(I also assume you didnt actually test the lighthouse audit works-- I assume it would do *something* but I haven't confirmed the results will be identical after this change lands. Still-- I think we need to, and may soon, just update the lighthouse audit implementation anyway)
LGTM, but please update the description with a Bug pointing to both the original and a reason for revert, and add to description what changed in this CL (i.e. undo the removal of the trace event).
Done
(I also assume you didnt actually test the lighthouse audit works-- I assume it would do something but I haven't confirmed the results will be identical after this change lands. Still-- I think we need to, and may soon, just update the lighthouse audit implementation anyway)
I ran lighthouse. Seems it broke no tests. In fact, the single worst input is often returned (regardless of this change) because we have fewer than 50 interactions.
When/if we have more though, then the result can indeed change.
Related details
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Reland "[tracing] Deduplicate Blink.Responsiveness.UserInteraction trace events"
This is a reland of commit 9d9d846411d03f3c409cdd6fba1c6564f21200b7
Reason for revert: https://crbug.com/530174267
Failure Link: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_linux_rel/27792/test-results?view=legacy&q=ID%3Ae2e%2Flighthouse%2Ftimespan.test.ts%3A+Timespan%2Fsuccessfully+returns+a+Lighthouse+report+for+user+interactions+VHash%3Ae3b0c44298fc1c14
Fix: Keep "Responsiveness.Renderer.UserInteraction" which
was remove in the first land.
Original change's description:
> [tracing] Deduplicate Blink.Responsiveness.UserInteraction trace events
>
> To match how the UMA is emitted.
> Drive-by: remove redundant/unused "Responsiveness.Renderer.UserInteraction"
>
> Change-Id: I04c20e45e68481f29e6ea97f7bd78b154904c70a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7997937
> Reviewed-by: Michal Mocny <mmo...@chromium.org>
> Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1652771}
- M third_party/blink/renderer/core/timing/responsiveness_metrics.cc
Code-Review: +1 by Michal Mocny
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |