Add kUseNonEmptySyncTokenForLowLatencyCanvas feature for Windows [chromium/src : main]
0 views
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
Nov 13, 2025, 3:54:54 PM (yesterday) Nov 13
to Mingjing Zhang, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Attention needed from Mingjing Zhang
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Mingjing Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mingjing Zhang (Gerrit)
Nov 13, 2025, 3:56:00 PM (yesterday) Nov 13
to Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Mingjing Zhang voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 13, 2025, 4:34:32 PM (yesterday) Nov 13
to Mingjing Zhang, Vasiliy Telezhnikov, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Add kUseNonEmptySyncTokenForLowLatencyCanvas feature for Windows
This CL changes DrawingBuffer::ExportLowLatencyCanvasResource() to use
the sync token returned from back_color_buffer when creating new canvas
resource, and also ensures this behavior is only turned on for Windows
via a killswitch kUseNonEmptySyncTokenForLowLatencyCanvas. This change
effectively reverts the sync token behavior for desynchornized canvas on
Windows to match the behavior prior to 142.0.7429.0 in order to prevent
a screen flickering issue in Cocos2d-x games.
Bug: 458538691
Change-Id: Ie10e3d4d1baa3e2dd688a091c4029580e7e53362
Commit-Queue: Mingjing Zhang <mjz...@chromium.org>
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1544545}
Files:
- M third_party/blink/renderer/platform/graphics/gpu/drawing_buffer.cc
Change size: S
Delta: 1 file changed, 21 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mingjing Zhang (Gerrit)
5:26 PM (6 hours ago) 5:26 PM
to Chromium LUCI CQ, chromium...@chromium.org, Dirk Schulze, Stephen Chenney, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org
Mingjing Zhang abandoned this change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages