Revert "WebNN: Handle WebNN context lost error" [chromium/src : main]

0 views
Skip to first unread message

Rubber Stamper (Gerrit)

unread,
Jul 3, 2024, 2:56:16 AMJul 3
to Kalvin Lee, Alex Gough, ningxin hu, Reilly Grant, Mingming1 Xu, Chromium LUCI CQ, Rafael Cintron, Jiewei Qian, Dwayne Robinson, Tricium, Kentaro Hara, Austin Sullivan, chromium...@chromium.org, Bryan Bernhart, AyeAye, Rafael Cintron, blink-revie...@chromium.org, mac-r...@chromium.org, blundell+...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Alex Gough, Mingming1 Xu, Rafael Cintron, Reilly Grant and ningxin hu

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Gough
  • Mingming1 Xu
  • Rafael Cintron
  • Reilly Grant
  • ningxin hu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iae3d0047eb8c89e76d4d94044598f6f95bc020c9
Gerrit-Change-Number: 5669861
Gerrit-PatchSet: 1
Gerrit-Owner: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Mingming1 Xu <mingmi...@intel.com>
Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
Gerrit-CC: Austin Sullivan <asu...@chromium.org>
Gerrit-CC: Bryan Bernhart <bryan.b...@intel.com>
Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Rafael Cintron <rafael....@chromium.org>
Gerrit-Attention: Alex Gough <aj...@chromium.org>
Gerrit-Attention: ningxin hu <ningx...@intel.com>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: Mingming1 Xu <mingmi...@intel.com>
Gerrit-Attention: Rafael Cintron <rafael....@microsoft.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 06:56:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Kalvin Lee (Gerrit)

unread,
Jul 3, 2024, 2:56:32 AMJul 3
to Rubber Stamper, Alex Gough, ningxin hu, Reilly Grant, Mingming1 Xu, Chromium LUCI CQ, Rafael Cintron, Jiewei Qian, Dwayne Robinson, Tricium, Kentaro Hara, Austin Sullivan, chromium...@chromium.org, Bryan Bernhart, AyeAye, Rafael Cintron, blink-revie...@chromium.org, mac-r...@chromium.org, blundell+...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Alex Gough, Mingming1 Xu, Rafael Cintron, Reilly Grant and ningxin hu

Kalvin Lee added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Kalvin Lee . resolved

# Gardener Notes

* Both tests fail on the same `CHECK()`:
  ```
  context_impl_dml.cc(368): Check failed: hr == E_OUTOFMEMORY || hr == DXGI_ERROR_DEVICE_REMOVED || hr == DXGI_ERROR_DEVICE_RESET.
  ```
Gerrit-Comment-Date: Wed, 03 Jul 2024 06:56:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Kalvin Lee (Gerrit)

unread,
Jul 3, 2024, 2:56:49 AMJul 3
to Rubber Stamper, Alex Gough, ningxin hu, Reilly Grant, Mingming1 Xu, Chromium LUCI CQ, Rafael Cintron, Jiewei Qian, Dwayne Robinson, Tricium, Kentaro Hara, Austin Sullivan, chromium...@chromium.org, Bryan Bernhart, AyeAye, Rafael Cintron, blink-revie...@chromium.org, mac-r...@chromium.org, blundell+...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Alex Gough, Mingming1 Xu, Rafael Cintron, Reilly Grant and ningxin hu

Kalvin Lee voted and added 1 comment

Votes added by Kalvin Lee

Commit-Queue+2
Owners-Override+1

1 comment

Patchset-level comments
Kalvin Lee . resolved

Gardener casting Owners-Override.

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Gough
  • Mingming1 Xu
  • Rafael Cintron
  • Reilly Grant
  • ningxin hu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iae3d0047eb8c89e76d4d94044598f6f95bc020c9
Gerrit-Change-Number: 5669861
Gerrit-PatchSet: 1
Gerrit-Owner: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Alex Gough <aj...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kalvin Lee <kd...@chromium.org>
Gerrit-Reviewer: Mingming1 Xu <mingmi...@intel.com>
Gerrit-Reviewer: Rafael Cintron <rafael....@microsoft.com>
Gerrit-Reviewer: Reilly Grant <rei...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
Gerrit-CC: Austin Sullivan <asu...@chromium.org>
Gerrit-CC: Bryan Bernhart <bryan.b...@intel.com>
Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Rafael Cintron <rafael....@chromium.org>
Gerrit-Attention: Alex Gough <aj...@chromium.org>
Gerrit-Attention: ningxin hu <ningx...@intel.com>
Gerrit-Attention: Reilly Grant <rei...@chromium.org>
Gerrit-Attention: Mingming1 Xu <mingmi...@intel.com>
Gerrit-Attention: Rafael Cintron <rafael....@microsoft.com>
Gerrit-Comment-Date: Wed, 03 Jul 2024 06:56:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jul 3, 2024, 2:57:17 AMJul 3
to Kalvin Lee, Rubber Stamper, Alex Gough, ningxin hu, Reilly Grant, Mingming1 Xu, Rafael Cintron, Jiewei Qian, Dwayne Robinson, Tricium, Kentaro Hara, Austin Sullivan, chromium...@chromium.org, Bryan Bernhart, AyeAye, Rafael Cintron, blink-revie...@chromium.org, mac-r...@chromium.org, blundell+...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Revert "WebNN: Handle WebNN context lost error"

This reverts commit a240af8bb2c11c08a6649388afdd4896818bf336.

Reason for revert: `blink_wpt_tests` fail on "Win11 Tests x64"

Original change's description:
> WebNN: Handle WebNN context lost error
>
> This CL is to handle the WebNN context lost error and has implemented
> for DirectML backend.
>
> 1. Defined `MLContextLostInfo` dictionary in the WebIDL to expose the
> context lost information.
> 2. Defined `Promise<MLContextLostInfo> lost` of `MLContext` interface
> in the WebIDL, when the lost error is captured, the promise will be
> resolved with the `MLContextLostInfo`.
> 3. Defined `WebNNContextClient` mojom interface and it's method
> `OnLost(string message)` to send the context lost message to
> the renderer process when the `MLContext` object lost error in the
> GPU process is captured. The renderer process will override this
> method to handle the lost error.
> 4. Implemented the context lost handling feature in DirectML backend.
>
> Bug: 40281640, 41492165
> Change-Id: I16775ac8cdbd508e04025c22740d13f01e591b0d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5602134
> Reviewed-by: Reilly Grant <rei...@chromium.org>
> Reviewed-by: ningxin hu <ningx...@intel.com>
> Reviewed-by: Rafael Cintron <rafael....@microsoft.com>
> Commit-Queue: Mingming1 Xu <mingmi...@intel.com>
> Cr-Commit-Position: refs/heads/main@{#1322573}
Bug: 40281640, 41492165
Change-Id: Iae3d0047eb8c89e76d4d94044598f6f95bc020c9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Owners-Override: Kalvin Lee <kd...@chromium.org>
Commit-Queue: Kalvin Lee <kd...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1322611}
Files:
  • M services/webnn/coreml/context_impl_coreml.h
  • M services/webnn/coreml/context_impl_coreml.mm
  • M services/webnn/dml/adapter.cc
  • M services/webnn/dml/context_impl_dml.cc
  • M services/webnn/dml/context_impl_dml.h
  • M services/webnn/dml/graph_impl_dml.cc
  • M services/webnn/dml/graph_impl_dml.h
  • M services/webnn/public/mojom/webnn_context_provider.mojom
  • M services/webnn/tflite/context_impl_cros.cc
  • M services/webnn/tflite/context_impl_cros.h
  • M services/webnn/tflite/context_impl_tflite.cc
  • M services/webnn/tflite/context_impl_tflite.h
  • M services/webnn/webnn_context_impl.cc
  • M services/webnn/webnn_context_impl.h
  • M services/webnn/webnn_context_provider_impl.cc
  • M services/webnn/webnn_graph_impl_unittest.cc
  • M third_party/blink/renderer/bindings/generated_in_modules.gni
  • M third_party/blink/renderer/modules/ml/ml_context.cc
  • M third_party/blink/renderer/modules/ml/ml_context.h
  • M third_party/blink/renderer/modules/ml/ml_context.idl
  • M third_party/blink/renderer/modules/ml/webnn/ml_graph_test.cc
  • M third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
  • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
Change size: L
Delta: 23 files changed, 90 insertions(+), 289 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: Bot-Commit+1 by Rubber Stamper
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iae3d0047eb8c89e76d4d94044598f6f95bc020c9
Gerrit-Change-Number: 5669861
Gerrit-PatchSet: 2
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages