text-fit: Rename FitText, FitTextType, FitTextTarget, and FitTextMethod [chromium/src : main]

1 view
Skip to first unread message

Kent Tamura (Gerrit)

unread,
May 25, 2026, 9:51:20 PM (5 hours ago) May 25
to Kent Tamura, Koji Ishii, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Koji Ishii

Kent Tamura added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Kent Tamura . resolved

kojii@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Koji Ishii
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I043b1394a954ae360c58daeebfcfdb3159be3ea9
Gerrit-Change-Number: 7867233
Gerrit-PatchSet: 3
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Koji Ishii <ko...@chromium.org>
Gerrit-Comment-Date: Tue, 26 May 2026 01:50:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Koji Ishii (Gerrit)

unread,
May 25, 2026, 11:16:57 PM (4 hours ago) May 25
to Kent Tamura, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org
Attention needed from Kent Tamura

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

Code-Review+1

1 comment

Patchset-level comments
Koji Ishii . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I043b1394a954ae360c58daeebfcfdb3159be3ea9
    Gerrit-Change-Number: 7867233
    Gerrit-PatchSet: 3
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Tue, 26 May 2026 03:16:34 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 25, 2026, 11:20:19 PM (4 hours ago) May 25
    to Kent Tamura, Koji Ishii, android-bu...@system.gserviceaccount.com, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    text-fit: Rename FitText, FitTextType, FitTextTarget, and FitTextMethod

    This CL replaces 'FitText' in them with 'TextFit' for consistency with
    `text-fit` CSS property.

    This CL has no behavior changes.
    Bug: 417306102
    Change-Id: I043b1394a954ae360c58daeebfcfdb3159be3ea9
    Commit-Queue: Koji Ishii <ko...@chromium.org>
    Reviewed-by: Koji Ishii <ko...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1635907}
    Files:
    • M third_party/blink/renderer/build/scripts/core/style/make_computed_style_base.py
    • M third_party/blink/renderer/core/css/css_properties.json5
    • M third_party/blink/renderer/core/css/css_property_equality.cc
    • M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
    • M third_party/blink/renderer/core/css/properties/computed_style_utils.h
    • M third_party/blink/renderer/core/css/properties/css_parsing_utils.cc
    • M third_party/blink/renderer/core/css/properties/css_parsing_utils.h
    • M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
    • M third_party/blink/renderer/core/css/resolver/style_builder_converter.cc
    • M third_party/blink/renderer/core/css/resolver/style_builder_converter.h
    • M third_party/blink/renderer/core/layout/block_layout_algorithm.cc
    • M third_party/blink/renderer/core/layout/inline/inline_box_state.cc
    • M third_party/blink/renderer/core/layout/inline/text_fit_utils.cc
    • M third_party/blink/renderer/core/style/text_fit.cc
    • M third_party/blink/renderer/core/style/text_fit.h
    Change size: M
    Delta: 15 files changed, 77 insertions(+), 77 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Koji Ishii
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I043b1394a954ae360c58daeebfcfdb3159be3ea9
    Gerrit-Change-Number: 7867233
    Gerrit-PatchSet: 4
    Gerrit-Owner: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages