The <menu> element should act as the list owner of a list element [chromium/src : main]

0 views
Skip to first unread message

Peng Zhou (Gerrit)

unread,
Jun 28, 2024, 9:35:58 AM (5 days ago) Jun 28
to Oriol Brufau, Joey Arhar, Ian Kilpatrick, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Ian Kilpatrick, Joey Arhar and Oriol Brufau

Peng Zhou voted Commit-Queue+0

Commit-Queue+0
Open in Gerrit

Related details

Attention is currently required from:
  • Ian Kilpatrick
  • Joey Arhar
  • Oriol Brufau
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2776ae7bec16a8b7a9005f19c92444d7be657ecb
Gerrit-Change-Number: 5667497
Gerrit-PatchSet: 1
Gerrit-Owner: Peng Zhou <zhoupe...@bytedance.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Oriol Brufau <obr...@igalia.com>
Gerrit-Reviewer: Peng Zhou <zhoupe...@bytedance.com>
Gerrit-Attention: Oriol Brufau <obr...@igalia.com>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Comment-Date: Fri, 28 Jun 2024 13:35:47 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ian Kilpatrick (Gerrit)

unread,
Jul 1, 2024, 1:26:29 PM (2 days ago) Jul 1
to Peng Zhou, Oriol Brufau, Joey Arhar, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Joey Arhar, Oriol Brufau and Peng Zhou

Ian Kilpatrick voted and added 1 comment

Votes added by Ian Kilpatrick

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ian Kilpatrick . resolved

lgtm but wait for either jarhar or oriol.

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
  • Oriol Brufau
  • Peng Zhou
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2776ae7bec16a8b7a9005f19c92444d7be657ecb
Gerrit-Change-Number: 5667497
Gerrit-PatchSet: 1
Gerrit-Owner: Peng Zhou <zhoupe...@bytedance.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Oriol Brufau <obr...@igalia.com>
Gerrit-Reviewer: Peng Zhou <zhoupe...@bytedance.com>
Gerrit-Attention: Oriol Brufau <obr...@igalia.com>
Gerrit-Attention: Peng Zhou <zhoupe...@bytedance.com>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Mon, 01 Jul 2024 17:26:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Peng Zhou (Gerrit)

unread,
2:32 AM (4 hours ago) 2:32 AM
to Ian Kilpatrick, Oriol Brufau, Joey Arhar, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Joey Arhar and Oriol Brufau

Peng Zhou added 1 comment

Patchset-level comments
Peng Zhou . resolved

Hi Oriol and Joey, could you please review this patch?

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
  • Oriol Brufau
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2776ae7bec16a8b7a9005f19c92444d7be657ecb
Gerrit-Change-Number: 5667497
Gerrit-PatchSet: 1
Gerrit-Owner: Peng Zhou <zhoupe...@bytedance.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Oriol Brufau <obr...@igalia.com>
Gerrit-Reviewer: Peng Zhou <zhoupe...@bytedance.com>
Gerrit-Attention: Oriol Brufau <obr...@igalia.com>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Wed, 03 Jul 2024 06:32:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages