TaskAttribution: Propagate through EventTarget::EnqueueEvent() [chromium/src : main]
0 views
Skip to first unread message
Scott Haseley (Gerrit)
5:48 PM (5 hours ago) 5:48 PM
to Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Attention needed from Michal Mocny
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michal Mocny (Gerrit)
5:54 PM (5 hours ago) 5:54 PM
to Scott Haseley, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Attention needed from Scott Haseley
Michal Mocny voted and added 1 comment![]( "Open in Gerrit")
Votes added by Michal Mocny
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Michal Mocny . resolved
<3 (don't forget to update the documentation to mark supported now!)
Related details
Attention is currently required from:
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
6:00 PM (5 hours ago) 6:00 PM
to Scott Haseley, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Attention needed from Scott Haseley
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/56045.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention is currently required from:
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
chromeperf@appspot.gserviceaccount.com (Gerrit)
6:12 PM (5 hours ago) 6:12 PM
to Scott Haseley, Blink W3C Test Autoroller, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Attention needed from Scott Haseley
Message from chrom...@appspot.gserviceaccount.com![]( "Open in Gerrit")
📍 Job mac-m1_mini_2020-perf-pgo/speedometer3 complete.
See results at: https://pinpoint-dot-chromeperf.appspot.com/job/16627748310000
Related details
Attention is currently required from:
- Scott Haseley
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Scott Haseley (Gerrit)
6:40 PM (4 hours ago) 6:40 PM
to chrom...@appspot.gserviceaccount.com, Blink W3C Test Autoroller, Michal Mocny, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Scott Haseley voted and added 1 comment![]( "Open in Gerrit")
Votes added by Scott Haseley
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Michal Mocny . resolved
<3 (don't forget to update the documentation to mark supported now!)
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
6:44 PM (4 hours ago) 6:44 PM
to Scott Haseley, chrom...@appspot.gserviceaccount.com, Blink W3C Test Autoroller, Michal Mocny, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
TaskAttribution: Propagate through EventTarget::EnqueueEvent()
EventTarget::EnqueueEvent() is used for some events to dispatch the
event asynchronously in a new task. This can be used during API calls,
e.g. HTMLMediaElement.addTextTrack(), or from misc spec algorithms, e.g.
queuing the hashchange event during a same-document navigation -- which
is a case that needs to be instrumented to support soft navigation
detection. In either case, we should propagate the current context to
match causal/disptach propagation semantics.
Fixed: 459949678
Change-Id: I94d48dd970876242c4825856c5f1613ca7412fa6
Reviewed-by: Michal Mocny <mmo...@chromium.org>
Commit-Queue: Scott Haseley <shas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1545312}
Files:
- M third_party/blink/renderer/core/dom/events/event_target.cc
- M third_party/blink/renderer/core/dom/events/event_target.h
- A third_party/blink/web_tests/external/wpt/soft-navigation-heuristics/smoke/tentative/task-attribution-hash-change.html
Change size: M
Delta: 3 files changed, 53 insertions(+), 4 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michal Mocny
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
7:17 PM (4 hours ago) 7:17 PM
to Scott Haseley, Chromium LUCI CQ, chrom...@appspot.gserviceaccount.com, Michal Mocny, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, lighthouse-eng-extern...@google.com, speed-metrics...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/56045
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages