DOM: Rename EventTarget#on() to EventTarget#when() [chromium/src : main]

0 views
Skip to first unread message

Dominic Farolino (Gerrit)

unread,
Jul 22, 2024, 10:15:52 AM (5 days ago) Jul 22
to Joey Arhar, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, jmedle...@chromium.org
Attention needed from Joey Arhar

Dominic Farolino voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9cd744460a3545c74fb34a0418c6ffddc5e6d4e1
Gerrit-Change-Number: 5730072
Gerrit-PatchSet: 1
Gerrit-Owner: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Jul 2024 14:15:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Jul 22, 2024, 1:43:31 PM (5 days ago) Jul 22
to Dominic Farolino, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, jmedle...@chromium.org
Attention needed from Dominic Farolino

Joey Arhar voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Farolino
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9cd744460a3545c74fb34a0418c6ffddc5e6d4e1
Gerrit-Change-Number: 5730072
Gerrit-PatchSet: 1
Gerrit-Owner: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Dominic Farolino <d...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Jul 2024 17:43:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Blink W3C Test Autoroller (Gerrit)

unread,
Jul 22, 2024, 1:52:04 PM (5 days ago) Jul 22
to Dominic Farolino, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, jmedle...@chromium.org
Attention needed from Dominic Farolino

Message from Blink W3C Test Autoroller

Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/47237.

When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

Open in Gerrit

Related details

Attention is currently required from:
  • Dominic Farolino
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9cd744460a3545c74fb34a0418c6ffddc5e6d4e1
Gerrit-Change-Number: 5730072
Gerrit-PatchSet: 1
Gerrit-Owner: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Attention: Dominic Farolino <d...@chromium.org>
Gerrit-Comment-Date: Mon, 22 Jul 2024 17:51:52 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy

Dominic Farolino (Gerrit)

unread,
Jul 26, 2024, 3:10:22 PM (17 hours ago) Jul 26
to Blink W3C Test Autoroller, Joey Arhar, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, jmedle...@chromium.org
Attention needed from Joey Arhar

Dominic Farolino added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Dominic Farolino . resolved

PTAL!

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9cd744460a3545c74fb34a0418c6ffddc5e6d4e1
Gerrit-Change-Number: 5730072
Gerrit-PatchSet: 3
Gerrit-Owner: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Jul 2024 19:10:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dominic Farolino (Gerrit)

unread,
Jul 26, 2024, 7:57:29 PM (12 hours ago) Jul 26
to Hiroki Nakagawa, AyeAye, Blink W3C Test Autoroller, Joey Arhar, Chromium LUCI CQ, chromium...@chromium.org, jsbell+ser...@chromium.org, shimazu+se...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kenjibah...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, jmedle...@chromium.org
Attention needed from Joey Arhar

Dominic Farolino added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Dominic Farolino . resolved

Gerrit is saying this CL has draft comments, when I don't think there are any. So I'll just kick the bots and send this message and see what happens.

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9cd744460a3545c74fb34a0418c6ffddc5e6d4e1
Gerrit-Change-Number: 5730072
Gerrit-PatchSet: 4
Gerrit-Owner: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Jul 2024 23:57:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dominic Farolino (Gerrit)

unread,
Jul 26, 2024, 7:57:51 PM (12 hours ago) Jul 26
to Hiroki Nakagawa, AyeAye, Blink W3C Test Autoroller, Joey Arhar, Chromium LUCI CQ, chromium...@chromium.org, jsbell+ser...@chromium.org, shimazu+se...@chromium.org, kinuko+ser...@chromium.org, servicewor...@chromium.org, horo+...@chromium.org, kenjibah...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, dtapuska+...@chromium.org, jmedle...@chromium.org
Attention needed from Joey Arhar

Dominic Farolino voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I9cd744460a3545c74fb34a0418c6ffddc5e6d4e1
Gerrit-Change-Number: 5730072
Gerrit-PatchSet: 4
Gerrit-Owner: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Dominic Farolino <d...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Fri, 26 Jul 2024 23:57:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages