Add WebDXFeature use counter for font-size-adjust [chromium/src : main]

0 views
Skip to first unread message

Daniel Smith (Gerrit)

unread,
Oct 20, 2024, 11:43:00 PMOct 20
to ChangSeok Oh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
Attention needed from ChangSeok Oh

Daniel Smith added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Daniel Smith . resolved

Looking for reviewers based on the owner listed on the Chromestatus entry:

https://chromestatus.com/feature/5720910061371392

Open in Gerrit

Related details

Attention is currently required from:
  • ChangSeok Oh
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
Gerrit-Change-Number: 5942003
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Smith <daniel...@google.com>
Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: ChangSeok Oh <changs...@bytedance.com>
Gerrit-Comment-Date: Mon, 21 Oct 2024 03:42:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

ChangSeok Oh (Gerrit)

unread,
Oct 23, 2024, 5:32:24 PMOct 23
to Daniel Smith, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
Attention needed from Daniel Smith

ChangSeok Oh added 2 comments

Patchset-level comments
ChangSeok Oh . unresolved

Thanks for the heads-up about this to me. Is `WebDXFeature` different from the stats of chromestatus.com? `font-size-adjust` already seems to collect usage data. https://chromestatus.com/metrics/css/timeline/popularity/465

File components/page_load_metrics/browser/observers/use_counter_page_load_metrics_observer.cc
Line 527, Patchset 1 (Latest): {CSSSampleId::kFontSizeAdjust, WebDXFeature::kFontSizeAdjust},
ChangSeok Oh . unresolved

A sorting is needed here. It would be placed between `kFontPalette` and `kFontSynthesisSmallCaps`.

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Smith
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 1
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Daniel Smith <daniel...@google.com>
    Gerrit-Comment-Date: Wed, 23 Oct 2024 21:32:15 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Daniel Smith (Gerrit)

    unread,
    Nov 1, 2024, 4:02:39 PMNov 1
    to ChangSeok Oh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from ChangSeok Oh

    Daniel Smith added 2 comments

    Patchset-level comments
    File-level comment, Patchset 1:
    ChangSeok Oh . resolved

    Thanks for the heads-up about this to me. Is `WebDXFeature` different from the stats of chromestatus.com? `font-size-adjust` already seems to collect usage data. https://chromestatus.com/metrics/css/timeline/popularity/465

    Daniel Smith

    WebDXFeature use counters can be mapped differently, although sometimes the mapping is equivalent to a WebFeature use counter, which is (I assume) the case for font-size-adjust. More clarity might come from the bug in the description

    File components/page_load_metrics/browser/observers/use_counter_page_load_metrics_observer.cc
    Line 527, Patchset 1: {CSSSampleId::kFontSizeAdjust, WebDXFeature::kFontSizeAdjust},
    ChangSeok Oh . resolved

    A sorting is needed here. It would be placed between `kFontPalette` and `kFontSynthesisSmallCaps`.

    Daniel Smith

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • ChangSeok Oh
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Comment-Date: Fri, 01 Nov 2024 20:02:30 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: ChangSeok Oh <changs...@bytedance.com>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    ChangSeok Oh (Gerrit)

    unread,
    Nov 6, 2024, 5:21:38 PMNov 6
    to Daniel Smith, Dominik Röttsches, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Daniel Smith and Dominik Röttsches

    ChangSeok Oh added 1 comment

    Patchset-level comments
    File-level comment, Patchset 2 (Latest):
    ChangSeok Oh . resolved

    It looks good to me, but an additional reviewer may be needed. cc'ed @dr...@chromium.org

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Smith
    • Dominik Röttsches
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Attention: Daniel Smith <daniel...@google.com>
    Gerrit-Comment-Date: Wed, 06 Nov 2024 22:21:30 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Dominik Röttsches (Gerrit)

    unread,
    Nov 7, 2024, 3:14:04 AMNov 7
    to Daniel Smith, Rune Lillesveen, ChangSeok Oh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Daniel Smith and Rune Lillesveen

    Dominik Röttsches voted and added 1 comment

    Votes added by Dominik Röttsches

    Code-Review+1

    1 comment

    Patchset-level comments
    Dominik Röttsches . resolved

    Tentative LGTM (after rebasing), but let's hear Rune's opinion - I am not so familiar with the mapping process.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Smith
    • Rune Lillesveen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Daniel Smith <daniel...@google.com>
    Gerrit-Comment-Date: Thu, 07 Nov 2024 08:13:50 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rune Lillesveen (Gerrit)

    unread,
    Nov 7, 2024, 3:37:15 AMNov 7
    to Daniel Smith, Rune Lillesveen, Dominik Röttsches, ChangSeok Oh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Daniel Smith

    Rune Lillesveen voted and added 1 comment

    Votes added by Rune Lillesveen

    Code-Review+1

    1 comment

    Patchset-level comments
    Rune Lillesveen . resolved

    The other part would be the yml files for wpt, but that looks like it's already mapped: https://source.chromium.org/search?q=font-size-adjust%20yml

    lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Smith
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Daniel Smith <daniel...@google.com>
    Gerrit-Comment-Date: Thu, 07 Nov 2024 08:37:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Smith (Gerrit)

    unread,
    Nov 7, 2024, 1:36:56 PMNov 7
    to Nico Weber, Rune Lillesveen, Dominik Röttsches, ChangSeok Oh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Dominik Röttsches, Nico Weber and Rune Lillesveen

    Daniel Smith added 1 comment

    Patchset-level comments
    File-level comment, Patchset 3 (Latest):
    Daniel Smith . resolved

    Sorry, this needs a re-review after rebase it seems.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dominik Röttsches
    • Nico Weber
    • Rune Lillesveen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Attention: Nico Weber <tha...@chromium.org>
    Gerrit-Comment-Date: Thu, 07 Nov 2024 18:36:42 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nico Weber (Gerrit)

    unread,
    Nov 7, 2024, 1:47:25 PMNov 7
    to Daniel Smith, Nico Weber, Rune Lillesveen, Dominik Röttsches, ChangSeok Oh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Daniel Smith, Dominik Röttsches and Rune Lillesveen

    Nico Weber voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Smith
    • Dominik Röttsches
    • Rune Lillesveen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Attention: Daniel Smith <daniel...@google.com>
    Gerrit-Comment-Date: Thu, 07 Nov 2024 18:47:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Rune Lillesveen (Gerrit)

    unread,
    Nov 7, 2024, 2:42:26 PMNov 7
    to Daniel Smith, Rune Lillesveen, Nico Weber, Dominik Röttsches, ChangSeok Oh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Daniel Smith and Dominik Röttsches

    Rune Lillesveen voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Smith
    • Dominik Röttsches
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Attention: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Attention: Daniel Smith <daniel...@google.com>
    Gerrit-Comment-Date: Thu, 07 Nov 2024 19:42:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Rune Lillesveen (Gerrit)

    unread,
    Nov 12, 2024, 3:34:18 AMNov 12
    to Daniel Smith, Rune Lillesveen, Code Review Nudger, Nico Weber, Dominik Röttsches, ChangSeok Oh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Daniel Smith, Dominik Röttsches and Nico Weber

    Rune Lillesveen voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Smith
    • Dominik Röttsches
    • Nico Weber
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 4
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Attention: Daniel Smith <daniel...@google.com>
    Gerrit-Attention: Nico Weber <tha...@chromium.org>
    Gerrit-Comment-Date: Tue, 12 Nov 2024 08:34:00 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nico Weber (Gerrit)

    unread,
    Nov 12, 2024, 5:41:20 AMNov 12
    to Daniel Smith, Nico Weber, Rune Lillesveen, Code Review Nudger, Dominik Röttsches, ChangSeok Oh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Daniel Smith and Dominik Röttsches

    Nico Weber voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Smith
    • Dominik Röttsches
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 4
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Attention: Daniel Smith <daniel...@google.com>
    Gerrit-Comment-Date: Tue, 12 Nov 2024 10:41:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Dominik Röttsches (Gerrit)

    unread,
    Nov 12, 2024, 5:51:37 AMNov 12
    to Daniel Smith, Nico Weber, Rune Lillesveen, Code Review Nudger, ChangSeok Oh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Daniel Smith

    Dominik Röttsches voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Smith
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 4
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Daniel Smith <daniel...@google.com>
    Gerrit-Comment-Date: Tue, 12 Nov 2024 10:51:25 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Smith (Gerrit)

    unread,
    Nov 12, 2024, 1:25:37 PMNov 12
    to Dominik Röttsches, Nico Weber, Rune Lillesveen, Code Review Nudger, ChangSeok Oh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Dominik Röttsches, Nico Weber and Rune Lillesveen

    Daniel Smith added 1 comment

    Patchset-level comments
    File-level comment, Patchset 5 (Latest):
    Daniel Smith . resolved

    I'm not sure how to handle this... Rebasing the change and resolving conflicts continues to remove approvals each time. Approvals cannot come fast enough before new changes apply to the files and conflicts arise. Does anyone know the best path forward here?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dominik Röttsches
    • Nico Weber
    • Rune Lillesveen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 5
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Attention: Nico Weber <tha...@chromium.org>
    Gerrit-Comment-Date: Tue, 12 Nov 2024 18:25:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nico Weber (Gerrit)

    unread,
    Nov 12, 2024, 1:28:57 PMNov 12
    to Daniel Smith, Nico Weber, Dominik Röttsches, Rune Lillesveen, Code Review Nudger, ChangSeok Oh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Daniel Smith, Dominik Röttsches and Rune Lillesveen

    Nico Weber voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Smith
    • Dominik Röttsches
    • Rune Lillesveen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 5
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Attention: Daniel Smith <daniel...@google.com>
    Gerrit-Comment-Date: Tue, 12 Nov 2024 18:28:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nico Weber (Gerrit)

    unread,
    Nov 12, 2024, 1:29:10 PMNov 12
    to Daniel Smith, Nico Weber, Dominik Röttsches, Rune Lillesveen, Code Review Nudger, ChangSeok Oh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Daniel Smith, Dominik Röttsches and Rune Lillesveen

    Nico Weber voted

    Commit-Queue+2
    Owners-Override+1
    Gerrit-Comment-Date: Tue, 12 Nov 2024 18:28:57 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nico Weber (Gerrit)

    unread,
    Nov 12, 2024, 1:29:53 PMNov 12
    to Daniel Smith, Chromium LUCI CQ, Nico Weber, Dominik Röttsches, Rune Lillesveen, Code Review Nudger, ChangSeok Oh, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Daniel Smith, Dominik Röttsches and Rune Lillesveen

    Nico Weber voted and added 1 comment

    Votes added by Nico Weber

    Owners-Override+0

    1 comment

    Patchset-level comments
    Nico Weber . resolved

    Hm, OO+1 doesn't help either. Ping reviewers on chat, I suppose?

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Smith
    • Dominik Röttsches
    • Rune Lillesveen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 5
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Attention: Daniel Smith <daniel...@google.com>
    Gerrit-Comment-Date: Tue, 12 Nov 2024 18:29:41 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    ChangSeok Oh (Gerrit)

    unread,
    Nov 12, 2024, 2:30:14 PMNov 12
    to Daniel Smith, Chromium LUCI CQ, Nico Weber, Dominik Röttsches, Rune Lillesveen, Code Review Nudger, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Daniel Smith, Dominik Röttsches and Rune Lillesveen

    ChangSeok Oh voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Smith
    • Dominik Röttsches
    • Rune Lillesveen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 5
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Attention: Daniel Smith <daniel...@google.com>
    Gerrit-Comment-Date: Tue, 12 Nov 2024 19:30:04 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Smith (Gerrit)

    unread,
    Nov 12, 2024, 3:17:22 PMNov 12
    to ChangSeok Oh, Chromium LUCI CQ, Nico Weber, Dominik Röttsches, Rune Lillesveen, Code Review Nudger, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org
    Attention needed from Dominik Röttsches and Rune Lillesveen

    Daniel Smith voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Dominik Röttsches
    • Rune Lillesveen
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 5
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Code Review Nudger <android-build...@prod.google.com>
    Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Comment-Date: Tue, 12 Nov 2024 20:17:12 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Nov 12, 2024, 4:11:17 PMNov 12
    to Daniel Smith, ChangSeok Oh, Nico Weber, Dominik Röttsches, Rune Lillesveen, Code Review Nudger, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, bmcquad...@chromium.org, csharris...@chromium.org, haoliu...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, speed-metr...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Add WebDXFeature use counter for font-size-adjust

    This adds a mapping of existing WebFeature use counters into a new
    WebDXFeature use counter.

    This is an effort to add new telemetry counters to features shipped since 2020.
    Bug: 366475997
    Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Commit-Queue: Daniel Smith <daniel...@google.com>
    Reviewed-by: Nico Weber <tha...@chromium.org>
    Reviewed-by: ChangSeok Oh <changs...@bytedance.com>
    Cr-Commit-Position: refs/heads/main@{#1381963}
    Files:
    • M components/page_load_metrics/browser/observers/use_counter_page_load_metrics_observer.cc
    • M third_party/blink/public/mojom/use_counter/metrics/webdx_feature.mojom
    • M tools/metrics/histograms/enums.xml
    Change size: XS
    Delta: 3 files changed, 3 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Nico Weber, +1 by ChangSeok Oh
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3ed8338809c3c778cdc6c41d34503168982520dc
    Gerrit-Change-Number: 5942003
    Gerrit-PatchSet: 6
    Gerrit-Owner: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: ChangSeok Oh <changs...@bytedance.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Smith <daniel...@google.com>
    Gerrit-Reviewer: Dominik Röttsches <dr...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages