[html-in-canvas] Do not report intersection observer visibility [chromium/src : main]

0 views

Skip to first unread message

Philip Rogers (Gerrit)

unread,

4:57 PM (6 hours ago) 4:57 PM

to Stefan Zager, chromium...@chromium.org, blink-...@chromium.org

Attention needed from Stefan Zager

Philip Rogers voted

Auto-Submit	+1
Commit-Queue	+1

Open in Gerrit

Related details

Attention is currently required from:

Stefan Zager

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Stefan Zager (Gerrit)

unread,

5:06 PM (6 hours ago) 5:06 PM

to Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org

Attention needed from Philip Rogers

Stefan Zager voted and added 1 comment

Votes added by Stefan Zager

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Stefan Zager . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:

Philip Rogers

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

5:58 PM (5 hours ago) 5:58 PM

to Philip Rogers, Stefan Zager, chromium...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[html-in-canvas] Do not report intersection observer visibility

https://github.com/WICG/html-in-canvas/issues/63#issuecomment-3523839697

Fixed: 460743385

Change-Id: Ide41a53cb1d1a2bcbde60fc4254bb46313577714

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7155713

Reviewed-by: Stefan Zager <sza...@chromium.org>

Commit-Queue: Philip Rogers <p...@chromium.org>

Commit-Queue: Stefan Zager <sza...@chromium.org>

Auto-Submit: Philip Rogers <p...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1545278}

Files:

M third_party/blink/renderer/core/intersection_observer/intersection_geometry.cc
A third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/intersection-observer-visibility.html

Change size: S

Delta: 2 files changed, 43 insertions(+), 0 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Stefan Zager

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages