[html-in-canvas] Do not report intersection observer visibility [chromium/src : main]

0 views
Skip to first unread message

Philip Rogers (Gerrit)

unread,
4:57 PM (6 hours ago) 4:57 PM
to Stefan Zager, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Stefan Zager

Philip Rogers voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Stefan Zager
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ide41a53cb1d1a2bcbde60fc4254bb46313577714
Gerrit-Change-Number: 7155713
Gerrit-PatchSet: 2
Gerrit-Owner: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
Gerrit-Attention: Stefan Zager <sza...@chromium.org>
Gerrit-Comment-Date: Fri, 14 Nov 2025 21:57:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Stefan Zager (Gerrit)

unread,
5:06 PM (6 hours ago) 5:06 PM
to Philip Rogers, Chromium LUCI CQ, chromium...@chromium.org, blink-...@chromium.org
Attention needed from Philip Rogers

Stefan Zager voted and added 1 comment

Votes added by Stefan Zager

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Stefan Zager . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ide41a53cb1d1a2bcbde60fc4254bb46313577714
    Gerrit-Change-Number: 7155713
    Gerrit-PatchSet: 2
    Gerrit-Owner: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Comment-Date: Fri, 14 Nov 2025 22:05:50 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    5:58 PM (5 hours ago) 5:58 PM
    to Philip Rogers, Stefan Zager, chromium...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [html-in-canvas] Do not report intersection observer visibility

    https://github.com/WICG/html-in-canvas/issues/63#issuecomment-3523839697
    Fixed: 460743385
    Change-Id: Ide41a53cb1d1a2bcbde60fc4254bb46313577714
    Reviewed-by: Stefan Zager <sza...@chromium.org>
    Commit-Queue: Philip Rogers <p...@chromium.org>
    Commit-Queue: Stefan Zager <sza...@chromium.org>
    Auto-Submit: Philip Rogers <p...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1545278}
    Files:
    • M third_party/blink/renderer/core/intersection_observer/intersection_geometry.cc
    • A third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/intersection-observer-visibility.html
    Change size: S
    Delta: 2 files changed, 43 insertions(+), 0 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Stefan Zager
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ide41a53cb1d1a2bcbde60fc4254bb46313577714
    Gerrit-Change-Number: 7155713
    Gerrit-PatchSet: 3
    Gerrit-Owner: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Stefan Zager <sza...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages