[text-indent] Remove `CssTextIndentAsPrimitive` runtime flag [chromium/src : main]

1 view
Skip to first unread message

Koji Ishii (Gerrit)

unread,
May 25, 2026, 10:59:43 PM (4 hours ago) May 25
to Kent Tamura, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

Auto-Submit+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If7c8fbce1d94ac450fe68153a37817d1deba28ad
Gerrit-Change-Number: 7867521
Gerrit-PatchSet: 2
Gerrit-Owner: Koji Ishii <ko...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Tue, 26 May 2026 02:59:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kent Tamura (Gerrit)

unread,
May 25, 2026, 11:19:50 PM (4 hours ago) May 25
to Koji Ishii, Kent Tamura, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Koji Ishii

Kent Tamura voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Koji Ishii
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If7c8fbce1d94ac450fe68153a37817d1deba28ad
    Gerrit-Change-Number: 7867521
    Gerrit-PatchSet: 2
    Gerrit-Owner: Koji Ishii <ko...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-Attention: Koji Ishii <ko...@chromium.org>
    Gerrit-Comment-Date: Tue, 26 May 2026 03:19:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 25, 2026, 11:24:31 PM (4 hours ago) May 25
    to Koji Ishii, Kent Tamura, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [text-indent] Remove `CssTextIndentAsPrimitive` runtime flag

    This runtime flag is a small improvement, done at
    crrev.com/c/7414438, as part of enhancing the `text-indent`
    property.

    It's been enabled since M146.
    Bug: 434361099
    Change-Id: If7c8fbce1d94ac450fe68153a37817d1deba28ad
    Commit-Queue: Kent Tamura <tk...@chromium.org>
    Auto-Submit: Koji Ishii <ko...@chromium.org>
    Reviewed-by: Kent Tamura <tk...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1635909}
    Files:
    • M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
    • M third_party/blink/renderer/platform/runtime_enabled_features.json5
    Change size: XS
    Delta: 2 files changed, 2 insertions(+), 7 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Kent Tamura
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If7c8fbce1d94ac450fe68153a37817d1deba28ad
    Gerrit-Change-Number: 7867521
    Gerrit-PatchSet: 3
    Gerrit-Owner: Koji Ishii <ko...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages