webnn: Remove grace-period support for MLTensorUsage [chromium/src : main]
0 views
Skip to first unread message
Austin Sullivan (Gerrit)
Nov 12, 2024, 2:36:15 PMNov 12
to Dwayne Robinson, Bryan Bernhart, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, ningxin hu, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Austin Sullivan added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Austin Sullivan (Gerrit)
Nov 12, 2024, 3:21:09 PMNov 12
to ningxin hu, Dwayne Robinson, Bryan Bernhart, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from ningxin hu
Austin Sullivan voted and added 1 comment![]( "Open in Gerrit")
Votes added by Austin Sullivan
| Auto-Submit | +1 |
1 comment
Patchset-level comments
Austin Sullivan . resolved
The WebNN samples and dev preview examples all appear to have been updated to use the new format. PTAL?
Related details
Attention is currently required from:
- ningxin hu
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
ningxin hu (Gerrit)
Nov 12, 2024, 7:16:44 PMNov 12
to Austin Sullivan, Dwayne Robinson, Bryan Bernhart, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Austin Sullivan
ningxin hu voted and added 1 comment![]( "Open in Gerrit")
Votes added by ningxin hu
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Austin Sullivan
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Nov 12, 2024, 7:19:54 PMNov 12
to Austin Sullivan, ningxin hu, Dwayne Robinson, Bryan Bernhart, chromium...@chromium.org, Kentaro Hara, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
webnn: Remove grace-period support for MLTensorUsage
https://crrev.com/7bb2874c deprecated MLTensorUsage in favor of boolean
flags and added special-case handling to allow passing this information
with both the old and new formats for a while, for the sake of not
breaking existing uses of WebNN
The M132 branch was just cut, so it's time to remove this workaround
Fixed: 343638938
Change-Id: Ieab328020b210ae897b47f0b46beb139355d5b18
Auto-Submit: Austin Sullivan <asu...@chromium.org>
Commit-Queue: ningxin hu <ningx...@intel.com>
Reviewed-by: ningxin hu <ningx...@intel.com>
Cr-Commit-Position: refs/heads/main@{#1382062}
Files:
- M third_party/blink/renderer/bindings/generated_in_modules.gni
- M third_party/blink/renderer/bindings/idl_in_modules.gni
- M third_party/blink/renderer/modules/ml/ml_context.cc
- M third_party/blink/renderer/modules/ml/webnn/ml_graph_test.cc
- M third_party/blink/renderer/modules/ml/webnn/ml_tensor.cc
- M third_party/blink/renderer/modules/ml/webnn/ml_tensor.h
- M third_party/blink/renderer/modules/ml/webnn/ml_tensor.idl
- M third_party/blink/renderer/modules/ml/webnn/ml_tensor_descriptor.idl
- D third_party/blink/renderer/modules/ml/webnn/ml_tensor_usage.h
- D third_party/blink/renderer/modules/ml/webnn/ml_tensor_usage.idl
Change size: M
Delta: 10 files changed, 0 insertions(+), 142 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by ningxin hu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dwayne Robinson (Gerrit)
Nov 12, 2024, 8:16:18 PMNov 12
to Austin Sullivan, Chromium LUCI CQ, ningxin hu, Bryan Bernhart, chromium...@chromium.org, Kentaro Hara, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Dwayne Robinson added 1 comment![]( "Open in Gerrit")
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages