webnn: Remove grace-period support for MLTensorUsage [chromium/src : main]

0 views
Skip to first unread message

Austin Sullivan (Gerrit)

unread,
Nov 12, 2024, 2:36:15 PMNov 12
to Dwayne Robinson, Bryan Bernhart, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, ningxin hu, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Austin Sullivan added 1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieab328020b210ae897b47f0b46beb139355d5b18
Gerrit-Change-Number: 6015318
Gerrit-PatchSet: 1
Gerrit-Owner: Austin Sullivan <asu...@chromium.org>
Gerrit-Reviewer: Austin Sullivan <asu...@chromium.org>
Gerrit-CC: Bryan Bernhart <bryan.b...@intel.com>
Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: ningxin hu <ningx...@intel.com>
Gerrit-Comment-Date: Tue, 12 Nov 2024 19:36:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Austin Sullivan (Gerrit)

unread,
Nov 12, 2024, 3:21:09 PMNov 12
to ningxin hu, Dwayne Robinson, Bryan Bernhart, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from ningxin hu

Austin Sullivan voted and added 1 comment

Votes added by Austin Sullivan

Auto-Submit+1

1 comment

Patchset-level comments
Austin Sullivan . resolved

The WebNN samples and dev preview examples all appear to have been updated to use the new format. PTAL?

Open in Gerrit

Related details

Attention is currently required from:
  • ningxin hu
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieab328020b210ae897b47f0b46beb139355d5b18
Gerrit-Change-Number: 6015318
Gerrit-PatchSet: 1
Gerrit-Owner: Austin Sullivan <asu...@chromium.org>
Gerrit-Reviewer: Austin Sullivan <asu...@chromium.org>
Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
Gerrit-CC: Bryan Bernhart <bryan.b...@intel.com>
Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: ningxin hu <ningx...@intel.com>
Gerrit-Comment-Date: Tue, 12 Nov 2024 20:20:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

ningxin hu (Gerrit)

unread,
Nov 12, 2024, 7:16:44 PMNov 12
to Austin Sullivan, Dwayne Robinson, Bryan Bernhart, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org
Attention needed from Austin Sullivan

ningxin hu voted and added 1 comment

Votes added by ningxin hu

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
ningxin hu . resolved

lgtm, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Austin Sullivan
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieab328020b210ae897b47f0b46beb139355d5b18
Gerrit-Change-Number: 6015318
Gerrit-PatchSet: 2
Gerrit-Owner: Austin Sullivan <asu...@chromium.org>
Gerrit-Reviewer: Austin Sullivan <asu...@chromium.org>
Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
Gerrit-CC: Bryan Bernhart <bryan.b...@intel.com>
Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Attention: Austin Sullivan <asu...@chromium.org>
Gerrit-Comment-Date: Wed, 13 Nov 2024 00:16:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Nov 12, 2024, 7:19:54 PMNov 12
to Austin Sullivan, ningxin hu, Dwayne Robinson, Bryan Bernhart, chromium...@chromium.org, Kentaro Hara, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
webnn: Remove grace-period support for MLTensorUsage

https://crrev.com/7bb2874c deprecated MLTensorUsage in favor of boolean
flags and added special-case handling to allow passing this information
with both the old and new formats for a while, for the sake of not
breaking existing uses of WebNN

The M132 branch was just cut, so it's time to remove this workaround
Fixed: 343638938
Change-Id: Ieab328020b210ae897b47f0b46beb139355d5b18
Auto-Submit: Austin Sullivan <asu...@chromium.org>
Commit-Queue: ningxin hu <ningx...@intel.com>
Reviewed-by: ningxin hu <ningx...@intel.com>
Cr-Commit-Position: refs/heads/main@{#1382062}
Files:
  • M third_party/blink/renderer/bindings/generated_in_modules.gni
  • M third_party/blink/renderer/bindings/idl_in_modules.gni
  • M third_party/blink/renderer/modules/ml/ml_context.cc
  • M third_party/blink/renderer/modules/ml/webnn/ml_graph_test.cc
  • M third_party/blink/renderer/modules/ml/webnn/ml_tensor.cc
  • M third_party/blink/renderer/modules/ml/webnn/ml_tensor.h
  • M third_party/blink/renderer/modules/ml/webnn/ml_tensor.idl
  • M third_party/blink/renderer/modules/ml/webnn/ml_tensor_descriptor.idl
  • D third_party/blink/renderer/modules/ml/webnn/ml_tensor_usage.h
  • D third_party/blink/renderer/modules/ml/webnn/ml_tensor_usage.idl
Change size: M
Delta: 10 files changed, 0 insertions(+), 142 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by ningxin hu
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieab328020b210ae897b47f0b46beb139355d5b18
Gerrit-Change-Number: 6015318
Gerrit-PatchSet: 3
Gerrit-Owner: Austin Sullivan <asu...@chromium.org>
Gerrit-Reviewer: Austin Sullivan <asu...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
Gerrit-CC: Bryan Bernhart <bryan.b...@intel.com>
open
diffy
satisfied_requirement

Dwayne Robinson (Gerrit)

unread,
Nov 12, 2024, 8:16:18 PMNov 12
to Austin Sullivan, Chromium LUCI CQ, ningxin hu, Bryan Bernhart, chromium...@chromium.org, Kentaro Hara, Jiewei Qian, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org

Dwayne Robinson added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Dwayne Robinson . resolved

👍

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieab328020b210ae897b47f0b46beb139355d5b18
Gerrit-Change-Number: 6015318
Gerrit-PatchSet: 3
Gerrit-Owner: Austin Sullivan <asu...@chromium.org>
Gerrit-Reviewer: Austin Sullivan <asu...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: ningxin hu <ningx...@intel.com>
Gerrit-CC: Bryan Bernhart <bryan.b...@intel.com>
Gerrit-CC: Dwayne Robinson <dwa...@microsoft.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Wed, 13 Nov 2024 01:16:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages